TestRequestBuilder crash when running test in class with @Ignore [65828576]

Fixed

Bug

Status Update

No update yet.

Description

dr...@gmail.com

created issue #1

Sep 18, 2017 03:50PM

If I add the JUnit @Ignore annotation to my test class at the class level (rather than at the method level) and then try to run an individual test method from that class using "adb shell am instrument" and the "-e class com.example.MyTestClass#myTest" argument, I see ATSL crashing with the following stack trace.

This is using version 0.5 of the runner artifact.

E/TestExecutor( 5297): Fatal exception when running tests
E/TestExecutor( 5297): java.lang.NullPointerException: Attempt to invoke interface method 'int java.lang.CharSequence.length()' on a null object reference
E/TestExecutor( 5297): at java.util.regex.Matcher.reset(Matcher.java:177)
E/TestExecutor( 5297): at java.util.regex.Matcher.<init>(Matcher.java:90)
E/TestExecutor( 5297): at java.util.regex.Pattern.matcher(Pattern.java:297)
E/TestExecutor( 5297): at android.support.test.internal.runner.TestRequestBuilder$MethodFilter.stripParameterizedSuffix(TestRequestBuilder.java:503)
E/TestExecutor( 5297): at android.support.test.internal.runner.TestRequestBuilder$MethodFilter.shouldRun(TestRequestBuilder.java:486)
E/TestExecutor( 5297): at android.support.test.internal.runner.TestRequestBuilder$ClassAndMethodFilter.shouldRun(TestRequestBuilder.java:421)
E/TestExecutor( 5297): at org.junit.runner.manipulation.Filter$3.shouldRun(Filter.java:112)
E/TestExecutor( 5297): at org.junit.runners.ParentRunner.shouldRun(ParentRunner.java:434)
E/TestExecutor( 5297): at org.junit.runners.ParentRunner.filter(ParentRunner.java:382)
E/TestExecutor( 5297): at org.junit.runner.manipulation.Filter.apply(Filter.java:97)
E/TestExecutor( 5297): at android.support.test.internal.runner.TestRequestBuilder$LenientFilterRequest.getRunner(TestRequestBuilder.java:381)
E/TestExecutor( 5297): at org.junit.runner.JUnitCore.run(JUnitCore.java:115)
E/TestExecutor( 5297): at android.support.test.internal.runner.TestExecutor.execute(TestExecutor.java:59)
E/TestExecutor( 5297): at android.support.test.runner.AndroidJUnitRunner.onStart(AndroidJUnitRunner.java:262)
E/TestExecutor( 5297): at com.example.MyTestRunner.onStart(MyTestRunner.java:89)
E/TestExecutor( 5297): at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1853)

Comments

uc...@google.com <uc...@google.com> Sep 18, 2017 09:04PM

Assigned to ja...@google.com.

ja...@google.com <ja...@google.com> #2Sep 21, 2017 12:53AM

Reassigned to sl...@google.com.

+1, but Deferred does not solve the Observer problem that Rx and LiveData do, so I guess Google should implement Channels instead of LiveData which is actually a Kotlin Coroutine counterpart. Looking forward to this as I've decided not to use RxJava in most of future projects due to Kotlin Coroutines..

sl...@google.com <sl...@google.com> #3Sep 21, 2017 05:30PM

Accepted by sl...@google.com.

Project: platform/frameworks/support
Branch: androidx-master-dev

commit e78cceffeac28f0028342990c1391c640edf453c
Author: Daniel Santiago Rivera <danysantiago@google.com>
Date: Wed Nov 28 12:40:24 2018

Room Support for Coroutines

This change allows users to define suspend functions in DAOs with
@Query, @Insert, @Update and @Delete. The new artifact room-coroutine
defines a helper classes for supporting the feature.

Bug: 69474692
Test: ./gradlew room:integration-tests:kotlintestapp:cC
Change-Id: Id73a6b845df3f21f99d14cb6980130dcf3885c81

M buildSrc/src/main/kotlin/androidx/build/PublishDocsRules.kt
A room/compiler/src/main/kotlin/androidx/room/ext/KotlinMetadataElement.kt
D room/compiler/src/main/kotlin/androidx/room/ext/KotlinMetadataProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/ext/element_ext.kt
M room/compiler/src/main/kotlin/androidx/room/ext/javapoet_ext.kt
M room/compiler/src/main/kotlin/androidx/room/processor/DeletionMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/processor/InsertionMethodProcessor.kt
A room/compiler/src/main/kotlin/androidx/room/processor/MethodProcessorDelegate.kt
M room/compiler/src/main/kotlin/androidx/room/processor/PojoProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/processor/ProcessorErrors.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/processor/RawQueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/processor/ShortcutMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/processor/UpdateMethodProcessor.kt
A room/compiler/src/main/kotlin/androidx/room/solver/query/result/CoroutineResultBinder.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
A room/compiler/src/main/kotlin/androidx/room/solver/shortcut/binder/CoroutineDeleteOrUpdateMethodBinder.kt
A room/compiler/src/main/kotlin/androidx/room/solver/shortcut/binder/CoroutineInsertMethodBinder.kt
M room/compiler/src/main/kotlin/androidx/room/solver/shortcut/result/DeleteOrUpdateMethodAdapter.kt
M room/compiler/src/main/kotlin/androidx/room/solver/shortcut/result/InsertMethodAdapter.kt
M room/compiler/src/main/kotlin/androidx/room/vo/RelationCollector.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
A room/coroutines/build.gradle
A room/coroutines/src/main/AndroidManifest.xml
A room/coroutines/src/main/java/androidx/room/CoroutinesRoom.kt
M room/integration-tests/kotlintestapp/build.gradle
M room/integration-tests/kotlintestapp/src/androidTest/java/androidx/room/integration/kotlintestapp/dao/BooksDao.kt
M room/integration-tests/kotlintestapp/src/androidTest/java/androidx/room/integration/kotlintestapp/test/BooksDaoTest.kt
A room/integration-tests/kotlintestapp/src/androidTest/java/androidx/room/integration/kotlintestapp/test/SuspendRoomDispatcherTest.kt
M settings.gradle

https://android-review.googlesource.com/833705

https://goto.google.com/android-sha1/e78cceffeac28f0028342990c1391c640edf453c

sl...@google.com <sl...@google.com> Nov 15, 2017 08:04PM

Marked as fixed.

st...@gmail.com <st...@gmail.com> #4Nov 8, 2024 03:03AM

So do you support any Coroutine "observables" like channels? Or these are just one-off suspending calls?

Issue 65828576