Fixed
Status Update
No update yet.
Comments
yb...@google.com
since these are in public API (:/) we need to do this in 1.2
yb...@google.com
since it is already marked as deprecated, we can probably do it by now.
lo...@gmail.com
Opening diff shortly
yb...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit d576cbdc911cba16638a44fd8223391a90a07ef7
Author: Mike Nakhimovich <digitalbuddha@users.noreply.github.com>
Date: Tue Aug 11 09:30:34 2020
[GH] Hide deprecated internal API.
## Proposed Changes
* `RoomDatabase.java` has protected `mCallbacks` field which is leaking in the API docs, we should @Hide it.
## Testing
Test: Ran unit tests locally
## Issues Fixed
Fixes: 76109329
This is an imported pull request fromhttps://github.com/androidx/androidx/pull/61 .
Resolves #61
Github-Pr-Head-Sha: 6440daa3a63752c7f9d5ba2a390248cd85bc634f
GitOrigin-RevId: fe92d8466a59b44b218b6ca3cbd57dcda17992f7
Change-Id: Id599cdf5b02b32bdae0166266fb7da967598fe92
A room/runtime/api/current.ignore
M room/runtime/api/current.txt
M room/runtime/api/public_plus_experimental_current.txt
M room/runtime/api/restricted_current.txt
M room/runtime/src/main/java/androidx/room/RoomDatabase.java
https://android-review.googlesource.com/1396827
Branch: androidx-master-dev
commit d576cbdc911cba16638a44fd8223391a90a07ef7
Author: Mike Nakhimovich <digitalbuddha@users.noreply.github.com>
Date: Tue Aug 11 09:30:34 2020
[GH] Hide deprecated internal API.
## Proposed Changes
* `RoomDatabase.java` has protected `mCallbacks` field which is leaking in the API docs, we should @Hide it.
## Testing
Test: Ran unit tests locally
## Issues Fixed
Fixes: 76109329
This is an imported pull request from
Resolves #61
Github-Pr-Head-Sha: 6440daa3a63752c7f9d5ba2a390248cd85bc634f
GitOrigin-RevId: fe92d8466a59b44b218b6ca3cbd57dcda17992f7
Change-Id: Id599cdf5b02b32bdae0166266fb7da967598fe92
A room/runtime/api/current.ignore
M room/runtime/api/current.txt
M room/runtime/api/public_plus_experimental_current.txt
M room/runtime/api/restricted_current.txt
M room/runtime/src/main/java/androidx/room/RoomDatabase.java
yb...@google.com
i don't think we'll do the other table case as it is valid if someone has identical content tables.
Moreover, Room does not consider that return value as an Entitiy, rather it considers it as a regular pojo.
Moreover, Room does not consider that return value as an Entitiy, rather it considers it as a regular pojo.
yb...@google.com
ok I have a CL ready for this. Hopefully should be in beta2.
lo...@gmail.com
That was fast, thanks Yigit!
Description
Version used: beta-1
Devices/Android versions reproduced on: happens at compile time
The sample project attached to this bug report shows that Room does not check if I'm trying to get an entity from another table. The consequence is that sometimes I get an error which doesn't really say much: "error: incompatible types: <null> cannot be converted to boolean". This error is triggered by Kotlin's Boolean, which in the bytecode can be sometimes primitive types and so null fails to match. But when using another type, everything would be fine except that we are querying the wrong table for that entity.
See in the sample project the SomeDao.kt class: the first query causes a compile time error, while the second one (which for me is still invalid and would crash immediately in Kotlin since the type is non null) apparently is OK (is that expected? I understand that this is what allows Room to returns a different object from the entity and that's really powerful, but at the same time it opens the doors for a lot of mistakes which won't be catched at compile time)