Fixed
Status Update
Comments
yb...@google.com <yb...@google.com> #2
since these are in public API (:/) we need to do this in 1.2
ak...@gmail.com <ak...@gmail.com> #3
since it is already marked as deprecated, we can probably do it by now.
yb...@google.com <yb...@google.com>
ak...@gmail.com <ak...@gmail.com> #5
Project: platform/frameworks/support
Branch: androidx-master-dev
commit d576cbdc911cba16638a44fd8223391a90a07ef7
Author: Mike Nakhimovich <digitalbuddha@users.noreply.github.com>
Date: Tue Aug 11 09:30:34 2020
[GH] Hide deprecated internal API.
## Proposed Changes
* `RoomDatabase.java` has protected `mCallbacks` field which is leaking in the API docs, we should @Hide it.
## Testing
Test: Ran unit tests locally
## Issues Fixed
Fixes: 76109329
This is an imported pull request fromhttps://github.com/androidx/androidx/pull/61 .
Resolves #61
Github-Pr-Head-Sha: 6440daa3a63752c7f9d5ba2a390248cd85bc634f
GitOrigin-RevId: fe92d8466a59b44b218b6ca3cbd57dcda17992f7
Change-Id: Id599cdf5b02b32bdae0166266fb7da967598fe92
A room/runtime/api/current.ignore
M room/runtime/api/current.txt
M room/runtime/api/public_plus_experimental_current.txt
M room/runtime/api/restricted_current.txt
M room/runtime/src/main/java/androidx/room/RoomDatabase.java
https://android-review.googlesource.com/1396827
Branch: androidx-master-dev
commit d576cbdc911cba16638a44fd8223391a90a07ef7
Author: Mike Nakhimovich <digitalbuddha@users.noreply.github.com>
Date: Tue Aug 11 09:30:34 2020
[GH] Hide deprecated internal API.
## Proposed Changes
* `RoomDatabase.java` has protected `mCallbacks` field which is leaking in the API docs, we should @Hide it.
## Testing
Test: Ran unit tests locally
## Issues Fixed
Fixes: 76109329
This is an imported pull request from
Resolves #61
Github-Pr-Head-Sha: 6440daa3a63752c7f9d5ba2a390248cd85bc634f
GitOrigin-RevId: fe92d8466a59b44b218b6ca3cbd57dcda17992f7
Change-Id: Id599cdf5b02b32bdae0166266fb7da967598fe92
A room/runtime/api/current.ignore
M room/runtime/api/current.txt
M room/runtime/api/public_plus_experimental_current.txt
M room/runtime/api/restricted_current.txt
M room/runtime/src/main/java/androidx/room/RoomDatabase.java
Description
Version used: 1.0.0-beta1
Kotlin 1.1.51
Gradle 3.0.0-beta6
Devices/Android versions reproduced on: Nexus 5 - Android Marshmallow (6.0.1)
The model (data) class:
@Entity(tableName = "class")
data class Class(
@PrimaryKey
var id: Long = 0,
var class_name: String = "")
Room fails in this case due to multiple constructors and suggests to use @Ignore. I'm not sure it's not picking the default constructor.
There are few workarounds for this problem:
1. Use @Ignore as suggested by Room.
2. Somehow it picks the appropriate constructor in this case:
@Entity(tableName = "class")
data class Class(
@PrimaryKey
var id: Long,
var class_name: String = "")
3. Switch to deprecated kapt.generateStubs = true. Instead of using apply plugin: 'kotlin-kapt'.
I wish Room could pick up automatically the default no-arg constructor and in case it doesn't then show error and then developer can either use @Ignore or the new annotation to select default constructor.