Fixed
Status Update
Comments
yb...@google.com <yb...@google.com> #2
Status is still Assigned, but Compose 1.1.0 was already released. Did the ETA change for this feature?
jo...@gmail.com <jo...@gmail.com> #3
The Compose Animation APIs Navigation needs (such as AnimatedContent
) are still @Experimental
in Compose 1.1.0.
jo...@gmail.com <jo...@gmail.com> #4
Update: Same case for Compose 1.2.0
cr...@gmail.com <cr...@gmail.com> #5
why is this taking so long?
yb...@google.com <yb...@google.com> #6
seriously no update on what is stable?
ya...@google.com <ya...@google.com>
gr...@gmail.com <gr...@gmail.com> #7
AnimatedContent
is, as of today, still experimental and still cannot be used in androidx.navigation
.
As soon as it is stable, we can kick off this work.
yb...@google.com <yb...@google.com> #8
Project: platform/frameworks/support
Branch: androidx-main
commit a3386225c952c42b7c687771ea31642d76f4df66
Author: Clara Fok <clarafok@google.com>
Date: Wed May 10 11:26:59 2023
Add Preview support in animated NavHost
Test: ./gradlew navigation:navigation-compose:cC
Bug: 197140101
Change-Id: I7b017913d96e31785f16eb66534321d05f29b53d
M navigation/navigation-compose/src/main/java/androidx/navigation/compose/NavHost.kt
https://android-review.googlesource.com/2584844
Branch: androidx-main
commit a3386225c952c42b7c687771ea31642d76f4df66
Author: Clara Fok <clarafok@google.com>
Date: Wed May 10 11:26:59 2023
Add Preview support in animated NavHost
Test: ./gradlew navigation:navigation-compose:cC
Bug: 197140101
Change-Id: I7b017913d96e31785f16eb66534321d05f29b53d
M navigation/navigation-compose/src/main/java/androidx/navigation/compose/NavHost.kt
gr...@gmail.com <gr...@gmail.com> #9
Project: platform/frameworks/support
Branch: androidx-main
commit 256f919c6b8d579bc55e19d829aed438422f463b
Author: Clara Fok <clarafok@google.com>
Date: Wed May 10 10:48:32 2023
Migrate accompanist NavHost and NavController into androidx
Test: ./gradlew navigation:navigation-compose:cC
Bug: 197140101
Relnote: "NavHost and NavController now supports navigating in compose with Animations."
Change-Id: Ica95e794ef1794df4d1bdb38719b55624f832868
M navigation/navigation-compose/api/current.txt
M navigation/navigation-compose/api/public_plus_experimental_current.txt
M navigation/navigation-compose/api/restricted_current.txt
M navigation/navigation-compose/src/androidTest/java/androidx/navigation/compose/NavHostControllerTest.kt
M navigation/navigation-compose/src/androidTest/java/androidx/navigation/compose/NavHostTest.kt
M navigation/navigation-compose/src/main/java/androidx/navigation/compose/ComposeNavigator.kt
M navigation/navigation-compose/src/main/java/androidx/navigation/compose/NavGraphBuilder.kt
M navigation/navigation-compose/src/main/java/androidx/navigation/compose/NavHost.kt
https://android-review.googlesource.com/2584843
Branch: androidx-main
commit 256f919c6b8d579bc55e19d829aed438422f463b
Author: Clara Fok <clarafok@google.com>
Date: Wed May 10 10:48:32 2023
Migrate accompanist NavHost and NavController into androidx
Test: ./gradlew navigation:navigation-compose:cC
Bug: 197140101
Relnote: "NavHost and NavController now supports navigating in compose with Animations."
Change-Id: Ica95e794ef1794df4d1bdb38719b55624f832868
M navigation/navigation-compose/api/current.txt
M navigation/navigation-compose/api/public_plus_experimental_current.txt
M navigation/navigation-compose/api/restricted_current.txt
M navigation/navigation-compose/src/androidTest/java/androidx/navigation/compose/NavHostControllerTest.kt
M navigation/navigation-compose/src/androidTest/java/androidx/navigation/compose/NavHostTest.kt
M navigation/navigation-compose/src/main/java/androidx/navigation/compose/ComposeNavigator.kt
M navigation/navigation-compose/src/main/java/androidx/navigation/compose/NavGraphBuilder.kt
M navigation/navigation-compose/src/main/java/androidx/navigation/compose/NavHost.kt
yb...@google.com <yb...@google.com> #10
Project: platform/frameworks/support
Branch: androidx-main
commit 682bae8ada2b2b29376003d55455230ff7320a69
Author: Clara Fok <clarafok@google.com>
Date: Tue May 09 15:13:14 2023
Migrate accompanist NavGraphBuilder into androidx
Test: ./gradlew navigation:navigation-compose:cC
Bug: 197140101
Relnote: "NavGraphBuilder now supports building composables and NavGraphs with transition animations."
Change-Id: I5ca9e22c8c3b02acaf80ddaa35b58ba7426c993a
M navigation/navigation-compose/src/main/java/androidx/navigation/compose/NavGraphBuilder.kt
https://android-review.googlesource.com/2584842
Branch: androidx-main
commit 682bae8ada2b2b29376003d55455230ff7320a69
Author: Clara Fok <clarafok@google.com>
Date: Tue May 09 15:13:14 2023
Migrate accompanist NavGraphBuilder into androidx
Test: ./gradlew navigation:navigation-compose:cC
Bug: 197140101
Relnote: "NavGraphBuilder now supports building composables and NavGraphs with transition animations."
Change-Id: I5ca9e22c8c3b02acaf80ddaa35b58ba7426c993a
M navigation/navigation-compose/src/main/java/androidx/navigation/compose/NavGraphBuilder.kt
xm...@gmail.com <xm...@gmail.com> #11
Project: platform/frameworks/support
Branch: androidx-main
commit 895c4bb35ee11fe1c54f538699a845ddfaf7e2eb
Author: Clara Fok <clarafok@google.com>
Date: Tue May 09 13:14:10 2023
Migrate accompanist ComposeNavigator into androidx
Test: ./gradlew navigation:navigation-compose:cC
Bug: 197140101
Relnote: "ComposeNavigator now supports Destinations with Animations."
Change-Id: Ie33b4c2da53ff6c89494332a06be8123be67e879
M navigation/navigation-compose/src/main/java/androidx/navigation/compose/ComposeNavigator.kt
https://android-review.googlesource.com/2584841
Branch: androidx-main
commit 895c4bb35ee11fe1c54f538699a845ddfaf7e2eb
Author: Clara Fok <clarafok@google.com>
Date: Tue May 09 13:14:10 2023
Migrate accompanist ComposeNavigator into androidx
Test: ./gradlew navigation:navigation-compose:cC
Bug: 197140101
Relnote: "ComposeNavigator now supports Destinations with Animations."
Change-Id: Ie33b4c2da53ff6c89494332a06be8123be67e879
M navigation/navigation-compose/src/main/java/androidx/navigation/compose/ComposeNavigator.kt
Description
Version used: 1.0.0-beta2
Devices/Android versions reproduced on: Nexus 5 / Android 6.0.1
- Sample project to trigger the issue.
- A screenrecord or screenshots showing the issue (if UI related).
It would be nice to support concurrent database access via WAL and connection pooling, but it seems not possible in the current version.
Connection pool can be enabled by calling SQLiteDatabase.enableWriteAheadLogging() or passing ENABLE_WRITE_AHEAD_LOGGING flag to open database in framework API. However when I tried to enable WAL for Room databases in the following codes, it failed with "java.lang.IllegalStateException: Write Ahead Logging (WAL) mode cannot be enabled or disabled while there are transactions in progress."
------------------
mAppDB = Room.databaseBuilder(this, AppDatabase.class, "app-db")
.addCallback(new RoomDatabase.Callback() {
public void onCreate(@NonNull SupportSQLiteDatabase db) {
super.onCreate(db);
db.enableWriteAheadLogging();
}
public void onOpen(@NonNull SupportSQLiteDatabase db) {
super.onOpen(db);
db.enableWriteAheadLogging();
}
})
.build();
------------------
I hacked into FrameworkSQLiteOpenHelper and called FrameworkSQLiteOpenHelper.setWriteAheadLoggingEnabled(true) to enable WAL just after creating the OpenHelper. WAL and connection pool can be successfully enabled this way, but further access to the database will cause "SQLiteException: no such table: room_table_modification_log".
This is because InvalidationTracker create a temporary table called room_table_modification_log to track modifications to tables and trigger observer events, which can only be accessed in the main DB connection.
Is there a way to deal with Observers without using temporary tables? If it's not possible, how can I disable observer notifies and InvalidationTracker?