Fixed
Status Update
No update yet.
Comments
yb...@google.com
since these are in public API (:/) we need to do this in 1.2
cc...@google.com
since it is already marked as deprecated, we can probably do it by now.
cc...@google.com
Opening diff shortly
cc...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit d576cbdc911cba16638a44fd8223391a90a07ef7
Author: Mike Nakhimovich <digitalbuddha@users.noreply.github.com>
Date: Tue Aug 11 09:30:34 2020
[GH] Hide deprecated internal API.
## Proposed Changes
* `RoomDatabase.java` has protected `mCallbacks` field which is leaking in the API docs, we should @Hide it.
## Testing
Test: Ran unit tests locally
## Issues Fixed
Fixes: 76109329
This is an imported pull request fromhttps://github.com/androidx/androidx/pull/61 .
Resolves #61
Github-Pr-Head-Sha: 6440daa3a63752c7f9d5ba2a390248cd85bc634f
GitOrigin-RevId: fe92d8466a59b44b218b6ca3cbd57dcda17992f7
Change-Id: Id599cdf5b02b32bdae0166266fb7da967598fe92
A room/runtime/api/current.ignore
M room/runtime/api/current.txt
M room/runtime/api/public_plus_experimental_current.txt
M room/runtime/api/restricted_current.txt
M room/runtime/src/main/java/androidx/room/RoomDatabase.java
https://android-review.googlesource.com/1396827
Branch: androidx-master-dev
commit d576cbdc911cba16638a44fd8223391a90a07ef7
Author: Mike Nakhimovich <digitalbuddha@users.noreply.github.com>
Date: Tue Aug 11 09:30:34 2020
[GH] Hide deprecated internal API.
## Proposed Changes
* `RoomDatabase.java` has protected `mCallbacks` field which is leaking in the API docs, we should @Hide it.
## Testing
Test: Ran unit tests locally
## Issues Fixed
Fixes: 76109329
This is an imported pull request from
Resolves #61
Github-Pr-Head-Sha: 6440daa3a63752c7f9d5ba2a390248cd85bc634f
GitOrigin-RevId: fe92d8466a59b44b218b6ca3cbd57dcda17992f7
Change-Id: Id599cdf5b02b32bdae0166266fb7da967598fe92
A room/runtime/api/current.ignore
M room/runtime/api/current.txt
M room/runtime/api/public_plus_experimental_current.txt
M room/runtime/api/restricted_current.txt
M room/runtime/src/main/java/androidx/room/RoomDatabase.java
Description
Version used: Arch 1.0.0, Paging alpha-4
Devices/Android versions reproduced on:
Loading from local db with Room and displaying in a recyclerview. Paging alpha-4 keeps crashing while this doesn't happen with paging alpha-3.
java.lang.IllegalArgumentException: Initial result cannot be empty if items are present in data set.
at android.arch.paging.DataSource$BaseLoadCallback.validateInitialLoadParams(DataSource.java:154)
at android.arch.paging.PositionalDataSource$LoadInitialCallback.onResult(PositionalDataSource.java:170)
at android.arch.paging.TiledDataSource.loadInitial(TiledDataSource.java:64)
at android.arch.paging.PositionalDataSource.dispatchLoadInitial(PositionalDataSource.java:261)
at android.arch.paging.TiledPagedList.<init>(TiledPagedList.java:95)
at android.arch.paging.PagedList.create(PagedList.java:181)
at android.arch.paging.PagedList.access$000(PagedList.java:97)
at android.arch.paging.PagedList$Builder.build(PagedList.java:339)
at android.arch.paging.LivePagedListBuilder$1.compute(LivePagedListBuilder.java:205)
at android.arch.paging.LivePagedListBuilder$1.compute(LivePagedListBuilder.java:170)
at android.arch.lifecycle.ComputableLiveData$2.run(ComputableLiveData.java:87)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1133)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:607)
at java.lang.Thread.run(Thread.java:761)