Fixed
Status Update
No update yet.
Comments
al...@gmail.com
we've considered this, just didn't have time to implement.
Btw, we cannot just use name() because it might be proguarded away. so we need to generate the code that matches enums to hardcoded string values.
If you are using name(), be careful about migrations since 2 different compilations might have different names for the enum values.
Btw, we cannot just use name() because it might be proguarded away. so we need to generate the code that matches enums to hardcoded string values.
If you are using name(), be careful about migrations since 2 different compilations might have different names for the enum values.
am...@google.com
am...@google.com
True. Even though this could be fixed by using proguard rules.
Would be great to see this in the future, it's really lots of code here ;)
Would be great to see this in the future, it's really lots of code here ;)
il...@google.com
il...@google.com
ap...@google.com
What about the idea of using a more generic adapter which can handle all of the enums in your app? That way you could decide to persist them all with one "stone". You could choose to save them as strings, ordinals or even some other way of your choosing. But you would not have to add an adapter for every enum type in your app. You just have to add the one special enum adapter and Room would know how to use it for all enums.
ap...@google.com
This seems like a possible candidate for external contributions so moving it to the bug bounty hotlist.
We still need a proper design here hence not super straightforward.
Such design should ensure we are:
- safe for proguard (in case we go w/ name)
- have some logic for defaults (in case an enum is removed or renamed)
- possibly support ordinals (though that might be a case where we can require a type converter)
- possibly make it opt-in so that developer explicitly picks an option (e.g. some annotation on the enum to enable this)
jb...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit ae093dec7bfdc578cf0d7cd2ee6c8563ddd4f5ed
Author: Elif Bilgin <elifbilgin@google.com>
Date: Wed Oct 21 11:50:07 2020
Optimization for storing enums in databases.
Creating a default type adapter to persist Enums in Room. Changes made in logic of the findQueryParameterAdapter(...) function where we now try to find a TypeConverter for the collection of an object first, and if not, then try to find one for the type arg.
Test: Baseline tests replicate compiler errors in EnumColumnTypeAdapterTest.java
Bug: 73132006
Change-Id: Ia212097c16fde4302bc7c20cbad1604a996090ad
M room/compiler-processing/src/main/java/androidx/room/compiler/processing/XType.kt
M room/compiler-processing/src/main/java/androidx/room/compiler/processing/javac/JavacType.kt
M room/compiler-processing/src/main/java/androidx/room/compiler/processing/ksp/KspArrayType.kt
M room/compiler-processing/src/main/java/androidx/room/compiler/processing/ksp/KspDeclaredType.kt
M room/compiler-processing/src/main/java/androidx/room/compiler/processing/ksp/KspType.kt
M room/compiler-processing/src/main/java/androidx/room/compiler/processing/ksp/KspTypeArgumentType.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
A room/compiler/src/main/kotlin/androidx/room/solver/types/EnumColumnTypeAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/DaoProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/solver/TypeAdapterStoreTest.kt
A room/integration-tests/testapp/src/androidTest/java/androidx/room/integration/testapp/test/EnumColumnTypeAdapterTest.java
https://android-review.googlesource.com/1469447
Branch: androidx-master-dev
commit ae093dec7bfdc578cf0d7cd2ee6c8563ddd4f5ed
Author: Elif Bilgin <elifbilgin@google.com>
Date: Wed Oct 21 11:50:07 2020
Optimization for storing enums in databases.
Creating a default type adapter to persist Enums in Room. Changes made in logic of the findQueryParameterAdapter(...) function where we now try to find a TypeConverter for the collection of an object first, and if not, then try to find one for the type arg.
Test: Baseline tests replicate compiler errors in EnumColumnTypeAdapterTest.java
Bug: 73132006
Change-Id: Ia212097c16fde4302bc7c20cbad1604a996090ad
M room/compiler-processing/src/main/java/androidx/room/compiler/processing/XType.kt
M room/compiler-processing/src/main/java/androidx/room/compiler/processing/javac/JavacType.kt
M room/compiler-processing/src/main/java/androidx/room/compiler/processing/ksp/KspArrayType.kt
M room/compiler-processing/src/main/java/androidx/room/compiler/processing/ksp/KspDeclaredType.kt
M room/compiler-processing/src/main/java/androidx/room/compiler/processing/ksp/KspType.kt
M room/compiler-processing/src/main/java/androidx/room/compiler/processing/ksp/KspTypeArgumentType.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
A room/compiler/src/main/kotlin/androidx/room/solver/types/EnumColumnTypeAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/DaoProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/solver/TypeAdapterStoreTest.kt
A room/integration-tests/testapp/src/androidTest/java/androidx/room/integration/testapp/test/EnumColumnTypeAdapterTest.java
an...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit ed8d4acdb13cba24fcb1a392b36952ddfe790776
Author: Elif Bilgin <elifbilgin@google.com>
Date: Wed Oct 21 11:50:07 2020
Optimization for storing enums in databases.
Creating a default type adapter to persist Enums in Room. Changes made in logic of the findQueryParameterAdapter(...) function where we now try to find a TypeConverter for the collection of an object first, and if not, then try to find one for the type arg.
Test: Baseline tests replicate compiler errors in EnumColumnTypeAdapterTest.java
Bug: 73132006
Change-Id: I4cfa8c7f9ac3dc97ec4591ceef6f97b4cba7a6ad
M room/compiler-processing/src/main/java/androidx/room/compiler/processing/XType.kt
M room/compiler-processing/src/main/java/androidx/room/compiler/processing/javac/JavacType.kt
M room/compiler-processing/src/main/java/androidx/room/compiler/processing/ksp/KspType.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
A room/compiler/src/main/kotlin/androidx/room/solver/types/EnumColumnTypeAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/DaoProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/solver/TypeAdapterStoreTest.kt
A room/integration-tests/testapp/src/androidTest/java/androidx/room/integration/testapp/test/EnumColumnTypeAdapterTest.java
https://android-review.googlesource.com/1500819
Branch: androidx-master-dev
commit ed8d4acdb13cba24fcb1a392b36952ddfe790776
Author: Elif Bilgin <elifbilgin@google.com>
Date: Wed Oct 21 11:50:07 2020
Optimization for storing enums in databases.
Creating a default type adapter to persist Enums in Room. Changes made in logic of the findQueryParameterAdapter(...) function where we now try to find a TypeConverter for the collection of an object first, and if not, then try to find one for the type arg.
Test: Baseline tests replicate compiler errors in EnumColumnTypeAdapterTest.java
Bug: 73132006
Change-Id: I4cfa8c7f9ac3dc97ec4591ceef6f97b4cba7a6ad
M room/compiler-processing/src/main/java/androidx/room/compiler/processing/XType.kt
M room/compiler-processing/src/main/java/androidx/room/compiler/processing/javac/JavacType.kt
M room/compiler-processing/src/main/java/androidx/room/compiler/processing/ksp/KspType.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
A room/compiler/src/main/kotlin/androidx/room/solver/types/EnumColumnTypeAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/DaoProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/solver/TypeAdapterStoreTest.kt
A room/integration-tests/testapp/src/androidTest/java/androidx/room/integration/testapp/test/EnumColumnTypeAdapterTest.java
il...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 4eb2d133f3084759df737bc78b07a4ec8594d089
Author: Elif Bilgin <elifbilgin@google.com>
Date: Thu Nov 12 10:09:28 2020
Adding functionality to handle proguard when storing enums in databases.
Test: Baseline tests replicate compiler errors in EnumColumnTypeAdapterTest.java
Bug: 73132006
Change-Id: Ifa0a0bc496d63467a6b54c2c4d264c97a4bde0cd
M room/compiler/src/main/kotlin/androidx/room/ext/javapoet_ext.kt
M room/compiler/src/main/kotlin/androidx/room/solver/types/EnumColumnTypeAdapter.kt
M room/integration-tests/testapp/src/androidTest/java/androidx/room/integration/testapp/test/EnumColumnTypeAdapterTest.java
https://android-review.googlesource.com/1497443
Branch: androidx-master-dev
commit 4eb2d133f3084759df737bc78b07a4ec8594d089
Author: Elif Bilgin <elifbilgin@google.com>
Date: Thu Nov 12 10:09:28 2020
Adding functionality to handle proguard when storing enums in databases.
Test: Baseline tests replicate compiler errors in EnumColumnTypeAdapterTest.java
Bug: 73132006
Change-Id: Ifa0a0bc496d63467a6b54c2c4d264c97a4bde0cd
M room/compiler/src/main/kotlin/androidx/room/ext/javapoet_ext.kt
M room/compiler/src/main/kotlin/androidx/room/solver/types/EnumColumnTypeAdapter.kt
M room/integration-tests/testapp/src/androidTest/java/androidx/room/integration/testapp/test/EnumColumnTypeAdapterTest.java
jb...@google.com
Is there a way we can disable this default TypeConverter altogether? Our room DB is quite big and with Room 2.3, we noticed that sometimes we forgot to add our custom Enum converters to @TypeConverters in Room and the default one got picked up which causes unexpected crash. And with the Room default Enum TypeConverter, we are unable to detect such mistake (forgetting to add our custom Enum converters to @TypeConverters ) at compile time.
It would be nice if we can configure our Room DB which just disables Room build-in type converter
It would be nice if we can configure our Room DB which just disables Room build-in type converter
ap...@google.com
Hmm I'm not super keen on adding a flag to disable it but on the other hand, i understand this new feature may not be great for migration or teams that do want more strict controls.
I think there is not much risk if we add a new flag that is ON by default.
Will discuss w/ the team. Meanwhile, would you be interested in contributing it?
an...@google.com
Actually, it wold also be great to know where the automatic one failed for us to better understand the issue.
jb...@google.com
Thanks for your reply! Well the automatic one will throw an exception for unrecognized enum values. For example
enum class Sample {
A_DEFAULT, B
}
If we use Room default type converters, it works great until someday we added new field like
enum class Sample {
A_DEFAULT, B, C
}
and now server returns new enum value of C. We want our app to treat unrecognized values as default value (That's how our own custom enum Type Converter are implemented) but Room default type converters will throw exception in such case and crashing our old clients.
Of course we can always specify our custom Type Converter to @TypeConverters list in room db definition. But our code base is huge so sometimes one random developer forgot to add that and the app still compiles and runs until someday we realized that our DB is not using our custom TypeConverter.
We want to disable default type converters so can our app get compile time error if anyone forgot to add the custom Type Converter to room db definition. Thanks!
enum class Sample {
A_DEFAULT, B
}
If we use Room default type converters, it works great until someday we added new field like
enum class Sample {
A_DEFAULT, B, C
}
and now server returns new enum value of C. We want our app to treat unrecognized values as default value (That's how our own custom enum Type Converter are implemented) but Room default type converters will throw exception in such case and crashing our old clients.
Of course we can always specify our custom Type Converter to @TypeConverters list in room db definition. But our code base is huge so sometimes one random developer forgot to add that and the app still compiles and runs until someday we realized that our DB is not using our custom TypeConverter.
We want to disable default type converters so can our app get compile time error if anyone forgot to add the custom Type Converter to room db definition. Thanks!
an...@google.com
Makes sense.
We thought about this during design there wasn't a clear way to solve this. e.g. we could require some "defaultValue" annotation on enums for automatic conversion to work but that also break if developer does not own it.
Maybe we'll iterate on this (open to suggestion). Meanwhile, I'll prototype something to disable this with a flag.
Description
Version used: 27.0.2
Theme used: Theme.AppCompat.Light.DarkActionBar
Devices/Android versions reproduced on: Nexus 5X 8.1
If I set `setReorderingAllowed(true)` when doing fragment `hide()` and if there is a Visibility changing transition (`Fade` in my case) used as an exit on a fragment it internally sets all the views to `INVISIBLE` after the transition is over in `FragmentTransition.replaceHide`. But if you then press hardware back button, it attemts to build a list of views to fade back in, but that list is always empty because `FragmentTransitionImpl.captureTransitioningViews` always checks if they are `VISIBLE`. And I return back to a fragment with a bunch of INVISIBLE views.
- Relevant code to trigger the issue.
- A screenrecord or screenshots showing the issue (if UI related).
- Steps to reproduce
Install demo app
click switch app
press back button to return to the first fragment
behold second fragment fade out instead of sliding down while underlying fragment becomes visible, but it's contents are INVISIBLE