ListAdapterConfig.Builder should be final. [70848565]

Verified

Bug

Status Update

No update yet.

Description

sm...@gmail.com

created issue #1

Dec 19, 2017 07:40PM

Component used: Paging library version 1.0.0-alpha4-1

Builders are not meant to be extended. Leaving the class open to extension adds ambiguity to the API.

Consider making this public class final.

Comments

yb...@google.com <yb...@google.com> #2Dec 21, 2017 05:19PM

This should be fixed in 10591065.

cc...@google.com <cc...@google.com> #3Mar 14, 2018 10:30PM

Assigned to cc...@google.com.

This bug has been verified as fixed. The 'Microphone' setting are saved. Emulator version : 33.1.17-10594030

cc...@google.com <cc...@google.com> #4Mar 15, 2018 05:46PM

Marked as fixed.

I see that your png is making reference to API-34 emulator. Does this means that your team will not fix the problem on API-31. Do not think this is an acceptable solution if so. You must extend the fix to all API's emulators.

Please note that "Pixel 6 Pro API 33" emulator the mic is not working even with mic being enabled.

cc...@google.com <cc...@google.com> #5Mar 21, 2018 09:22PM

Verified by cc...@google.com.

I think this should work on all API levels, you can try the emulator build I referenced in #comment2.

Issue 70848565

Description

Issue summary

Comments

yb...@google.com <yb...@google.com> #2Dec 21, 2017 05:19PM

cc...@google.com <cc...@google.com> #3Mar 14, 2018 10:30PM

cc...@google.com <cc...@google.com> #4Mar 15, 2018 05:46PM

cc...@google.com <cc...@google.com> #5Mar 21, 2018 09:22PM

Add comment

Issue metadata