Fixed
Status Update
No update yet.
Comments
yb...@google.com
yb...@google.com
since these are in public API (:/) we need to do this in 1.2
yb...@google.com
sa...@gmail.com
since it is already marked as deprecated, we can probably do it by now.
[Deleted User] <[Deleted User]>
Opening diff shortly
60...@gmail.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit d576cbdc911cba16638a44fd8223391a90a07ef7
Author: Mike Nakhimovich <digitalbuddha@users.noreply.github.com>
Date: Tue Aug 11 09:30:34 2020
[GH] Hide deprecated internal API.
## Proposed Changes
* `RoomDatabase.java` has protected `mCallbacks` field which is leaking in the API docs, we should @Hide it.
## Testing
Test: Ran unit tests locally
## Issues Fixed
Fixes: 76109329
This is an imported pull request fromhttps://github.com/androidx/androidx/pull/61 .
Resolves #61
Github-Pr-Head-Sha: 6440daa3a63752c7f9d5ba2a390248cd85bc634f
GitOrigin-RevId: fe92d8466a59b44b218b6ca3cbd57dcda17992f7
Change-Id: Id599cdf5b02b32bdae0166266fb7da967598fe92
A room/runtime/api/current.ignore
M room/runtime/api/current.txt
M room/runtime/api/public_plus_experimental_current.txt
M room/runtime/api/restricted_current.txt
M room/runtime/src/main/java/androidx/room/RoomDatabase.java
https://android-review.googlesource.com/1396827
Branch: androidx-master-dev
commit d576cbdc911cba16638a44fd8223391a90a07ef7
Author: Mike Nakhimovich <digitalbuddha@users.noreply.github.com>
Date: Tue Aug 11 09:30:34 2020
[GH] Hide deprecated internal API.
## Proposed Changes
* `RoomDatabase.java` has protected `mCallbacks` field which is leaking in the API docs, we should @Hide it.
## Testing
Test: Ran unit tests locally
## Issues Fixed
Fixes: 76109329
This is an imported pull request from
Resolves #61
Github-Pr-Head-Sha: 6440daa3a63752c7f9d5ba2a390248cd85bc634f
GitOrigin-RevId: fe92d8466a59b44b218b6ca3cbd57dcda17992f7
Change-Id: Id599cdf5b02b32bdae0166266fb7da967598fe92
A room/runtime/api/current.ignore
M room/runtime/api/current.txt
M room/runtime/api/public_plus_experimental_current.txt
M room/runtime/api/restricted_current.txt
M room/runtime/src/main/java/androidx/room/RoomDatabase.java
60...@gmail.com
I forgot to mention in the previous comment: this issue happens when using the "createFromAsset" functionality as described in [1]. I am trying to get the data from an existing sqlite database.
[1]https://medium.com/androiddevelopers/packing-the-room-pre-populate-your-database-with-this-one-method-333ae190e680
[1]
60...@gmail.com
My apologies for the misleading report. After debugging I found out that the reason was a typo in one of my columns plus the use of not nullable types in my Kotlin entity. This means that createFromAsset seems to work fine, but it necessary to make sure that the types, nullability and default values match.
Description
Version used: 1.0.0
Devices/Android versions reproduced on: any
When trying to upgrade an existing project with an existing database to use Room, a migration is needed if the types used are not one of the canonical Sqlite types. Sqlite, however, supports other types that have affinities to these existing types - for example, VARCHAR is has an affinity of TEXT, and DATE has an affinity of NUMERIC and so on. Please see here:
It would be awesome if a migration is not needed for existing database columns with these types and Room could just internally accept a VARCHAR as TEXT for example.