Status Update
Comments
yb...@google.com <yb...@google.com> #2
Project: platform/frameworks/support
Branch: androidx-main
commit c2365dcfeb9064814282304f30f3eb86be71fdc7
Author: Dan Nizri <dniz@google.com>
Date: Wed Dec 20 16:33:08 2023
Fix Popup back handling on Android T/13+ when android:enableOnBackInvokedCallback="true"
Bug: 313702338
Bug: 318537200
Test: tested with android:enableOnBackInvokedCallback="true"
Change-Id: I7c7cef686ed9fbfd2d144c90040b13528f1675ed
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/window/AndroidPopup.android.kt
https://android-review.googlesource.com/2886766
Branch: androidx-main
commit c2365dcfeb9064814282304f30f3eb86be71fdc7
Author: Dan Nizri <dniz@google.com>
Date: Wed Dec 20 16:33:08 2023
Fix Popup back handling on Android T/13+ when android:enableOnBackInvokedCallback="true"
Bug: 313702338
Bug: 318537200
Test: tested with android:enableOnBackInvokedCallback="true"
Change-Id: I7c7cef686ed9fbfd2d144c90040b13528f1675ed
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/window/AndroidPopup.android.kt
Description
Version used: 1.1.0-alpha1
Devices/Android versions reproduced on: Any
Using the following Entity
@Entity(tableName = "individual")
class Individual {
@PrimaryKey(autoGenerate = true)
var id: Long = 0
var firstName: String = ""
var lastName: String = ""
var available: Boolean? = null
}
The generated IndividualDao_Impl code... Note that there is no NULL check for "value.getAvailable()" and no "bindNull(4)"
@Override
public void bind(SupportSQLiteStatement stmt, Individual value) {
stmt.bindLong(1, value.getId());
if (value.getFirstName() == null) {
stmt.bindNull(2);
} else {
stmt.bindString(2, value.getFirstName());
}
if (value.getLastName() == null) {
stmt.bindNull(3);
} else {
stmt.bindString(3, value.getLastName());
}
final int _tmp;
_tmp = value.getAvailable() ? 1 : 0;
stmt.bindLong(4, _tmp);
stmt.bindLong(5, value.getId());
}
When running this app, the app will crash if the "available" field is NULL.
NOTE: This was NOT an issue with Room 1.0.0 (this is new to the 1.1.0-alpha1)