Verified
Status Update
Comments
yb...@google.com <yb...@google.com> #2
since these are in public API (:/) we need to do this in 1.2
fa...@gmail.com <fa...@gmail.com> #3
since it is already marked as deprecated, we can probably do it by now.
yb...@google.com <yb...@google.com> #4
Opening diff shortly
[Deleted User] <[Deleted User]> #5
Project: platform/frameworks/support
Branch: androidx-master-dev
commit d576cbdc911cba16638a44fd8223391a90a07ef7
Author: Mike Nakhimovich <digitalbuddha@users.noreply.github.com>
Date: Tue Aug 11 09:30:34 2020
[GH] Hide deprecated internal API.
## Proposed Changes
* `RoomDatabase.java` has protected `mCallbacks` field which is leaking in the API docs, we should @Hide it.
## Testing
Test: Ran unit tests locally
## Issues Fixed
Fixes: 76109329
This is an imported pull request fromhttps://github.com/androidx/androidx/pull/61 .
Resolves #61
Github-Pr-Head-Sha: 6440daa3a63752c7f9d5ba2a390248cd85bc634f
GitOrigin-RevId: fe92d8466a59b44b218b6ca3cbd57dcda17992f7
Change-Id: Id599cdf5b02b32bdae0166266fb7da967598fe92
A room/runtime/api/current.ignore
M room/runtime/api/current.txt
M room/runtime/api/public_plus_experimental_current.txt
M room/runtime/api/restricted_current.txt
M room/runtime/src/main/java/androidx/room/RoomDatabase.java
https://android-review.googlesource.com/1396827
Branch: androidx-master-dev
commit d576cbdc911cba16638a44fd8223391a90a07ef7
Author: Mike Nakhimovich <digitalbuddha@users.noreply.github.com>
Date: Tue Aug 11 09:30:34 2020
[GH] Hide deprecated internal API.
## Proposed Changes
* `RoomDatabase.java` has protected `mCallbacks` field which is leaking in the API docs, we should @Hide it.
## Testing
Test: Ran unit tests locally
## Issues Fixed
Fixes: 76109329
This is an imported pull request from
Resolves #61
Github-Pr-Head-Sha: 6440daa3a63752c7f9d5ba2a390248cd85bc634f
GitOrigin-RevId: fe92d8466a59b44b218b6ca3cbd57dcda17992f7
Change-Id: Id599cdf5b02b32bdae0166266fb7da967598fe92
A room/runtime/api/current.ignore
M room/runtime/api/current.txt
M room/runtime/api/public_plus_experimental_current.txt
M room/runtime/api/restricted_current.txt
M room/runtime/src/main/java/androidx/room/RoomDatabase.java
yb...@google.com <yb...@google.com> #6
so you are probably hitting b/67181813 which is already fixed and should go out in alpha2 (hopefully this week).
But in terms of why the error is not populating, i'm still baffled :/. The sample in b/67181813 properly reports the error (they are different cases but same error reporting on our end).
Is it possible for you to create a sample project that reproduces the error?
But in terms of why the error is not populating, i'm still baffled :/. The sample in
Is it possible for you to create a sample project that reproduces the error?
[Deleted User] <[Deleted User]> #7
Sure thing. I've created a super simple test project where the error output is the same.
Again, latest Android Studio latest stable release (3.0.1) on Mac OSX 10.13.3, embedded JDK.
Again, latest Android Studio latest stable release (3.0.1) on Mac OSX 10.13.3, embedded JDK.
[Deleted User] <[Deleted User]> #8
Not sure these two bugs are related (I've added a comment here, despite it being closed: https://issuetracker.google.com/issues/69562125 ), but in the same test project it's also very easy to reproduce another issue.
By just adding the `@IntRange` annotation to the `id` field in `TestEntity` (and uncommenting the getter), the compilation breaks again, this time kapt fails with this message: "Error:error: Entities and Pojos must have a usable public constructor. You can have an empty constructor or a constructor whose parameters match the fields (by name and type)."
Annotating parameters in the constructor used by Room breaks it.
By just adding the `@IntRange` annotation to the `id` field in `TestEntity` (and uncommenting the getter), the compilation breaks again, this time kapt fails with this message: "Error:error: Entities and Pojos must have a usable public constructor. You can have an empty constructor or a constructor whose parameters match the fields (by name and type)."
Annotating parameters in the constructor used by Room breaks it.
yb...@google.com <yb...@google.com> #9
thanks for the sample app! I'll debug and see why the error does not show properly.
about the other bug, it is actually a jdk bug :/
https://bugs.openjdk.java.net/browse/JDK-8007720
about the other bug, it is actually a jdk bug :/
yb...@google.com <yb...@google.com> #10
so the element about which we report the error seems fine.
I'll try to convert it to java and see if it will have the same problem.
I'll try to convert it to java and see if it will have the same problem.
yb...@google.com <yb...@google.com> #11
same in java. Looks like annotation processor cannot report an error on its dependency class :/. We need to figure out a way to either resolve it or at least discover that it is coming from a dependency and report manually.
[Deleted User] <[Deleted User]> #12
Any updates on this?
It's very, very difficult and time-consuming to debug Room errors in big projects.
It's very, very difficult and time-consuming to debug Room errors in big projects.
yb...@google.com <yb...@google.com> #13
sorry we don't have anything here yet :/. it will be post-IO :(.
yb...@google.com <yb...@google.com>
da...@google.com <da...@google.com>
da...@google.com <da...@google.com> #14
This fix will be available in 2.0.0 beta 2.
cc...@google.com <cc...@google.com> #15
Fix went in early enough to get into 2.0.0-beta01, so marking released
da...@google.com <da...@google.com> #17
The file links in #16 have restricted access. Are you still seeing the issue and are trying to show us through those screenshots?
Description
Version used: 1.1.0-alpha5
Devices/Android versions reproduced on: Compile-time error
Android Studio & tools: Studio 3.0.1, gradle-build 3.0.1
When getting an error from the Room annotation processor in a Java environment, the Gradle error doesn't include any mention on the class nor the field. I.e. "cannot find getter for field". This means that it's incredibly difficult to debug this kind of issues.
This is also happening when using --info, --debug or --stacktrace as the gradle task parameter.