Verified
Status Update
No update yet.
Comments
yb...@google.com
Project: platform/frameworks/support
Branch: androidx-main
Author: George Mount <
Link:
Fix focus move within child AndroidViews
Expand for full commit details
Fix focus move within child AndroidViews
Fixes: 389994198
Fixes: 391378895
Relnote: "Fixes focus travel within child AndroidViews where it
can sometimes jump out of the child to the ComposeView"
Sometimes the native FocusFinder doesn't act properly and finds
the wrong View when searching. This CL changes the FocusFinder to
use a newer copy of FocusFinder for all focus search operations
in AndroidComposeView.
Test: new test, manual testing
Change-Id: I678c864afe086879c5c45b018dd82da4f23be440
Files:
- M
compose/ui/ui/src/androidInstrumentedTest/AndroidManifest.xml - M
compose/ui/ui/src/androidInstrumentedTest/kotlin/androidx/compose/ui/focus/FocusListenerTest.kt - A
compose/ui/ui/src/androidInstrumentedTest/kotlin/androidx/compose/ui/test/TestActivity2.kt - A
compose/ui/ui/src/androidInstrumentedTest/kotlin/androidx/compose/ui/viewinterop/MixedFocusChangeTest.kt - M
compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/platform/AndroidComposeView.android.kt - M
compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/platform/FocusFinderCompat.android.kt
Hash: b028bcc322095634123da91c7146bac9e23c13c7
Date: Tue Jan 14 13:48:11 2025
fa...@gmail.com
Project: platform/frameworks/support
Branch: androidx-main
Author: Ralston Da Silva <
Link:
Disabling isViewFocusFixEnabled and isRemoveFocusedViewFixEnabled
Expand for full commit details
Disabling isViewFocusFixEnabled and isRemoveFocusedViewFixEnabled
Disabling these flag to unblock 1.8 RC.
These were features/bug-fixes that were not regressions
from 1.7
Bug: 406327273
Bug: 369256395
Bug: 378570682
Bug: 376142752
Bug: 384056227
Bug: 388590015
Bug: 389994198
Bug: 391378895
Test: Ran presubmits and added TODOs to the affected tests
Change-Id: I5ffb7ff27c662838c8b464560d1df830751f015c
Files:
- M
compose/ui/ui/src/androidInstrumentedTest/kotlin/androidx/compose/ui/focus/FocusViewInteropTest.kt - M
compose/ui/ui/src/androidInstrumentedTest/kotlin/androidx/compose/ui/focus/OwnerFocusTest.kt - M
compose/ui/ui/src/androidInstrumentedTest/kotlin/androidx/compose/ui/focus/RequestFocusTest.kt - M
compose/ui/ui/src/androidInstrumentedTest/kotlin/androidx/compose/ui/viewinterop/MixedFocusChangeTest.kt - M
compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/ComposeUiFlags.kt
Hash: 1a33d21734ef7f68d4cad37c8d333831f304a339
Date: Tue Apr 01 17:46:50 2025
yb...@google.com
that is so weird, we always report that error w/ a reference to the field:
context.checker.check(success, field.element, CANNOT_FIND_GETTER_FOR_FIELD)
can you share your build.gradle file? Which version of kotlin are you using?
Also, make sure you have kotlin-kapt plugin applied.
Also, I realized that you've put version 1.1.0-alpha5 which does not exist. Did you mean 1.1.0-alpha1 or 1.0.0-alpha5 ?
context.checker.check(success, field.element, CANNOT_FIND_GETTER_FOR_FIELD)
can you share your build.gradle file? Which version of kotlin are you using?
Also, make sure you have kotlin-kapt plugin applied.
Also, I realized that you've put version 1.1.0-alpha5 which does not exist. Did you mean 1.1.0-alpha1 or 1.0.0-alpha5 ?
[Deleted User] <[Deleted User]>
Apologies, I meant to write 1.1.0-alpha1.
Worth mentioning that the @Database class and the @Entity are in two different library modules, one directly depending on the other.
Both modules are using Kotlin version 1.2.21, kotlin-apt and `kapt "android.arch.persistence.room:compiler:1.1.0-alpha1"`
and `implementation "org.jetbrains.kotlin:kotlin-stdlib-jdk7:1.2.21"`.
Worth mentioning that the @Database class and the @Entity are in two different library modules, one directly depending on the other.
Both modules are using Kotlin version 1.2.21, kotlin-apt and `kapt "android.arch.persistence.room:compiler:1.1.0-alpha1"`
and `implementation "org.jetbrains.kotlin:kotlin-stdlib-jdk7:1.2.21"`.
yb...@google.com
so you are probably hitting
But in terms of why the error is not populating, i'm still baffled :/. The sample in
Is it possible for you to create a sample project that reproduces the error?
But in terms of why the error is not populating, i'm still baffled :/. The sample in
Is it possible for you to create a sample project that reproduces the error?
[Deleted User] <[Deleted User]>
Sure thing. I've created a super simple test project where the error output is the same.
Again, latest Android Studio latest stable release (3.0.1) on Mac OSX 10.13.3, embedded JDK.
Again, latest Android Studio latest stable release (3.0.1) on Mac OSX 10.13.3, embedded JDK.
[Deleted User] <[Deleted User]>
Not sure these two bugs are related (I've added a comment here, despite it being closed: https://issuetracker.google.com/issues/69562125 ), but in the same test project it's also very easy to reproduce another issue.
By just adding the `@IntRange` annotation to the `id` field in `TestEntity` (and uncommenting the getter), the compilation breaks again, this time kapt fails with this message: "Error:error: Entities and Pojos must have a usable public constructor. You can have an empty constructor or a constructor whose parameters match the fields (by name and type)."
Annotating parameters in the constructor used by Room breaks it.
By just adding the `@IntRange` annotation to the `id` field in `TestEntity` (and uncommenting the getter), the compilation breaks again, this time kapt fails with this message: "Error:error: Entities and Pojos must have a usable public constructor. You can have an empty constructor or a constructor whose parameters match the fields (by name and type)."
Annotating parameters in the constructor used by Room breaks it.
yb...@google.com
thanks for the sample app! I'll debug and see why the error does not show properly.
about the other bug, it is actually a jdk bug :/
https://bugs.openjdk.java.net/browse/JDK-8007720
about the other bug, it is actually a jdk bug :/
yb...@google.com
so the element about which we report the error seems fine.
I'll try to convert it to java and see if it will have the same problem.
I'll try to convert it to java and see if it will have the same problem.
yb...@google.com
same in java. Looks like annotation processor cannot report an error on its dependency class :/. We need to figure out a way to either resolve it or at least discover that it is coming from a dependency and report manually.
[Deleted User] <[Deleted User]>
Any updates on this?
It's very, very difficult and time-consuming to debug Room errors in big projects.
It's very, very difficult and time-consuming to debug Room errors in big projects.
yb...@google.com
sorry we don't have anything here yet :/. it will be post-IO :(.
yb...@google.com
da...@google.com
da...@google.com
This fix will be available in 2.0.0 beta 2.
cc...@google.com
Fix went in early enough to get into 2.0.0-beta01, so marking released
da...@google.com
The file links in #16 have restricted access. Are you still seeing the issue and are trying to show us through those screenshots?
Description
Version used: 1.1.0-alpha5
Devices/Android versions reproduced on: Compile-time error
Android Studio & tools: Studio 3.0.1, gradle-build 3.0.1
When getting an error from the Room annotation processor in a Java environment, the Gradle error doesn't include any mention on the class nor the field. I.e. "cannot find getter for field". This means that it's incredibly difficult to debug this kind of issues.
This is also happening when using --info, --debug or --stacktrace as the gradle task parameter.