Locations sent to one emulator are sent to all of them [73450633]

Fixed

Bug

Status Update

No update yet.

Description

bo...@gmail.com

created issue #1

Feb 16, 2018 05:51PM

Android Studio Version:

Emulator Version (Emulator--> Extended Controls--> Emulator Version): 27.1.7-4581633

HAXM / KVM Version: HVF 10.13.0

Android SDK Tools: 26.1.1

Host Operating System: Mac OS X 10.13.3

CPU Manufacturer: Intel CPU
Virtualization is supported
64-bit CPU

Steps to Reproduce Bug:
- Open 2 emulators
- In one of them, send a location, using Extended controls / Location

Expected Behavior:
The location should be sent only to the emulator that was used.

Observed Behavior:
The location is sent to both emulators.

Because of this, tests involving two people interacting at two different locations are almost impossible to do.

Comments

lf...@google.com <lf...@google.com> Feb 17, 2018 12:13AM

Assigned to lf...@google.com.

lf...@google.com <lf...@google.com> #2Feb 18, 2018 03:48AM

cl up to fix:

https://android-review.googlesource.com/c/platform/external/qemu/+/620933

ap...@google.com <ap...@google.com> #3Feb 20, 2018 09:36PM

Project: platform/external/qemu
Branch: emu-master-dev

commit ea85adfc73d1ef1bc22b9cbbf554fa550ffde2c9
Author: Lingfeng Yang <lfy@google.com>
Date: Sat Feb 17 17:01:56 2018

[location] Make most location settings per-AVD

bug: 73471760
bug: 73450633

Unless there is no AVD, use a per-AVD setting for
lat/lon/alt and the playback settings.

Also update the qt setting if location was updated
from the console.

Change-Id: I0268e0e7ef25db0398844c38039e9298b3a2129b

M android/android-emu/android/console.cpp
M android/android-emu/android/emulation/control/location_agent.h
M android/android-emu/android/skin/qt/extended-pages/location-page.cpp
M android/android-emu/android/skin/qt/extended-pages/location-page.h
M android/android-emu/android/skin/qt/qt-settings.h

https://android-review.googlesource.com/620933

https://goto.google.com/android-sha1/ea85adfc73d1ef1bc22b9cbbf554fa550ffde2c9

ap...@google.com <ap...@google.com> #4Feb 20, 2018 09:41PM

Project: platform/external/qemu
Branch: emu-2.6-release

commit eff2175376a42c53cd032151b09439219e631fc2
Author: Lingfeng Yang <lfy@google.com>
Date: Sat Feb 17 17:01:56 2018

[location] Make most location settings per-AVD

bug: 73471760
bug: 73450633

Unless there is no AVD, use a per-AVD setting for
lat/lon/alt and the playback settings.

Also update the qt setting if location was updated
from the console.

Change-Id: I0268e0e7ef25db0398844c38039e9298b3a2129b
(cherry picked from commit ea85adfc73d1ef1bc22b9cbbf554fa550ffde2c9)

M android/android-emu/android/console.cpp
M android/android-emu/android/emulation/control/location_agent.h
M android/android-emu/android/skin/qt/extended-pages/location-page.cpp
M android/android-emu/android/skin/qt/extended-pages/location-page.h
M android/android-emu/android/skin/qt/qt-settings.h

https://android-review.googlesource.com/622406

https://goto.google.com/android-sha1/eff2175376a42c53cd032151b09439219e631fc2

pj...@google.com <pj...@google.com> Feb 21, 2018 06:25PM

Marked as fixed.

lf...@google.com <lf...@google.com> #5Feb 21, 2018 06:39PM

Note: This should be released in the next emulator canary.

lf...@google.com <lf...@google.com> #6Feb 24, 2018 06:14AM

Emulator 27.1.11 canary with the fix is live now.