Built-in shrinker Proguard rules parser [73493534]

Verified

Bug

Status Update

No update yet.

Description

ga...@google.com

created issue #1

Feb 15, 2018 08:24PM

Proguard 6.0 has been published, and there are new modifiers added e.g. "includedescriptorclasses". We should make sure our Proguard rules parser is able to handle those.

Comments

be...@google.com <be...@google.com> #2Feb 16, 2018 09:58AM

Hi,

I also see my text cut off when I set maxLines = 2. Is it the same issue?

  Box(
    modifier =
      Modifier.size(
        width = 108dp,
        height = 34dp,
      ),
    contentAlignment = Alignment.Center,
  ) {
    BasicText(
      text = "text text text",
      maxLines = 2,
      autoSize = AutoSize.StepBased(minFontSize = 1.sp, maxFontSize = 13.sp, stepSize = 0.2.sp),
    )
  }

ga...@google.com <ga...@google.com> #3Feb 16, 2018 05:50PM

Project: platform/frameworks/support
Branch: androidx-main
Author: Jossi Wolf <jossiwolf@google.com>
Link: https://android-review.googlesource.com/3450389

Fix TextAutoSize bug with maxLines = 1

Expand for full commit details

Fix TextAutoSize bug with maxLines = 1 
 
We were overcaching the paragraphIntrinsics in MultiParagraphLayoutCache when mutating the style. For `AutoSizeStepBased` instances with biased windows (more values smaller/bigger than the optimal), this could result in performing layout with outdated intrinsics, and thus an outdated style and font size, without surfacing this in the TextLayoutResult. 
 
Test: New MultiParagraphLayoutCacheTests and manual testing 
Relnote: Fixed a bug in BasicText with TextAutoSize and maxLines set to 1. 
Fixes: 376834366 
 
Change-Id: Ic0450c763c5d764492995b44ee1fe570246a9689

Files:

M compose/foundation/foundation/src/androidInstrumentedTest/kotlin/androidx/compose/foundation/text/modifiers/MultiParagraphLayoutCacheTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/modifiers/MultiParagraphLayoutCache.kt

Hash: e1b712d78cc60384ed67a56c006148291ba146a6
Date: Tue Jan 07 18:52:26 2025

be...@google.com <be...@google.com> #4Feb 16, 2018 06:29PM

#2, yeah, that's the same issue.

ga...@google.com <ga...@google.com> #5Feb 16, 2018 06:33PM

Assigned to ga...@google.com.

Thanks @jo...@google.com for fixing this! Do you know when the fix would be available for g3 apps?

ga...@google.com <ga...@google.com> #6Mar 21, 2018 10:49AM

Marked as fixed.

Moving the internal discussion offline. The bug is fixed and the fix available in snapshot builds. We will comment on this issue when the bug fix is included in a release.

qi...@gmail.com <qi...@gmail.com> #7Apr 18, 2018 03:23PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.compose.foundation:foundation:1.8.0-beta01
androidx.compose.foundation:foundation-android:1.8.0-beta01
androidx.compose.foundation:foundation-jvmstubs:1.8.0-beta01
androidx.compose.foundation:foundation-linuxx64stubs:1.8.0-beta01

je...@google.com <je...@google.com> #8Apr 18, 2018 03:31PM

Status: Assigned (reopened)

it should have been fixed in canary 9, I'll reopen so Ivan can have a look.

im...@google.com <im...@google.com> #9Apr 18, 2018 03:32PM

@7 The fix should be included in 3.2-alpha09 and newer, so it also should be fixed in 3.2-alpha11. Could you provide logs and your build files?

ga...@google.com <ga...@google.com> #10Apr 18, 2018 04:34PM

Can you please c/p the keep rules? I've tried 3.2.0-alpha11, and the keep rules were parsed correctly.

qi...@gmail.com <qi...@gmail.com> #11Apr 20, 2018 03:21PM

Hello, I've tried with Plaid app actually:

https://github.com/nickbutcher/plaid/blob/master/app/proguard-rules.pro

I had to comment these 2 lines to make the assembleRelease work with R8:

-----------------------------------------------------------------------------
# Required for classes created and used from JNI code (on C/C++ side)
-keep, includedescriptorclasses class in.uncod.android.bypass.Document { *; }
-keep, includedescriptorclasses class in.uncod.android.bypass.Element { *; }
-----------------------------------------------------------------------------

ga...@google.com <ga...@google.com> #12Apr 23, 2018 09:03AM

Verified by ga...@google.com.

Thanks for reporting the issue Qian. I've filled

https://issuetracker.google.com/78442725 to track this issue.

qi...@gmail.com <qi...@gmail.com> #13Apr 23, 2018 03:43PM

Oh! It's only the whitespace problem, thanks for the heads up :)