Fixed
Status Update
Comments
yb...@google.com <yb...@google.com> #2
Hi. Thanks for reporting this. Fixed in alpha-04
am...@gmail.com <am...@gmail.com> #3
Project: platform/frameworks/support
Branch: androidx-main
commit e782987543a9f8ccd485e970ddc74564b24378db
Author: Vighnesh Raut <vighnesh.raut13@gmail.com>
Date: Mon Jan 02 15:27:40 2023
fix: tab row crashes when only 1 tab is added
Bug: b/264018028
Test: Added unit test
Change-Id: I6381dbac304fc1d69d3708c6655f8b595668e93f
M tv/tv-material/src/androidTest/java/androidx/tv/material/TabRowTest.kt
M tv/tv-material/src/main/java/androidx/tv/material/TabRow.kt
https://android-review.googlesource.com/2373449
Branch: androidx-main
commit e782987543a9f8ccd485e970ddc74564b24378db
Author: Vighnesh Raut <vighnesh.raut13@gmail.com>
Date: Mon Jan 02 15:27:40 2023
fix: tab row crashes when only 1 tab is added
Bug:
Test: Added unit test
Change-Id: I6381dbac304fc1d69d3708c6655f8b595668e93f
M tv/tv-material/src/androidTest/java/androidx/tv/material/TabRowTest.kt
M tv/tv-material/src/main/java/androidx/tv/material/TabRow.kt
yb...@google.com <yb...@google.com> #4
deleted
am...@gmail.com <am...@gmail.com> #5
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.tv:tv-material:1.0.0-alpha04
yb...@google.com <yb...@google.com> #6
this is the problem in the code:
@RawQuery(observedEntities = [ MetadataXmp::class, FolderEntity::class, SubjectJunction::class ])
internal abstract fun internalGetRelationImages(query: SupportSQLiteQuery): LiveData<List<MetadataXmp>>
You are asking it to observe MetadataXmp but it is not an entity.
see the docs for details:
https://developer.android.com/reference/android/arch/persistence/room/RawQuery.html#observedEntities()
@RawQuery(observedEntities = [ MetadataXmp::class, FolderEntity::class, SubjectJunction::class ])
internal abstract fun internalGetRelationImages(query: SupportSQLiteQuery): LiveData<List<MetadataXmp>>
You are asking it to observe MetadataXmp but it is not an entity.
see the docs for details:
am...@gmail.com <am...@gmail.com> #7
Ugh, that's a face-palm typo. Knew it had to be something like that. Thanks for taking the time to look at it.
Any chance that error could trace to the query instead of simply pointing at the non-entity we expect to be a non-entity?
[Location] references [Class] which must be annotated with @Entity
Any chance that error could trace to the query instead of simply pointing at the non-entity we expect to be a non-entity?
[Location] references [Class] which must be annotated with @Entity
yb...@google.com <yb...@google.com> #8
you are right, the error does not tell you the real problem.
I'll re-open the docs to improve the messaging.
I'll re-open the docs to improve the messaging.
yb...@google.com <yb...@google.com> #9
ok, I actually changed it to read Pojo's as well so your code will work. We'll traverse the Pojo and consider any @Relation / @Embedded as a table to watch.
If the pojo has no table references, we'll print a proper error.
If the pojo has no table references, we'll print a proper error.
am...@gmail.com <am...@gmail.com> #10
Even better, thanks!
Description
Version used: 1.1.0-alpha2
Devices/Android versions reproduced on: compile error
Error:(8, 1) Gradle: error: Entity class must be annotated with @Entity
public class MetadataXmp2 {
I can't seem to implement @Relation. I simplified the entities I'm using to this:
@Entity(tableName = "meta")
public class MetadataEntity2 {
@PrimaryKey(autoGenerate = true)
public long id;
public float rating;
public String label;
}
public class MetadataXmp2 /* or extends MetadataEntity2 */ {
@Embedded
public MetadataEntity2 metadata;
@Relation(
parentColumn = "id",
entityColumn = "metaId",
projection = "subjectId",
entity = SubjectJunction.class)
public List<Long> subjectIds;
@Relation(
parentColumn = "id",
entityColumn = "id",
projection = "documentUri",
entity = FolderEntity.class)
public List<String> parentUris;
}
I have an extension of the original MetadataEntity that works fine without @Relation. Am I missing a limitation here?