Fixed
Status Update
Comments
yb...@google.com <yb...@google.com> #2
since these are in public API (:/) we need to do this in 1.2
am...@gmail.com <am...@gmail.com> #3
since it is already marked as deprecated, we can probably do it by now.
yb...@google.com <yb...@google.com> #4
Opening diff shortly
am...@gmail.com <am...@gmail.com> #5
Project: platform/frameworks/support
Branch: androidx-master-dev
commit d576cbdc911cba16638a44fd8223391a90a07ef7
Author: Mike Nakhimovich <digitalbuddha@users.noreply.github.com>
Date: Tue Aug 11 09:30:34 2020
[GH] Hide deprecated internal API.
## Proposed Changes
* `RoomDatabase.java` has protected `mCallbacks` field which is leaking in the API docs, we should @Hide it.
## Testing
Test: Ran unit tests locally
## Issues Fixed
Fixes: 76109329
This is an imported pull request fromhttps://github.com/androidx/androidx/pull/61 .
Resolves #61
Github-Pr-Head-Sha: 6440daa3a63752c7f9d5ba2a390248cd85bc634f
GitOrigin-RevId: fe92d8466a59b44b218b6ca3cbd57dcda17992f7
Change-Id: Id599cdf5b02b32bdae0166266fb7da967598fe92
A room/runtime/api/current.ignore
M room/runtime/api/current.txt
M room/runtime/api/public_plus_experimental_current.txt
M room/runtime/api/restricted_current.txt
M room/runtime/src/main/java/androidx/room/RoomDatabase.java
https://android-review.googlesource.com/1396827
Branch: androidx-master-dev
commit d576cbdc911cba16638a44fd8223391a90a07ef7
Author: Mike Nakhimovich <digitalbuddha@users.noreply.github.com>
Date: Tue Aug 11 09:30:34 2020
[GH] Hide deprecated internal API.
## Proposed Changes
* `RoomDatabase.java` has protected `mCallbacks` field which is leaking in the API docs, we should @Hide it.
## Testing
Test: Ran unit tests locally
## Issues Fixed
Fixes: 76109329
This is an imported pull request from
Resolves #61
Github-Pr-Head-Sha: 6440daa3a63752c7f9d5ba2a390248cd85bc634f
GitOrigin-RevId: fe92d8466a59b44b218b6ca3cbd57dcda17992f7
Change-Id: Id599cdf5b02b32bdae0166266fb7da967598fe92
A room/runtime/api/current.ignore
M room/runtime/api/current.txt
M room/runtime/api/public_plus_experimental_current.txt
M room/runtime/api/restricted_current.txt
M room/runtime/src/main/java/androidx/room/RoomDatabase.java
yb...@google.com <yb...@google.com> #6
this is the problem in the code:
@RawQuery(observedEntities = [ MetadataXmp::class, FolderEntity::class, SubjectJunction::class ])
internal abstract fun internalGetRelationImages(query: SupportSQLiteQuery): LiveData<List<MetadataXmp>>
You are asking it to observe MetadataXmp but it is not an entity.
see the docs for details:
https://developer.android.com/reference/android/arch/persistence/room/RawQuery.html#observedEntities()
@RawQuery(observedEntities = [ MetadataXmp::class, FolderEntity::class, SubjectJunction::class ])
internal abstract fun internalGetRelationImages(query: SupportSQLiteQuery): LiveData<List<MetadataXmp>>
You are asking it to observe MetadataXmp but it is not an entity.
see the docs for details:
am...@gmail.com <am...@gmail.com> #7
Ugh, that's a face-palm typo. Knew it had to be something like that. Thanks for taking the time to look at it.
Any chance that error could trace to the query instead of simply pointing at the non-entity we expect to be a non-entity?
[Location] references [Class] which must be annotated with @Entity
Any chance that error could trace to the query instead of simply pointing at the non-entity we expect to be a non-entity?
[Location] references [Class] which must be annotated with @Entity
yb...@google.com <yb...@google.com> #8
you are right, the error does not tell you the real problem.
I'll re-open the docs to improve the messaging.
I'll re-open the docs to improve the messaging.
yb...@google.com <yb...@google.com> #9
ok, I actually changed it to read Pojo's as well so your code will work. We'll traverse the Pojo and consider any @Relation / @Embedded as a table to watch.
If the pojo has no table references, we'll print a proper error.
If the pojo has no table references, we'll print a proper error.
am...@gmail.com <am...@gmail.com> #10
Even better, thanks!
Description
Version used: 1.1.0-alpha2
Devices/Android versions reproduced on: compile error
Error:(8, 1) Gradle: error: Entity class must be annotated with @Entity
public class MetadataXmp2 {
I can't seem to implement @Relation. I simplified the entities I'm using to this:
@Entity(tableName = "meta")
public class MetadataEntity2 {
@PrimaryKey(autoGenerate = true)
public long id;
public float rating;
public String label;
}
public class MetadataXmp2 /* or extends MetadataEntity2 */ {
@Embedded
public MetadataEntity2 metadata;
@Relation(
parentColumn = "id",
entityColumn = "metaId",
projection = "subjectId",
entity = SubjectJunction.class)
public List<Long> subjectIds;
@Relation(
parentColumn = "id",
entityColumn = "id",
projection = "documentUri",
entity = FolderEntity.class)
public List<String> parentUris;
}
I have an extension of the original MetadataEntity that works fine without @Relation. Am I missing a limitation here?