@Relation: Entity class must be annotated with @Entity [74041772]

Fixed

Bug

Status Update

No update yet.

Description

am...@gmail.com

created issue #1

Mar 1, 2018 02:42AM

Component used: Room
Version used: 1.1.0-alpha2
Devices/Android versions reproduced on: compile error

Error:(8, 1) Gradle: error: Entity class must be annotated with @Entity
public class MetadataXmp2 {

I can't seem to implement @Relation. I simplified the entities I'm using to this:

@Entity(tableName = "meta")
public class MetadataEntity2 {
@PrimaryKey(autoGenerate = true)
public long id;
public float rating;
public String label;
}

public class MetadataXmp2 /* or extends MetadataEntity2 */ {
@Embedded
public MetadataEntity2 metadata;
@Relation(
parentColumn = "id",
entityColumn = "metaId",
projection = "subjectId",
entity = SubjectJunction.class)
public List<Long> subjectIds;

@Relation(
parentColumn = "id",
entityColumn = "id",
projection = "documentUri",
entity = FolderEntity.class)
public List<String> parentUris;
}

I have an extension of the original MetadataEntity that works fine without @Relation. Am I missing a limitation here?

Comments

yb...@google.com <yb...@google.com> #2Mar 1, 2018 07:45AM

Project: platform/frameworks/support
Branch: androidx-main
Author: George Mount <mount@google.com>
Link: https://android-review.googlesource.com/3451182

Fix focus move within child AndroidViews

Expand for full commit details

Fix focus move within child AndroidViews 
 
Fixes: 389994198 
Fixes: 391378895 
 
Relnote: "Fixes focus travel within child AndroidViews where it 
can sometimes jump out of the child to the ComposeView" 
 
Sometimes the native FocusFinder doesn't act properly and finds 
the wrong View when searching. This CL changes the FocusFinder to 
use a newer copy of FocusFinder for all focus search operations 
in AndroidComposeView. 
 
Test: new test, manual testing 
Change-Id: I678c864afe086879c5c45b018dd82da4f23be440

Files:

M compose/ui/ui/src/androidInstrumentedTest/AndroidManifest.xml
M compose/ui/ui/src/androidInstrumentedTest/kotlin/androidx/compose/ui/focus/FocusListenerTest.kt
A compose/ui/ui/src/androidInstrumentedTest/kotlin/androidx/compose/ui/test/TestActivity2.kt
A compose/ui/ui/src/androidInstrumentedTest/kotlin/androidx/compose/ui/viewinterop/MixedFocusChangeTest.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/platform/AndroidComposeView.android.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/platform/FocusFinderCompat.android.kt

Hash: b028bcc322095634123da91c7146bac9e23c13c7
Date: Tue Jan 14 13:48:11 2025

am...@gmail.com <am...@gmail.com> #3Mar 1, 2018 02:34PM

Project: platform/frameworks/support
Branch: androidx-main
Author: Ralston Da Silva <ralu@google.com>
Link: https://android-review.googlesource.com/3571366

Disabling isViewFocusFixEnabled and isRemoveFocusedViewFixEnabled

Expand for full commit details

Disabling isViewFocusFixEnabled and isRemoveFocusedViewFixEnabled 
 
Disabling these flag to unblock 1.8 RC. 
These were features/bug-fixes that were not regressions 
from 1.7 
 
Bug: 406327273 
Bug: 369256395 
Bug: 378570682 
Bug: 376142752 
Bug: 384056227 
Bug: 388590015 
Bug: 389994198 
Bug: 391378895 
Test: Ran presubmits and added TODOs to the affected tests 
Change-Id: I5ffb7ff27c662838c8b464560d1df830751f015c

Files:

M compose/ui/ui/src/androidInstrumentedTest/kotlin/androidx/compose/ui/focus/FocusViewInteropTest.kt
M compose/ui/ui/src/androidInstrumentedTest/kotlin/androidx/compose/ui/focus/OwnerFocusTest.kt
M compose/ui/ui/src/androidInstrumentedTest/kotlin/androidx/compose/ui/focus/RequestFocusTest.kt
M compose/ui/ui/src/androidInstrumentedTest/kotlin/androidx/compose/ui/viewinterop/MixedFocusChangeTest.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/ComposeUiFlags.kt

Hash: 1a33d21734ef7f68d4cad37c8d333831f304a339
Date: Tue Apr 01 17:46:50 2025

yb...@google.com <yb...@google.com> #4Mar 1, 2018 04:42PM

can you convert this into a sample app? It would be helpful to see where Room reports the error.

am...@gmail.com <am...@gmail.com> #5Mar 2, 2018 12:20AM

https://github.com/rcketscientist/roomRelationTest

I threw this together quickly, it does throw the error. I also gutted the Dao due to other dependencies, since this is a compilation error. If that's an issue let me know. If there are confusing combinations or java/kotlin I apologize as I was trying a lot of combinations just to ensure I wasn't bumping into a Kotlin bug.

yb...@google.com <yb...@google.com> #6Mar 5, 2018 07:47PM

Status: Won't Fix (Intended Behavior)

this is the problem in the code:
@RawQuery(observedEntities = [ MetadataXmp::class, FolderEntity::class, SubjectJunction::class ])
internal abstract fun internalGetRelationImages(query: SupportSQLiteQuery): LiveData<List<MetadataXmp>>

You are asking it to observe MetadataXmp but it is not an entity.

see the docs for details:

https://developer.android.com/reference/android/arch/persistence/room/RawQuery.html#observedEntities()

am...@gmail.com <am...@gmail.com> #7Mar 5, 2018 08:13PM

Ugh, that's a face-palm typo. Knew it had to be something like that. Thanks for taking the time to look at it.

Any chance that error could trace to the query instead of simply pointing at the non-entity we expect to be a non-entity?

[Location] references [Class] which must be annotated with @Entity

yb...@google.com <yb...@google.com> #8Mar 5, 2018 08:22PM

Assigned to yb...@google.com.

you are right, the error does not tell you the real problem.
I'll re-open the docs to improve the messaging.

yb...@google.com <yb...@google.com> #9Mar 13, 2018 06:29AM

Marked as fixed.

ok, I actually changed it to read Pojo's as well so your code will work. We'll traverse the Pojo and consider any @Relation / @Embedded as a table to watch.
If the pojo has no table references, we'll print a proper error.

am...@gmail.com <am...@gmail.com> #10Mar 13, 2018 11:06AM

Even better, thanks!