Verified
Status Update
Comments
cc...@google.com <cc...@google.com> #2
Hi. Thanks for reporting this. Fixed in alpha-04
cc...@google.com <cc...@google.com> #3
Project: platform/frameworks/support
Branch: androidx-main
commit e782987543a9f8ccd485e970ddc74564b24378db
Author: Vighnesh Raut <vighnesh.raut13@gmail.com>
Date: Mon Jan 02 15:27:40 2023
fix: tab row crashes when only 1 tab is added
Bug: b/264018028
Test: Added unit test
Change-Id: I6381dbac304fc1d69d3708c6655f8b595668e93f
M tv/tv-material/src/androidTest/java/androidx/tv/material/TabRowTest.kt
M tv/tv-material/src/main/java/androidx/tv/material/TabRow.kt
https://android-review.googlesource.com/2373449
Branch: androidx-main
commit e782987543a9f8ccd485e970ddc74564b24378db
Author: Vighnesh Raut <vighnesh.raut13@gmail.com>
Date: Mon Jan 02 15:27:40 2023
fix: tab row crashes when only 1 tab is added
Bug:
Test: Added unit test
Change-Id: I6381dbac304fc1d69d3708c6655f8b595668e93f
M tv/tv-material/src/androidTest/java/androidx/tv/material/TabRowTest.kt
M tv/tv-material/src/main/java/androidx/tv/material/TabRow.kt
Description
Version used:
room = "1.1.0-alpha3"
paging = "1.0.0-alpha6"
Lets say i have a dao method with joined tables in the query:
@Query("SELECT * from t1 left join t2")
public abstract DataSource.Factory<Integer, ProjectionModel> getAll();
The following code gets generated by room:
return new LimitOffsetDataSource<ProjectionModel>(__db, _statement, false ,"t1", ,"t2")
There is multiple commas between the observed tables. With only 1 table in the query the code generates correctly.
Previous version(1.1.0-alpha2) also generates code correctly.