Fragment ViewModel's onCleared not called [74139250]

Fixed

Bug

[AOSP] assigned

Status Update

No update yet.

Description

bo...@gmail.com

created issue #1

Mar 3, 2018 10:11AM

Library used (support-v4, appcompat-v7, ...):

implementation 'com.android.support:appcompat-v7:27.1.0'

implementation "android.arch.lifecycle:runtime:1.1.0"
implementation "android.arch.lifecycle:extensions:1.1.0"
implementation "android.arch.lifecycle:common-java8:1.1.0"

Version used: 27.1.0
Theme used: N/A
Devices/Android versions reproduced on: Emulator 24

- Relevant code to trigger the issue.

Make an Activity that contains a Fragment.
Make the Activity use a ViewModel, and make the Fragment also use a ViewModel.
Start the Activity and press back.
The Activity's ViewModel's onCleared method is called.
With AppCompat 27.0.2, the Fragment's ViewModel's onCleared method is called (as it should)
With AppCompat 27.1.0, the Fragment's ViewModel's onCleared method is not called (incorrect).

See the attached project that shows the issue.

With 27.0.2, the logs read:
---------------------------

org.jraf.android.viewmodelproblem.MainActivity: onCreate
org.jraf.android.viewmodelproblem.MainActivityViewModel: constructor
org.jraf.android.viewmodelproblem.MainFragment: onCreate
org.jraf.android.viewmodelproblem.MainFragmentViewModel: constructor

[back is pressed]

org.jraf.android.viewmodelproblem.MainActivity: onDestroy
org.jraf.android.viewmodelproblem.MainActivityViewModel: onCleared
org.jraf.android.viewmodelproblem.MainFragmentViewModel: onCleared
org.jraf.android.viewmodelproblem.MainFragment: onDestroy

With 27.1.0, the logs read:
---------------------------
org.jraf.android.viewmodelproblem.MainActivity: onCreate
org.jraf.android.viewmodelproblem.MainActivityViewModel: constructor
org.jraf.android.viewmodelproblem.MainFragment: onCreate
org.jraf.android.viewmodelproblem.MainFragmentViewModel: constructor

[back is pressed]

org.jraf.android.viewmodelproblem.MainActivity: onDestroy
org.jraf.android.viewmodelproblem.MainActivityViewModel: onCleared
org.jraf.android.viewmodelproblem.MainFragment: onDestroy

This seems to happen because of line 1645 of Fragment, this test:
if (mViewModelStore != null && !mHost.mFragmentManager.isStateSaved()) {
is always false because mHost.mFragmentManager.isStateSaved() is true.

ViewModelProblem.zip

144 KB

Download

Comments

il...@google.com <il...@google.com> Mar 3, 2018 03:58PM

Accepted by il...@google.com.

il...@google.com <il...@google.com> #2Mar 3, 2018 05:15PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019

Change the way to detect mismatch between POJO and query

This fixes cursor mismatch warnings with expandProjection.

Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8

M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt

https://android-review.googlesource.com/1123258

https://goto.google.com/android-sha1/b90079595f33f58fece04026a97faa0d243acdb1

il...@google.com <il...@google.com> Mar 5, 2018 09:55PM

Marked as fixed.

lo...@gmail.com <lo...@gmail.com> #3Mar 6, 2018 08:58AM

The following changes were cherrypicked through Coastguard (

https://android-build.googleplex.com/coastguard/)
Release Track: (

https://android-build.googleplex.com/coastguard/dashboard/6093116828680192/#/cherrypickHistory/all)
Created: 2019-10-14 17:23:42.610596+00:00
Changes: aosp/1123258

ja...@gmail.com <ja...@gmail.com> #4Mar 8, 2018 07:06AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020

Re-factor how errors are dismissed when query is re-written

This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically (

b/140759491

).
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.

This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.

Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f

M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt

https://android-review.googlesource.com/1288456

b9...@gmail.com <b9...@gmail.com> #5Mar 8, 2018 07:13AM

We have to update compile SDK to 28 to adapt this fix?!

ka...@gmail.com <ka...@gmail.com> #6Mar 8, 2018 12:51PM

It was mentioned that it will released in 27.1.1

https://www.reddit.com/r/androiddev/comments/824m81/support_lib_2710_bug_viewmodeloncleared_is_not/dv8d4ua/

b9...@gmail.com <b9...@gmail.com> #7Mar 14, 2018 05:01PM

When will 27.1.1 be released? It is a critical bug seriously.

yc...@gmail.com <yc...@gmail.com> #8Mar 16, 2018 09:45AM

This also seems to have caused a side effect / bug where a ViewModel instance is recreated when its Activity is in the background when device is rotated.

il...@google.com <il...@google.com> #9Mar 16, 2018 04:48PM

Re #8 - no, that would be a separate issue, tracked under

https://issuetracker.google.com/issues/73644080

[Deleted User] <[Deleted User]> #10Mar 19, 2018 03:28AM

Re #9
This issue I was referring to was only reproducible with 27.1.0 though. The one you were referring to was reported prior to 27.1.0 release. Anyway I'll report it as a separate issue. Thanks.

kk...@google.com <kk...@google.com> #11Apr 10, 2018 04:14AM

This bug has been fixed in Support Library 27.1.1.

[Deleted User] <[Deleted User]> #12Apr 16, 2018 03:15PM

The bug with ViewModel is probably fixed, but there is still an issue with loaders:

https://issuetracker.google.com/issues/78095959

an...@gmail.com <an...@gmail.com> #13Jun 8, 2018 10:54AM

This bug doesn't seem to be fixed in 27.1.1.. My application is currently crashing because Fragment's ViewModel doesn't get its #onCleared() method called.
I have all the latest stable versions of Android Studio, support libraries, architecture components libraries and so on.

Are you sure that the fix to this issue was included in 27.1.1? Or maybe in 28.0.0-alphaX?

il...@google.com <il...@google.com> #14Jun 8, 2018 02:33PM

Re #13 - The original issue as demonstrated by the sample projects attached has been fixed in 27.1.1.

You could certainly have an issue with similar symptoms but with a different root cause - if you're able to reproduce an issue even with the latest 28.0.0-alpha3, please file a new bug with a sample project that reproduces your issue.

al...@gmail.com <al...@gmail.com> #15Jun 15, 2018 09:18PM

The following scenario is still unfixed:

Have Don't keep activities enabled.
Start the app.
Push home button.

On 27.0.2 I have the following output at logcat:

V/ViewModelFirst: Created
V/ViewModelFirst: onCleared
V/FragmentFirst: onDestroy
V/MainActivity: onDestroy
Which totally correct.

But on 27.1.1 till 28.0.0-alpha3 I have the following output at logcat:

V/ViewModelFirst: Created
V/FragmentFirst: onDestroy
V/MainActivity: onDestroy

As we can see activity and fragment was destroyed but viewModel was not notified with onCleared.

I suspect that in case if the Don't keep activities will be disabled and the app at background will be naturally unloaded by Android at some moment of time the viewModel.onCleared() will not be called which is very sad.

al...@gmail.com <al...@gmail.com> #16Jun 15, 2018 09:21PM

The code is here:

https://github.com/allco/onClearedInvestigation

lb...@gmail.com <lb...@gmail.com> #17Jun 15, 2018 09:26PM

@15 You should open a new thread. Once Google closes an issue , there is a much smaller chance they ever read what you've written in it, and it happens a lot, sadly

al...@gmail.com <al...@gmail.com> #18Jun 16, 2018 04:43PM

@17, thanks for the suggestion. I have reported the issue here:

https://issuetracker.google.com/issues/110285295

m....@gmail.com <m....@gmail.com> #19Dec 27, 2018 08:16PM

https://drive.google.com/file/d/1zBwQSAHyw8aoyggjjYoG6Bo4NQz3l45T/view?usp=drive_web (-Docs--1.docx)

3g...@gmail.com <3g...@gmail.com> #20Mar 27, 2021 06:55AM

file sdcard encrypt....

[Deleted User] <[Deleted User]> #21Mar 2, 2022 06:20AM

Common