DAO Implementation Executing Incorrect/Old Query [76031240]

Fixed

Bug

Status Update

No update yet.

Description

tr...@gmail.com

created issue #1

Mar 21, 2018 07:10PM

Component used: Room
Version used: 1.1.0-alpha3
Devices/Android versions reproduced on: Pixel 2 XL, Android 8.1.0

The screenshot shows this, but I've got a DAO method that returns a Single<List<RawMetadata>> and for some reason, it seems that the method occasionally runs an incorrect query (I'm guessing it's one that got pulled from RoomSQLiteQuery's pool). This is causing "column not found" issues because the DAO is looking for the columns that make sense for the particular DAO method that was called, but the cursor contains all of the columns from the incorrect/old query.

Note the mQuery value of _statement in the debugger variables pane and how it's different than the _sql value on line 227.

Screen Shot 2018-03-21 at 1.02.30 PM.png

874 KB

View

Download

Comments

yb...@google.com <yb...@google.com> #2Mar 21, 2018 07:28PM

At least make BottomSheet can be launched from local like AlertDialog. Right now, it's too hard to have multiple BottomSheets on one screen with BottomSheetScaffold.

tr...@gmail.com <tr...@gmail.com> #3Mar 21, 2018 07:37PM

(Maybe I don't where this lives in documentation) I'm looking for a similar behavior in SwiftUI where you can call `.sheet()` to invoke a bottom sheet at any point which overtakes the screen. This behaves just like `.alert` in SwiftUI.

tr...@gmail.com <tr...@gmail.com> #4Mar 21, 2018 07:39PM

Re comment#2 and comment#3 - this issue is only tracking the integration of bottom sheets into Navigation Compose so that you can use navController.navigate() to make a bottom sheet appear.

If you'd like to request changes to the ModalBottomSheetLayout and similar APIs, you'll want to file a separate request against Compose.

yb...@google.com <yb...@google.com> #5Mar 21, 2018 07:43PM

Fwiw this change does enable treating bottom sheets more like a window-esque thing, but they definitely won't be local.

tr...@gmail.com <tr...@gmail.com> #6Mar 21, 2018 07:49PM

Accompanist now supports this with Navigation Material.

tr...@gmail.com <tr...@gmail.com> #7Mar 22, 2018 02:48PM

This feature will be super useful!

yb...@google.com <yb...@google.com> #8Mar 25, 2018 05:54PM

Assigned to yb...@google.com.

Until this is implemented, could we at least get a warning notice in the documentation?

Not great to find out half way through a migration that this isn't possible.

Looks like we'll need to rework our app's navigation system (currently based on Fragments) just to support bottom sheets with a Bottom Navigation Bar at first glance. From the docs this wasn't clear.

tr...@gmail.com <tr...@gmail.com> #9Mar 26, 2018 05:44AM

Re comment#6 - can you explain what you are talking about? A fragment based navigation system is not going to be using Navigation Compose, which is what this issue is about and which is already available via Accompanist Navigation Material to unblock any migration to Navigation Compose from a fragment based system.

BottomSheetDialogFragment, which is what you'd use in a fragment based system, has been supported since dialog destinations were added in Navigation 2.1.0-alpha03 back in 2019.

ya...@google.com <ya...@google.com> Mar 30, 2018 06:10AM

Reassigned to ya...@google.com.

yb...@google.com <yb...@google.com> #10Mar 30, 2018 09:05PM

Reassigned to yb...@google.com.

Project: platform/frameworks/support
Branch: androidx-main

commit d65d5731e4f0dfe560b43eae886a4fabfa949b84
Author: Jeremy Woods <jbwoods@google.com>
Date: Wed Feb 21 02:14:42 2024

Add Navigation Material from Accompanists to androidx

Now that the needed compose material API are stable, we can move the
navigation material module from Accompanists to Androidx. This means we
will have a new compose-material-navigation module that provides support
for bottomsheets.

RelNote: "Providing new Compose Material Navigation module that adds
support for Bottomsheets in Compose Material."
Test: Added tests and samples
Bug: 180247978

Change-Id: Ia93eb757a32b04dac8ab3ebd2d73207a68635b80

A compose/material/material-navigation/api/current.txt
A compose/material/material-navigation/api/res-current.txt
A compose/material/material-navigation/api/restricted_current.txt
A compose/material/material-navigation/build.gradle
A compose/material/material-navigation/samples/build.gradle
A compose/material/material-navigation/samples/src/main/java/androidx/compose/material/navigation/samples/ComposeMaterialNavigationSamples.kt
A compose/material/material-navigation/src/androidTest/java/androidx/compose/material/navigation/BottomSheetNavigatorTest.kt
A compose/material/material-navigation/src/androidTest/java/androidx/compose/material/navigation/NavGraphBuilderTest.kt
A compose/material/material-navigation/src/androidTest/java/androidx/compose/material/navigation/SheetContentHostTest.kt
A compose/material/material-navigation/src/main/java/androidx/compose/material/navigation/BottomSheet.kt
A compose/material/material-navigation/src/main/java/androidx/compose/material/navigation/BottomSheetNavigator.kt
A compose/material/material-navigation/src/main/java/androidx/compose/material/navigation/NavGraphBuilder.kt
A compose/material/material-navigation/src/main/java/androidx/compose/material/navigation/SheetContentHost.kt
M compose/material/material/integration-tests/material-demos/build.gradle
M compose/material/material/integration-tests/material-demos/src/main/java/androidx/compose/material/demos/MaterialDemos.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/ModalBottomSheet.kt
M docs-tip-of-tree/build.gradle
M settings.gradle

https://android-review.googlesource.com/2953937

yb...@google.com <yb...@google.com> #11Mar 30, 2018 09:06PM

This has been added internally and will be released as part of the compose.material library, not navigation.

tr...@gmail.com <tr...@gmail.com> #12Apr 2, 2018 10:02PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.compose.material:material:1.7.0-alpha04
androidx.compose.material:material-android:1.7.0-alpha04
androidx.compose.material:material-desktop:1.7.0-alpha04

yb...@google.com <yb...@google.com> Apr 21, 2018 10:36PM

Marked as fixed.