hide protected fields [76109329]

Fixed

Internal Cleanup

androidx-bug-bounty

Status Update

No update yet.

Description

yb...@google.com

created issue #1

Mar 21, 2018 09:16PM

ROomDatabase has protected mCallbacks field which is leaking in the API docs, we should @Hide it.

it is not intended for public use.

https://developer.android.com/reference/android/arch/persistence/room/RoomDatabase.html#mCallbacks

Comments

yb...@google.com <yb...@google.com> #2Mar 25, 2018 08:11PM

Thank you for suggesting this enhancement. We value the feedback from our community and hope to review your suggestion in an upcoming sprint.

yb...@google.com <yb...@google.com> Jun 15, 2018 05:28PM

Reassigned to da...@google.com.

fl...@google.com <fl...@google.com> Jul 19, 2019 08:42AM

Reassigned to fl...@google.com.

fl...@google.com <fl...@google.com> Jul 19, 2019 02:01PM

Accepted by fl...@google.com.

yb...@google.com <yb...@google.com> #3Jul 30, 2020 09:01PM

This has now been implemented.

Thanks for the suggestion!

[Deleted User] <[Deleted User]> #4Aug 9, 2020 10:54PM

Thank you for your patience while our engineering team worked to resolve this issue. A fix for this issue is now available in:

Android Studio Dolphin Canary 2 (2021.3.1.2)
Android Gradle Plugin 7.3.0-alpha02

We encourage you to try the latest update.

If you notice further issues or have questions, please file a new bug report.

Thank you for taking the time to submit feedback — we really appreciate it!

ap...@google.com <ap...@google.com> #5Aug 24, 2020 06:09PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-master-dev

commit d576cbdc911cba16638a44fd8223391a90a07ef7
Author: Mike Nakhimovich <digitalbuddha@users.noreply.github.com>
Date: Tue Aug 11 09:30:34 2020

[GH] Hide deprecated internal API.

## Proposed Changes

* `RoomDatabase.java` has protected `mCallbacks` field which is leaking in the API docs, we should @Hide it.

## Testing

Test: Ran unit tests locally

## Issues Fixed

Fixes: 76109329

This is an imported pull request from

https://github.com/androidx/androidx/pull/61.

Resolves #61
Github-Pr-Head-Sha: 6440daa3a63752c7f9d5ba2a390248cd85bc634f
GitOrigin-RevId: fe92d8466a59b44b218b6ca3cbd57dcda17992f7

Change-Id: Id599cdf5b02b32bdae0166266fb7da967598fe92

A room/runtime/api/current.ignore
M room/runtime/api/current.txt
M room/runtime/api/public_plus_experimental_current.txt
M room/runtime/api/restricted_current.txt
M room/runtime/src/main/java/androidx/room/RoomDatabase.java

https://android-review.googlesource.com/1396827