Fixed
Status Update
No update yet.
Comments
yb...@google.com
we've considered this, just didn't have time to implement.
Btw, we cannot just use name() because it might be proguarded away. so we need to generate the code that matches enums to hardcoded string values.
If you are using name(), be careful about migrations since 2 different compilations might have different names for the enum values.
Btw, we cannot just use name() because it might be proguarded away. so we need to generate the code that matches enums to hardcoded string values.
If you are using name(), be careful about migrations since 2 different compilations might have different names for the enum values.
ke...@gmail.com
True. Even though this could be fixed by using proguard rules.
Would be great to see this in the future, it's really lots of code here ;)
Would be great to see this in the future, it's really lots of code here ;)
ya...@google.com
What about the idea of using a more generic adapter which can handle all of the enums in your app? That way you could decide to persist them all with one "stone". You could choose to save them as strings, ordinals or even some other way of your choosing. But you would not have to add an adapter for every enum type in your app. You just have to add the one special enum adapter and Room would know how to use it for all enums.
ke...@gmail.com
This seems like a possible candidate for external contributions so moving it to the bug bounty hotlist.
We still need a proper design here hence not super straightforward.
Such design should ensure we are:
- safe for proguard (in case we go w/ name)
- have some logic for defaults (in case an enum is removed or renamed)
- possibly support ordinals (though that might be a case where we can require a type converter)
- possibly make it opt-in so that developer explicitly picks an option (e.g. some annotation on the enum to enable this)
ya...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit ae093dec7bfdc578cf0d7cd2ee6c8563ddd4f5ed
Author: Elif Bilgin <elifbilgin@google.com>
Date: Wed Oct 21 11:50:07 2020
Optimization for storing enums in databases.
Creating a default type adapter to persist Enums in Room. Changes made in logic of the findQueryParameterAdapter(...) function where we now try to find a TypeConverter for the collection of an object first, and if not, then try to find one for the type arg.
Test: Baseline tests replicate compiler errors in EnumColumnTypeAdapterTest.java
Bug: 73132006
Change-Id: Ia212097c16fde4302bc7c20cbad1604a996090ad
M room/compiler-processing/src/main/java/androidx/room/compiler/processing/XType.kt
M room/compiler-processing/src/main/java/androidx/room/compiler/processing/javac/JavacType.kt
M room/compiler-processing/src/main/java/androidx/room/compiler/processing/ksp/KspArrayType.kt
M room/compiler-processing/src/main/java/androidx/room/compiler/processing/ksp/KspDeclaredType.kt
M room/compiler-processing/src/main/java/androidx/room/compiler/processing/ksp/KspType.kt
M room/compiler-processing/src/main/java/androidx/room/compiler/processing/ksp/KspTypeArgumentType.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
A room/compiler/src/main/kotlin/androidx/room/solver/types/EnumColumnTypeAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/DaoProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/solver/TypeAdapterStoreTest.kt
A room/integration-tests/testapp/src/androidTest/java/androidx/room/integration/testapp/test/EnumColumnTypeAdapterTest.java
https://android-review.googlesource.com/1469447
Branch: androidx-master-dev
commit ae093dec7bfdc578cf0d7cd2ee6c8563ddd4f5ed
Author: Elif Bilgin <elifbilgin@google.com>
Date: Wed Oct 21 11:50:07 2020
Optimization for storing enums in databases.
Creating a default type adapter to persist Enums in Room. Changes made in logic of the findQueryParameterAdapter(...) function where we now try to find a TypeConverter for the collection of an object first, and if not, then try to find one for the type arg.
Test: Baseline tests replicate compiler errors in EnumColumnTypeAdapterTest.java
Bug: 73132006
Change-Id: Ia212097c16fde4302bc7c20cbad1604a996090ad
M room/compiler-processing/src/main/java/androidx/room/compiler/processing/XType.kt
M room/compiler-processing/src/main/java/androidx/room/compiler/processing/javac/JavacType.kt
M room/compiler-processing/src/main/java/androidx/room/compiler/processing/ksp/KspArrayType.kt
M room/compiler-processing/src/main/java/androidx/room/compiler/processing/ksp/KspDeclaredType.kt
M room/compiler-processing/src/main/java/androidx/room/compiler/processing/ksp/KspType.kt
M room/compiler-processing/src/main/java/androidx/room/compiler/processing/ksp/KspTypeArgumentType.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
A room/compiler/src/main/kotlin/androidx/room/solver/types/EnumColumnTypeAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/DaoProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/solver/TypeAdapterStoreTest.kt
A room/integration-tests/testapp/src/androidTest/java/androidx/room/integration/testapp/test/EnumColumnTypeAdapterTest.java
Description
Version used: 1.1.0-beta1
Devices/Android versions reproduced on: Emulator/ Nexus 5x/ Android 8
When I call clearAllTables from Room, it say that I need a Transaction to do that, but when I create the transaction it throws the error below.
Code below:
appDatabase.beginTransaction();
appDatabase.clearAllTables();
appDatabase.endTransaction();
03-29 13:45:36.580 11888-13324/br.com.mobilesales.influxlexical E/AndroidRuntime: FATAL EXCEPTION: pool-1-thread-1
Process: br.com.mobilesales.influxlexical, PID: 11888
android.database.sqlite.SQLiteException: cannot VACUUM from within a transaction (code 1)
at android.database.sqlite.SQLiteConnection.nativeExecuteForChangedRowCount(Native Method)
at android.database.sqlite.SQLiteConnection.executeForChangedRowCount(SQLiteConnection.java:735)
at android.database.sqlite.SQLiteSession.executeForChangedRowCount(SQLiteSession.java:754)
at android.database.sqlite.SQLiteStatement.executeUpdateDelete(SQLiteStatement.java:64)
at android.database.sqlite.SQLiteDatabase.executeSql(SQLiteDatabase.java:1754)
at android.database.sqlite.SQLiteDatabase.execSQL(SQLiteDatabase.java:1682)
at android.arch.persistence.db.framework.FrameworkSQLiteDatabase.execSQL(FrameworkSQLiteDatabase.java:242)
at br.com.mobilesales.influxlexical.data.source.local.AppDatabase_Impl.clearAllTables(AppDatabase_Impl.java:360)
at br.com.mobilesales.influxlexical.InfluxLexicalApplication$1.run(InfluxLexicalApplication.java:152)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1162)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:636)
at java.lang.Thread.run(Thread.java:764)