Fixed
Status Update
Comments
yb...@google.com <yb...@google.com>
su...@gmail.com <su...@gmail.com> #2
Hi. Thanks for reporting this. Fixed in alpha-04
el...@google.com <el...@google.com>
ap...@google.com <ap...@google.com> #3
Project: platform/frameworks/support
Branch: androidx-main
commit e782987543a9f8ccd485e970ddc74564b24378db
Author: Vighnesh Raut <vighnesh.raut13@gmail.com>
Date: Mon Jan 02 15:27:40 2023
fix: tab row crashes when only 1 tab is added
Bug: b/264018028
Test: Added unit test
Change-Id: I6381dbac304fc1d69d3708c6655f8b595668e93f
M tv/tv-material/src/androidTest/java/androidx/tv/material/TabRowTest.kt
M tv/tv-material/src/main/java/androidx/tv/material/TabRow.kt
https://android-review.googlesource.com/2373449
Branch: androidx-main
commit e782987543a9f8ccd485e970ddc74564b24378db
Author: Vighnesh Raut <vighnesh.raut13@gmail.com>
Date: Mon Jan 02 15:27:40 2023
fix: tab row crashes when only 1 tab is added
Bug:
Test: Added unit test
Change-Id: I6381dbac304fc1d69d3708c6655f8b595668e93f
M tv/tv-material/src/androidTest/java/androidx/tv/material/TabRowTest.kt
M tv/tv-material/src/main/java/androidx/tv/material/TabRow.kt
Description
Version used: 1.1.0
Devices/Android versions reproduced on: n/a
Ideally, the JavaDocs for TypeConverters would be a bit more specific about what things can be converted via TypeConverters. For example, there is an indication that you cannot use TypeConverters to convert the return value of a @Query-annotated DAO method:
One possibility would be to convert the bulleted list in to a table, with rows for the @TypeConverters location (e.g., "put it on a Database"), columns for what specific things get affected (entity fields, DAO method parameters, etc.), and X's or other indicators in the cells to show what is and is not covered.
Thanks for considering this!