IssueTracker

Project: platform/frameworks/support
Branch: androidx-main

commit 57ca221882695bd6a52549f4d9ea3b812e6fe87c
Author: Simon Schiller <simonschiller@users.noreply.github.com>
Date:   Mon Mar 22 16:09:30 2021

    [GH] [FragmentStrictMode] Detect <fragment> tag usage
   
    ## Proposed Changes
   
      - Detect `<fragment>` tag usage inside XML layouts
   
    ## Testing
   
    Test: See `FragmentStrictModeTest#detectFragmentTagUsage`
   
    ## Issues Fixed
   
    Fixes: 153738235
   
    This is an imported pull request from https://github.com/androidx/androidx/pull/141.
   
    Resolves #141
    Github-Pr-Head-Sha: 4ea052596e4341b9f11bcf335e2bc38045a91f19
    GitOrigin-RevId: 62e7487aa4874eef6bb556490e193717cf937251
    Change-Id: Iae48578e85e4e4897f806d7ade2e2a660adf9479

M       fragment/fragment/api/public_plus_experimental_current.txt
M       fragment/fragment/api/restricted_current.txt
M       fragment/fragment/src/androidTest/java/androidx/fragment/app/strictmode/FragmentStrictModeTest.kt
M       fragment/fragment/src/main/java/androidx/fragment/app/FragmentLayoutInflaterFactory.java
M       fragment/fragment/src/main/java/androidx/fragment/app/strictmode/FragmentStrictMode.java
A       fragment/fragment/src/main/java/androidx/fragment/app/strictmode/FragmentTagUsageViolation.java

https://android-review.googlesource.com/1649748

We have passed this to the development team and will update this issue with more information as it becomes available.

Yeah, I'm seeing this issue as well, currently this is the workaround that I've come up with:

    // This method is called when hide()/show() methods are called on the transaction. Unfortunately Android doesn't
    // propagate it to the child fragments (even though their visibility is affected by the parent visibility), so we
    // do it manually.
    override fun onHiddenChanged(hidden: Boolean) {
        super.onHiddenChanged(hidden)
        childFragmentManager.fragments.forEach { it.onHiddenChanged(hidden) }
    }

@4 That actually won't technically fix as isHidden() will technically mismatch with the state passed into the child fragment.  Each child fragment legitimately needs to have their state set to hidden.

Yeah, I realized that as I kept working further on it. Nevermind that solution, it doesn't work.

@6 I don't know what the ramifications are, but when you iterate, you can save the "currentState" and then hide them all via a transaction. When restoring to visible, restore to the original state.

Project: platform/frameworks/support
Branch: androidx-main

commit 02290cddca3d5e4dc94e2c5f77a6728ad970b204
Author: Jeremy Woods <jbwoods@google.com>
Date:   Thu Oct 07 13:11:45 2021

    Dispatch onHiddenChanged to child fragments
   
    When a parent fragment is hidden all of its children will automatically
    be hidden, but we never call onHiddenChanged on any of the children.
   
    We should dispatch onHiddenChanged down parent's entire hierarchy and
    ensure that `isHidden()` also considers the parent's state.
   
    RelNote: "Parent fragments will now dispatch `onHiddenChanged()` down
    their entire hierarchy before launching their own call back."
    Test: added test
    Bug: 77504618
   
    Change-Id: Iedc201ab435cb963e81bc02d203d4d37ff827e01

M       fragment/fragment/src/androidTest/java/androidx/fragment/app/FragmentViewTest.kt
M       fragment/fragment/src/main/java/androidx/fragment/app/FragmentStateManager.java
M       fragment/fragment/src/main/java/androidx/fragment/app/FragmentManager.java
M       fragment/fragment/src/main/java/androidx/fragment/app/Fragment.java

https://android-review.googlesource.com/1850016