Status Update
Comments
gg...@google.com <gg...@google.com> #2
First of all thanks for this detailed issue.
This issue had been investigated thoroughly when it was first reported internally. The surprising detail in this report is that the issue is not reproducible before 1.7
. I will look into this.
The main problem with POBox is the fact that it is deprecated. Since 2021 Sony has been shipping new Xperia devices with Gboard pre-installed. Although we are aware that there is still a considerable amount of users still using POBox, the described behavior is caused by POBox's noncompliant behavior with InputConnection
and InputMethodManager
documentation. However, this is understandable since TextView
implementation was also not respecting the behavior that is expected from Editors.
Ultimately we have decided to enforce the documented behavior with specifically regards to when editors should call InputMethodManager.updateSelection
. Also, although unconfirmed, there were traces of possible custom code being included in Sony OEM images that changed how InputMethodManager was notified from TextView. If POBox also depended on something like this, it would be impossible for Compose code to replicate the same unknown behavior.
ri...@soundcloud.com <ri...@soundcloud.com> #3
Or is that option not available?
Even if the root cause is POBox, from the perspective of the app's customers, it looks like an app bug, so this issue is a blocker against updating Jetpack Compose.
nk...@google.com <nk...@google.com> #4
Just to be sure, it is dangerous to replace Compose TextField with Android View EditText as a workaround for this issue.
Compose 1.7 has a bug that causes ANR when the focus is on EditText.
Another View-related bug in Compose 1.7 is that an Android View is focused by calling FocusManager.clearFocus().
Perhaps there is a lack of testing of Compose 1.7 in combination with Android View. There is also a possibility that there are other fatal bugs related to View.
In other words, the only options for apps targeting the Japanese market that require POBox support are to continue using Compose 1.6 or to use EditText in combination with various workarounds.
br...@gmail.com <br...@gmail.com> #5
Project: platform/frameworks/support
Branch: androidx-main
Author: Halil Ozercan <
Link:
Fix POBox keyboard issue
Expand for full commit details
Fix POBox keyboard issue
Fix: 373743376
Fix: 329209241
Test: NullableInputConnectionWrapperTest
Change-Id: I94e0e598274fb88b255f977f9fbd50dfbbb1ecb1
Files:
- M
compose/ui/ui/src/androidInstrumentedTest/kotlin/androidx/compose/ui/text/input/NullableInputConnectionWrapperTest.kt
- M
compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/text/input/NullableInputConnectionWrapper.android.kt
Hash: 57f58c4b80d5d8470b2aca325dfdcd55f235231e
Date: Thu Oct 24 01:25:20 2024
[Deleted User] <[Deleted User]> #6
Many thanks again for this report. Especially for giving us a huge clue in terms of what could be going wrong. The fix is now merged and I will ask for a cherry-pick into a stable release.
[Deleted User] <[Deleted User]> #7
Do you have any concrete plan to cherry-pick the fix into current stable version (1.7.x)? We are currently waiting it.
[Deleted User] <[Deleted User]> #8
Yes, this fix is planned to be included in a future 1.7.x
release.
fe...@gmail.com <fe...@gmail.com> #9
Thanks for the fix. Sorry to follow up on this. is it possible for you to share specific release version/date for the stable version? We are waiting on this to decide on our direction.
fe...@gmail.com <fe...@gmail.com> #10
This crash happened on a Pixel 3 device on Firebase test lab, running Android 29.
va...@theblueground.com <va...@theblueground.com> #11
We use androidx.test:orchestrator:1.4.2
This failure happens in every run on a Pixel2.arm device on Firebase TestLab. We tried using Android 33 and 32.
Tests pass but we are getting failures due to the orchestrator. The stacktrace is the following.
java.lang.RuntimeException: android.os.TransactionTooLargeException: data parcel size 1162100 bytes
FATAL EXCEPTION: AndroidTestOrchestrator
Process: androidx.test.orchestrator, PID: 9628
java.lang.RuntimeException: android.os.TransactionTooLargeException: data parcel size 1162100 bytes
at android.app.ActivityThread.finishInstrumentation(ActivityThread.java:6952)
at android.app.Instrumentation.finish(Instrumentation.java:270)
at androidx.test.orchestrator.AndroidTestOrchestrator.finish(AndroidTestOrchestrator.java:1)
at androidx.test.orchestrator.AndroidTestOrchestrator.executeNextTest(AndroidTestOrchestrator.java:2)
at androidx.test.orchestrator.AndroidTestOrchestrator.runFinished(AndroidTestOrchestrator.java:10)
at androidx.test.orchestrator.TestRunnable.run(TestRunnable.java:11)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1137)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:637)
at java.lang.Thread.run(Thread.java:1012)
Caused by: android.os.TransactionTooLargeException: data parcel size 1162100 bytes
at android.os.BinderProxy.transactNative(Native Method)
at android.os.BinderProxy.transact(BinderProxy.java:584)
at android.app.IActivityManager$Stub$Proxy.finishInstrumentation(IActivityManager.java:5534)
at android.app.ActivityThread.finishInstrumentation(ActivityThread.java:6950)
... 8 more
Description
Version used: 1.0.1
How are you running your tests (via Android Studio, Gradle, adb, etc.)?
- Firebase Test Lab (not sure it matters, but we are running 99.99% of our tests there)
How are you running your tests (via Android Studio, Gradle, adb, etc.)?
- gcloud command line
How to reproduce:
- The issue is not happening consistently and I haven't find how to reproduce it.
What is the expected output? What do you see instead?
- I expect to see the test either passed or failed for an assertion failed in my code but I rather get the following error message:
Test instrumentation process crashed. Check com.my.package.MyTest#testName.txt for details.
Reading the logcat I can see this exception printed:
I/TestRunner(8940): ----- begin exception -----
I/TestRunner(8940): java.lang.IllegalStateException: Unable to send TestFailure status, terminating
I/TestRunner(8940): at android.support.test.orchestrator.instrumentationlistener.OrchestratedInstrumentationListener.testFailure(OrchestratedInstrumentationListener.java:136)
I/TestRunner(8940): at org.junit.runner.notification.SynchronizedRunListener.testFailure(SynchronizedRunListener.java:63)
I/TestRunner(8940): at org.junit.runner.notification.RunNotifier$4.notifyListener(RunNotifier.java:142)
I/TestRunner(8940): at org.junit.runner.notification.RunNotifier$SafeNotifier.run(RunNotifier.java:72)
I/TestRunner(8940): at org.junit.runner.notification.RunNotifier.fireTestFailures(RunNotifier.java:138)
I/TestRunner(8940): at org.junit.runner.notification.RunNotifier.fireTestFailure(RunNotifier.java:132)
I/TestRunner(8940): at org.junit.internal.runners.model.EachTestNotifier.addFailure(EachTestNotifier.java:23)
I/TestRunner(8940): at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:329)
I/TestRunner(8940): at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
I/TestRunner(8940): at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
I/TestRunner(8940): at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
I/TestRunner(8940): at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
I/TestRunner(8940): at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
I/TestRunner(8940): at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
I/TestRunner(8940): at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
I/TestRunner(8940): at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
I/TestRunner(8940): at org.junit.runners.Suite.runChild(Suite.java:128)
I/TestRunner(8940): at org.junit.runners.Suite.runChild(Suite.java:27)
I/TestRunner(8940): at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
I/TestRunner(8940): at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
I/TestRunner(8940): at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
I/TestRunner(8940): at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
I/TestRunner(8940): at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
I/TestRunner(8940): at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
I/TestRunner(8940): at org.junit.runner.JUnitCore.run(JUnitCore.java:137)
I/TestRunner(8940): at org.junit.runner.JUnitCore.run(JUnitCore.java:115)
I/TestRunner(8940): at android.support.test.internal.runner.TestExecutor.execute(TestExecutor.java:58)
I/TestRunner(8940): at android.support.test.runner.AndroidJUnitRunner.onStart(AndroidJUnitRunner.java:375)
I/TestRunner(8940): at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1879)
I/TestRunner(8940): Caused by: android.os.TransactionTooLargeException: data parcel size 2495968 bytes
I/TestRunner(8940): at android.os.BinderProxy.transactNative(Native Method)
I/TestRunner(8940): at android.os.BinderProxy.transact(Binder.java:503)
I/TestRunner(8940): at android.support.test.runner.internal.deps.aidl.BaseProxy.transactAndReadExceptionReturnVoid(BaseProxy.java:65)
I/TestRunner(8940): at android.support.test.orchestrator.callback.OrchestratorCallback$Stub$Proxy.sendTestNotification(OrchestratorCallback.java:96)
I/TestRunner(8940): at android.support.test.orchestrator.instrumentationlistener.OrchestratedInstrumentationListener.sendTestNotification(OrchestratedInstrumentationListener.java:167)
I/TestRunner(8940): at android.support.test.orchestrator.instrumentationlistener.OrchestratedInstrumentationListener.testFailure(OrchestratedInstrumentationListener.java:134)
I/TestRunner(8940): ... 28 more
I/TestRunner(8940): ----- end exception -----