Fixed
Status Update
No update yet.
Comments
pe...@gmail.com
Yigit, do you have time to fix it?
reemission of the same liveData is racy
reemission of the same liveData is racy
gg...@google.com
gg...@google.com
yea i'll take it.
al...@gmail.com
Thanks for the detailed analysis. This may not be an issue anymore since we've started using Main.immediate there but I' not sure; I'll try to create a test case.
gg...@google.com
just emitting same live data reproduces the issue.
@Test
fun raceTest() {
val subLiveData = MutableLiveData(1)
val subject = liveData(testScope.coroutineContext) {
emitSource(subLiveData)
emitSource(subLiveData) //crashes
}
subject.addObserver().apply {
testScope.advanceUntilIdle()
}
}
@Test
fun raceTest() {
val subLiveData = MutableLiveData(1)
val subject = liveData(testScope.coroutineContext) {
emitSource(subLiveData)
emitSource(subLiveData) //crashes
}
subject.addObserver().apply {
testScope.advanceUntilIdle()
}
}
Description
Version used: 1.0.0-alpha01
Devices/Android versions reproduced on: Nexus 5X
How to reproduce:
Create and enqueue a data worker with a float or a double value:
Data.Builder builder = new Data.Builder();
builder.putFloat("test", 1.0f);
.... // create a request
WorkManager workManager = WorkManager.getInstance();
workManager.enqueue(request)
Read the value in the doWork() call:
public Worker.WorkerResult doWork()
{
this.getInputData().getFloat("test", 0f);
}
java.lang.IllegalArgumentException: Key intensity has invalid type class java.lang.Float
at androidx.work.Data$Builder.putAll(Data.java:632)
at androidx.work.OverwritingInputMerger.merge(OverwritingInputMerger.java:43)
at androidx.work.impl.WorkerWrapper.run(WorkerWrapper.java:120)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1133)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:607)
at java.lang.Thread.run(Thread.java:761)
The problem seems to be that the androidx.work.Data$Builder.putAll method though is handling all data types including float/double arrays, is actually missing float and double primitive types.