Spinner's dropDownHorizontalOffset attribute has no effect [79477181]

Obsolete

Bug

[AOSP] assigned

Status Update

No update yet.

Description

ty...@gmail.com

created issue #1

May 9, 2018 11:18PM

NOTE:
This issue is a copy of an existing issue (36996315), but has to be refiled. According to a Google developer at Google I/O 2018 the bug's status probably got 'lost' when switching bug trackers for Android. The bug is still relevant, hasn't been solved (even though it's marked as Obsolete).

ORIGINAL REPORT:
- Steps to reproduce the problem (including sample code if appropriate).

Create a simple layout with a spinner and set any value for the dropDownHorizontalOffset attribute

For example -

<Spinner
android:id="@+id/spinner"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:layout_centerInParent="true"
android:dropDownHorizontalOffset="50dp"
android:prompt="@string/spinner_title"
android:spinnerMode="dropdown" />

- What happened.

The dropdown popup window is displayed normally without any horizontal offset.

- What you think the correct behavior should be.

The dropdown popup window should be applied the horizontal offset *before* displaying it.

A quick dive in the Spinner source code revealed that though the horizontal offset is being applied to the popup window in the Spinner's constructor, it is not being taken into consideration in the computeContentWidth() which is called before displaying the spinner. Thereby causing the popup window to not have the proper horizontal offset.

Don't forget to mention which version of Android you're using, and/or which
device the problem appears on (model and Android version).

Nexus 10 4.4.2

ADDITIONS:
As can be seen in the comments on the original issue, this issue still exists and is still relevant.

Comments

ku...@google.com <ku...@google.com> May 10, 2018 06:26AM

Assigned to ku...@google.com.

ku...@google.com <ku...@google.com> #2May 10, 2018 07:27AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit c60f33e229e31ab328ef6b59dab63b264954831c
Author: Alexandre Elias <aelias@google.com>
Date: Fri Jul 10 16:23:09 2020

Semantics no-op cleanups

Partly in response to lmr's broad code review, I did a pass of
superficial API/implementation cleanup. The main changes are:

- I changed each Boolean SemanticsProperty where false is equivalent to
not being present to take "Unit" instead. This is conceptually
clearer: it avoids questions like "can I cancel out a semantics from a
merged child by setting it to false?" Because "property = Unit" looks
weird, I also changed the style of these to "property()".

- I moved the Semantics id generator closer to where it's used, in
SemanticsModifierCore. I made it internal and an AtomicInt.
(Note that integer ids are heavily used in the Android
AccessibilityNodeInfo APIs so I can't simply remove them entirely.)

- I deleted dead code. Some examples include SemanticsHintOverrides,
a public API not connected to anything, and SemanticsPropertyKey
merge() open method which is never called. (In both cases I have
a different plan in mind for accessibility.)

Fixes: 145951226
Fixes: 145955412
Test: existing tests
Relnote: "Single-value semantics properties now use a calling style.
For example, 'semantics { hidden = true }' is now written as:
'semantics { hidden() }'."

Change-Id: Ic1afd12ea22c926babc9662f1804d80b33aa0cfc

M ui/integration-tests/benchmark/src/androidTest/java/androidx/ui/benchmark/test/LayoutNodeModifierBenchmark.kt
M ui/ui-core/api/0.1.0-dev15.txt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev15.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/graphics/vector/VectorTest.kt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/semantics/SemanticsTests.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidActuals.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeView.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeViewAccessibilityDelegateCompat.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidPopup.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/Expect.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsConfiguration.kt
D ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsHintOverrides.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsModifier.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsNode.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsOwner.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsWrapper.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/semantics/SemanticsProperties.kt
M ui/ui-foundation/api/0.1.0-dev15.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev15.txt
M ui/ui-foundation/api/restricted_current.txt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Clickable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Dialog.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Scroller.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Selectable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Toggleable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/semantics/FoundationSemanticsProperties.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ButtonTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CardTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CheckboxScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/RadioButtonScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ScaffoldTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SnackbarTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SurfaceTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ripple/RippleIndicationTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/textfield/TextFieldScreenshotTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/AppBar.kt
M ui/ui-material/src/main/java/androidx/ui/material/TextFieldImpl.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/AssertsTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/CallSemanticsActionTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ErrorMessagesTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/FindersTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/PrintToStringTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ScrollToTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/TextActionsTest.kt
M ui/ui-test/src/main/java/androidx/ui/test/Actions.kt
M ui/ui-test/src/main/java/androidx/ui/test/Filters.kt
M ui/ui-text/api/0.1.0-dev15.txt
M ui/ui-text/api/current.txt
M ui/ui-text/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-text/api/public_plus_experimental_current.txt
M ui/ui-text/api/restricted_0.1.0-dev15.txt
M ui/ui-text/api/restricted_current.txt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/CoreTextField.kt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/TextSemanticsProperties.kt

https://android-review.googlesource.com/1360099

ty...@gmail.com <ty...@gmail.com> #3May 17, 2018 02:46PM

Steps to reproduce
See the sample android project in the attachment: dropDownHorizontalOffset_repro.zip
Simply run the app. It will display a default spinner and a spinner with a vertical and horizontal dropdown offset applied. The vertical offset succeeds, the horizontal is fails.

Android bug report
Attached: bugreport-Pixel_2_API_27-2018-05-17-16-42-21-65850259-6d8f-4ea5-958e-cfde14c9d5d8

deleted

Restricted

0 B

deleted

Restricted

0 B

ku...@google.com <ku...@google.com> #4May 21, 2018 01:35PM

Thank you for reporting this issue. We have shared this with our product and engineering team and will update this issue with more information as it becomes available.

[Deleted User] <[Deleted User]> #5Feb 8, 2019 09:17AM

Hello. What is the status of this issue?

ad...@google.com <ad...@google.com> Oct 10, 2019 08:25AM

Reassigned to am...@google.com.

am...@google.com <am...@google.com> #6Oct 17, 2019 09:47AM

Status: Won't Fix (Obsolete)

The issue reported here has been fixed. Please check on the latest version and report back if the issue persists.

ru...@gmail.com <ru...@gmail.com> #7Oct 30, 2019 12:55AM

This issue was first entered in 2014 and it still persists...........

I wonder what version #6 is referring to, because I'm running my app on the latest and I still can see this problem.

Please, provide more info before changing the status!!!

na...@gmail.com <na...@gmail.com> #8Apr 21, 2022 07:07AM

Still not working. Tested on Google Pixel 4A Emulator latest API.

cl...@gmail.com <cl...@gmail.com> #9Jan 24, 2024 05:53PM

It's also not working here in an app with target and compile sdk 34 (tested on pixel 6 / sdk 34)