Fixed
Status Update
Comments
il...@google.com <il...@google.com>
al...@gmail.com <al...@gmail.com> #2
since these are in public API (:/) we need to do this in 1.2
jo...@gmail.com <jo...@gmail.com> #3
since it is already marked as deprecated, we can probably do it by now.
vy...@gmail.com <vy...@gmail.com> #4
Opening diff shortly
il...@google.com <il...@google.com> #5
Project: platform/frameworks/support
Branch: androidx-master-dev
commit d576cbdc911cba16638a44fd8223391a90a07ef7
Author: Mike Nakhimovich <digitalbuddha@users.noreply.github.com>
Date: Tue Aug 11 09:30:34 2020
[GH] Hide deprecated internal API.
## Proposed Changes
* `RoomDatabase.java` has protected `mCallbacks` field which is leaking in the API docs, we should @Hide it.
## Testing
Test: Ran unit tests locally
## Issues Fixed
Fixes: 76109329
This is an imported pull request fromhttps://github.com/androidx/androidx/pull/61 .
Resolves #61
Github-Pr-Head-Sha: 6440daa3a63752c7f9d5ba2a390248cd85bc634f
GitOrigin-RevId: fe92d8466a59b44b218b6ca3cbd57dcda17992f7
Change-Id: Id599cdf5b02b32bdae0166266fb7da967598fe92
A room/runtime/api/current.ignore
M room/runtime/api/current.txt
M room/runtime/api/public_plus_experimental_current.txt
M room/runtime/api/restricted_current.txt
M room/runtime/src/main/java/androidx/room/RoomDatabase.java
https://android-review.googlesource.com/1396827
Branch: androidx-master-dev
commit d576cbdc911cba16638a44fd8223391a90a07ef7
Author: Mike Nakhimovich <digitalbuddha@users.noreply.github.com>
Date: Tue Aug 11 09:30:34 2020
[GH] Hide deprecated internal API.
## Proposed Changes
* `RoomDatabase.java` has protected `mCallbacks` field which is leaking in the API docs, we should @Hide it.
## Testing
Test: Ran unit tests locally
## Issues Fixed
Fixes: 76109329
This is an imported pull request from
Resolves #61
Github-Pr-Head-Sha: 6440daa3a63752c7f9d5ba2a390248cd85bc634f
GitOrigin-RevId: fe92d8466a59b44b218b6ca3cbd57dcda17992f7
Change-Id: Id599cdf5b02b32bdae0166266fb7da967598fe92
A room/runtime/api/current.ignore
M room/runtime/api/current.txt
M room/runtime/api/public_plus_experimental_current.txt
M room/runtime/api/restricted_current.txt
M room/runtime/src/main/java/androidx/room/RoomDatabase.java
vy...@gmail.com <vy...@gmail.com> #6
Re #5
Ooohhh...
Yeah, that is what I was thinking but I wasn't sure.
Thanks.
Ooohhh...
Yeah, that is what I was thinking but I wasn't sure.
Thanks.
wk...@google.com <wk...@google.com>
wk...@google.com <wk...@google.com>
wk...@google.com <wk...@google.com> #7
Long and Boolean support will be coming in a future release.
I'll re-open this for the remaining requests for Parcelable and Serializable.
I'll re-open this for the remaining requests for Parcelable and Serializable.
wk...@google.com <wk...@google.com>
il...@google.com <il...@google.com> #8
Parcelable support has been added and will also be available in alpha03. The only defaultValue available will be @null (indicating a null value).
We strongly recommend using Parcelable over Serializable and won't be supporting Serializable in alpha03. We'll be tracking the additional feature request for Serializable over inhttps://issuetracker.google.com/issues/111316353
We strongly recommend using Parcelable over Serializable and won't be supporting Serializable in alpha03. We'll be tracking the additional feature request for Serializable over in
do...@arctouch.com <do...@arctouch.com> #9
I'm doing this:
<argument
android:name="latitude"
app:argType="Double"
android:defaultValue="@null"
app:nullable="true" />
And getting this error:
Caused by: java.lang.ClassNotFoundException:Double
What about Double?
<argument
android:name="latitude"
app:argType="Double"
android:defaultValue="@null"
app:nullable="true" />
And getting this error:
Caused by: java.lang.ClassNotFoundException:Double
What about Double?
il...@google.com <il...@google.com> #10
Doubles are not a supported format for Android XML values. You can use argType="float"
gv...@gmail.com <gv...@gmail.com> #11
I found out that it possible to use wrappers like this: (in release 1.0.0!)
<argument
android:name="amount"
app:argType="java.lang.Double" />
Why not use Serializable in that case?
<argument
android:name="amount"
app:argType="java.lang.Double" />
Why not use Serializable in that case?
ju...@hotmail.com <ju...@hotmail.com> #12
LocalDate is Serializable, so Im trying to use it with
app:argType="java.time.LocalDate"
and its giving me an error:
Caused by: java.lang.RuntimeException: java.lang.ClassNotFoundException: java.time.LocalDate
at androidx.navigation.NavType.fromArgType(NavType.java:181)
at androidx.navigation.NavInflater.inflateArgument(NavInflater.java:191)
Im using desugaring so ... may that be the reason??
app:argType="java.time.LocalDate"
and its giving me an error:
Caused by: java.lang.RuntimeException: java.lang.ClassNotFoundException: java.time.LocalDate
at androidx.navigation.NavType.fromArgType(NavType.java:181)
at androidx.navigation.NavInflater.inflateArgument(NavInflater.java:191)
Im using desugaring so ... may that be the reason??
il...@google.com <il...@google.com> #13
Re #12 - please star
Description
Version used: 1.0.0-alpha01
Devices/Android versions reproduced on: N/A
When specifying arguments for and a navigation action, there are only 4 options: "inferred, string, integer, reference"
Some arguments in my app use Boolean and Long and SafeArgs seem to only support "string" or "integer" (even if I manually put app:type="long"... it does not know what "long" is and falls back to "string")
Please add support for more types... especially Long and Boolean (you can "put" a lot more types into a Bundle)
I know I can manually add args to a bundle and then navigate... but I really want to use Directions from SafeArgs