Fixed
Status Update
No update yet.
Comments
su...@google.com
since these are in public API (:/) we need to do this in 1.2
ro...@gmail.com
since it is already marked as deprecated, we can probably do it by now.
su...@google.com
Opening diff shortly
ro...@gmail.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit d576cbdc911cba16638a44fd8223391a90a07ef7
Author: Mike Nakhimovich <digitalbuddha@users.noreply.github.com>
Date: Tue Aug 11 09:30:34 2020
[GH] Hide deprecated internal API.
## Proposed Changes
* `RoomDatabase.java` has protected `mCallbacks` field which is leaking in the API docs, we should @Hide it.
## Testing
Test: Ran unit tests locally
## Issues Fixed
Fixes: 76109329
This is an imported pull request fromhttps://github.com/androidx/androidx/pull/61 .
Resolves #61
Github-Pr-Head-Sha: 6440daa3a63752c7f9d5ba2a390248cd85bc634f
GitOrigin-RevId: fe92d8466a59b44b218b6ca3cbd57dcda17992f7
Change-Id: Id599cdf5b02b32bdae0166266fb7da967598fe92
A room/runtime/api/current.ignore
M room/runtime/api/current.txt
M room/runtime/api/public_plus_experimental_current.txt
M room/runtime/api/restricted_current.txt
M room/runtime/src/main/java/androidx/room/RoomDatabase.java
https://android-review.googlesource.com/1396827
Branch: androidx-master-dev
commit d576cbdc911cba16638a44fd8223391a90a07ef7
Author: Mike Nakhimovich <digitalbuddha@users.noreply.github.com>
Date: Tue Aug 11 09:30:34 2020
[GH] Hide deprecated internal API.
## Proposed Changes
* `RoomDatabase.java` has protected `mCallbacks` field which is leaking in the API docs, we should @Hide it.
## Testing
Test: Ran unit tests locally
## Issues Fixed
Fixes: 76109329
This is an imported pull request from
Resolves #61
Github-Pr-Head-Sha: 6440daa3a63752c7f9d5ba2a390248cd85bc634f
GitOrigin-RevId: fe92d8466a59b44b218b6ca3cbd57dcda17992f7
Change-Id: Id599cdf5b02b32bdae0166266fb7da967598fe92
A room/runtime/api/current.ignore
M room/runtime/api/current.txt
M room/runtime/api/public_plus_experimental_current.txt
M room/runtime/api/restricted_current.txt
M room/runtime/src/main/java/androidx/room/RoomDatabase.java
su...@google.com
Fair enough, I'll reopen the bug and add some more context. This may potentially be an argument in the onStopped method.
su...@google.com
This is fixed and will be available in alpha03.
Description
Version used: alpha01
WorkManager exposes method for cancellation of work. However, I currently don't see how this could be used if the work has already started.
Arguably, being able to cancel an ongoing work is very basic and must have functionality. Not being able to do so will render the entire framework unusable in many scenarios. It can also negatively impact the end users (e.g. by consuming too much battery/bandwidth).
Cancellation mechanism should be given a very good thought. As a starting point for a discussion, I propose adding two methods to Worker:
1) protected final boolean isCancelled() - will return true if the work has been cancelled
2) protected void onCancelled() - will be called after WorkManager determines that a specific Worker needs to be cancelled. Default implementation will be no-op.