Fixed
Status Update
Comments
su...@google.com <su...@google.com> #2
Building note: run ./gradlew ... -x processReleaseMetadata
ro...@gmail.com <ro...@gmail.com> #3
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 5f6e46e40a7e47924ac1d04426230466de7b6f38
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Tue Aug 07 15:57:10 2018
Fix ViewModel proguard rules
It removes allowshrinking modifier: a constructor
shouldn't be removed if it is unused, because it is
called through reflection
Test: manual =\
bug: 112230489
Change-Id: I215fe895fa12eb04172e9380a296e2d74567907c
M lifecycle/viewmodel/proguard-rules.pro
https://android-review.googlesource.com/727573
https://goto.google.com/android-sha1/5f6e46e40a7e47924ac1d04426230466de7b6f38
Branch: androidx-master-dev
commit 5f6e46e40a7e47924ac1d04426230466de7b6f38
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Tue Aug 07 15:57:10 2018
Fix ViewModel proguard rules
It removes allowshrinking modifier: a constructor
shouldn't be removed if it is unused, because it is
called through reflection
Test: manual =\
bug: 112230489
Change-Id: I215fe895fa12eb04172e9380a296e2d74567907c
M lifecycle/viewmodel/proguard-rules.pro
su...@google.com <su...@google.com> #4
Thanks!
ro...@gmail.com <ro...@gmail.com> #5
I had the similar problem. Hoping the problem will be fixed in the next release. Thank team!
Description
Version used: alpha01
WorkManager exposes method for cancellation of work. However, I currently don't see how this could be used if the work has already started.
Arguably, being able to cancel an ongoing work is very basic and must have functionality. Not being able to do so will render the entire framework unusable in many scenarios. It can also negatively impact the end users (e.g. by consuming too much battery/bandwidth).
Cancellation mechanism should be given a very good thought. As a starting point for a discussion, I propose adding two methods to Worker:
1) protected final boolean isCancelled() - will return true if the work has been cancelled
2) protected void onCancelled() - will be called after WorkManager determines that a specific Worker needs to be cancelled. Default implementation will be no-op.