Fixed
Status Update
Comments
se...@google.com <se...@google.com>
wk...@google.com <wk...@google.com>
il...@google.com <il...@google.com> #2
Hi. Thanks for reporting this. Fixed in alpha-04
th...@gmail.com <th...@gmail.com> #3
Project: platform/frameworks/support
Branch: androidx-main
commit e782987543a9f8ccd485e970ddc74564b24378db
Author: Vighnesh Raut <vighnesh.raut13@gmail.com>
Date: Mon Jan 02 15:27:40 2023
fix: tab row crashes when only 1 tab is added
Bug: b/264018028
Test: Added unit test
Change-Id: I6381dbac304fc1d69d3708c6655f8b595668e93f
M tv/tv-material/src/androidTest/java/androidx/tv/material/TabRowTest.kt
M tv/tv-material/src/main/java/androidx/tv/material/TabRow.kt
https://android-review.googlesource.com/2373449
Branch: androidx-main
commit e782987543a9f8ccd485e970ddc74564b24378db
Author: Vighnesh Raut <vighnesh.raut13@gmail.com>
Date: Mon Jan 02 15:27:40 2023
fix: tab row crashes when only 1 tab is added
Bug:
Test: Added unit test
Change-Id: I6381dbac304fc1d69d3708c6655f8b595668e93f
M tv/tv-material/src/androidTest/java/androidx/tv/material/TabRowTest.kt
M tv/tv-material/src/main/java/androidx/tv/material/TabRow.kt
wk...@google.com <wk...@google.com> #4
deleted
Description
Version used: 1.0.0-alpha-01
Devices/Android versions reproduced on: -
Safe args are a great enhancement for navigation. A great addition to that would be being able to define nullability for arguments. An example for how this would look like:
<argument android:name="id" app:type="string?"/>
(note the ? for the type) - an alternative would be to have another attribute - e.g. app:required="false" to make it less tied to Kotlin. The generated Args and NavDirections class would have the Nullable/NonNull annotations.
This would make it very obvious which arguments are required and which are optional - especially in Kotlin.