Fixed
Status Update
Comments
se...@google.com <se...@google.com>
wk...@google.com <wk...@google.com>
il...@google.com <il...@google.com> #2
A couple of questions:
1. Have you saw crash in real device or only in simulators?
2. Do you use dynamic feature for language ID?
1. Have you saw crash in real device or only in simulators?
2. Do you use dynamic feature for language ID?
th...@gmail.com <th...@gmail.com> #3
Tested on Android 12 Emulator with custom executor, but cannot repro this issue.
wk...@google.com <wk...@google.com> #4
-
Second crash in the description is from a real device. Experienced it myself on two different Xiaomi phones, plus lots of crashes from users in the Google Play console.
-
Dynamic features are not used in the application.
As a wild guess, I have downgraded build tools from 31.0.0 to 30.0.3, compileSdk from 31 to 30, and moved all work with Language ID to the service in a separate process (just to be sure that crash can kill secondary process instead of main). This combination is in beta for 2 days by now and I don't see any SIGSEGV crashes.
Description
Version used: 1.0.0-alpha-01
Devices/Android versions reproduced on: -
Safe args are a great enhancement for navigation. A great addition to that would be being able to define nullability for arguments. An example for how this would look like:
<argument android:name="id" app:type="string?"/>
(note the ? for the type) - an alternative would be to have another attribute - e.g. app:required="false" to make it less tied to Kotlin. The generated Args and NavDirections class would have the Nullable/NonNull annotations.
This would make it very obvious which arguments are required and which are optional - especially in Kotlin.