Change theme
Help
Press space for more information.
Show links for this issue (Shortcut: i, l)
Copy issue ID
Previous Issue (Shortcut: k)
Next Issue (Shortcut: j)
Sign in to use full features.
Vote: I am impacted
Notification menu
Refresh (Shortcut: Shift+r)
Go home (Shortcut: u)
Use Markdown for this comment
Set severity, which reflects how much the issue affects the use of the product
Change issue status back to 'Assigned'
Pending code changes (auto-populated)
[ID: 84651]
Story points rate the relative effort of work in a Fibonacci-like format: 0, 0.5, 1, 2, 3, 5, 8, 13, 20, 40, 100. Each team will estimate work on a slightly different scale, which means the values in this field are likely only meaningful to the team that owns the Buganizer component in which the issue resides.
See Atlassian's Agile Coach for more information on how to use story points for estimation: https://www.atlassian.com/agile/project-management/estimation [ID: 746686]
Set the version(s) of the product affected by this issue (comma-separated list)
Set the version(s) of the product in which the issue should be fixed (comma-separated list)
Set the version(s) of the product in which the issue fix was verified (comma-separated list)
Set if this issue occurs in production
[ID: 85206]
Set Reporter
Set Type
Set priority, which reflects how soon the issue should be fixed
Set Status
Set Assignee
Set Verifier
Remove item
View or edit staffing
View issue level access limits(Press Alt + Right arrow for more information)
Description
Version used: 1.0.0-alpha01
Devices/Android versions reproduced on: N/A
putAll(Map) javadoc states:
> Any non-valid types will be logged and ignored. Valid types are: Boolean, Integer, Long, Double, String, and array versions of
> each of those types.
However, the implementation does not log and ignore invalid types, it throws an exception:
} else {
throw new IllegalArgumentException(
String.format("Key %s has invalid type %s", key, valueType));
}
Additionally the note about `null` values is misleading (or wrong):
> Any {@code null} values will also be ignored.
But if the value is null, it actually explicitly puts null (which would overwrite the value if one previously existed):
if (value == null) {
mValues.put(key, null);
continue;
}
With the javadoc explaining that it will be ignored, I expect it not to remove a previously valid value from the map -- but current implementation will.
Data data = new Data.Builder()
.putString("Hello", "World")
.putAll(Collections.singletonMap("Hello", null))
.build();
// fails because ["Hello"] has been replaced with null => defaults to "none"
assertThat(data.getString("Hello", "none")).isEqualTo("World");