Fixed
Status Update
Comments
il...@google.com <il...@google.com>
il...@google.com <il...@google.com>
il...@google.com <il...@google.com> #2
The most common devices for the first crash sorted from highest to lowest:
Samsung S8 (5% of all crashes), S9 (4%), S8+ (4%), S10+ (3%), S9+ (3%), Huawei P20 Pro & Lite (9%)
The most common devices for the second crash:
HUAWEI Y6 2019 (38% of all crashes), HUAWEI Y5 2019 (17%), Nokia 3 (10%), Nokia 2.1 (9 %), Oppo realme 1 (5%)
The most common devices for the third crash:
Samsung Galaxy A5 (14% of all crashes). S7 Edge (9%), Spa Condor Electronics PGN610 (17% of all crashes)
Samsung S8 (5% of all crashes), S9 (4%), S8+ (4%), S10+ (3%), S9+ (3%), Huawei P20 Pro & Lite (9%)
The most common devices for the second crash:
HUAWEI Y6 2019 (38% of all crashes), HUAWEI Y5 2019 (17%), Nokia 3 (10%), Nokia 2.1 (9 %), Oppo realme 1 (5%)
The most common devices for the third crash:
Samsung Galaxy A5 (14% of all crashes). S7 Edge (9%), Spa Condor Electronics PGN610 (17% of all crashes)
[Deleted User] <[Deleted User]> #3
Crash 3 is a dupe of issue 138825362
dj...@gmail.com <dj...@gmail.com> #4
Which library version are you using?
ar...@gmail.com <ar...@gmail.com> #5
yeap, at least #1 was reported against the alpha here: https://stackoverflow.com/q/56358422/270197 - while the lib is now in beta
il...@google.com <il...@google.com> #6
#1 and #3 are definitely fixable in the support library. #2 can likely be resolved by the app checking BiometricManager#canAuthenticate() before requesting BiometricPrompt#authenticate().
For #1)
Looks like somehow the app is trying to display the dialog after onSaveInstanceState(), e.g. the activity/fragment is ending its lifecycle? Curtis perhaps we should do some lifecycle checks here.
For #2)
tranced.freak@ do you happen to know which devices are reporting this?
There is a chance the following is happening:
- device does not have fingerprint hardware
- app requests authenticate()
- hasSystemFeature(FP) fails, but invokes sendError
- sendError needs FPM to get error string.
A solution on the app side is to check BiometricManager#canAuthenticate() before requesting authentication. Is this something the app is already doing? We will focus this bug on #1 and #3 until we hear otherwise.
For #3)
Similar onSaveInstanceState issue
For #1)
Looks like somehow the app is trying to display the dialog after onSaveInstanceState(), e.g. the activity/fragment is ending its lifecycle? Curtis perhaps we should do some lifecycle checks here.
For #2)
tranced.freak@ do you happen to know which devices are reporting this?
There is a chance the following is happening:
- device does not have fingerprint hardware
- app requests authenticate()
- hasSystemFeature(FP) fails, but invokes sendError
- sendError needs FPM to get error string.
A solution on the app side is to check BiometricManager#canAuthenticate() before requesting authentication. Is this something the app is already doing? We will focus this bug on #1 and #3 until we hear otherwise.
For #3)
Similar onSaveInstanceState issue
Description
Version used: 1.0.0-alpha01
Devices/Android versions reproduced on: Pixel w Oreo
Two issues for the price of one!
According to the documentation, "When a user uses the Back button from a deep link destination, they navigate back up the navigation stack just as though they entered your app from the app’s entry point." (
I have a navigation graph which looks like [Home] -> [Articles List] -> [Specific Article]
I have a deeplink to [Specific Article]
<deepLink app:uri="
However when the app is opened via deeplink (adb shell am start -W -a android.intent.action.VIEW -d "
Following advice here (
[Home] -> Group([Articles List] -> [Specific Article])
However now deeplinking does not link to [Specific Article] at all! The app opens on [Articles List] with [Home] in the backstack.
I would expect either implementation to behave as per documentation, with the app deep linking to [Specific Article] with both [Articles List] and [Home] in the backstack.
--- Sample project ---
Attached is a sample project demonstrating both issues.
The nav graph is as follows:
[Home] -> [Article List] -> [Article (has deep link)]
\---> Group([Issue List] -> [Issue (has deep link)])
To deep link use the following commands.
Deep link to article:
adb shell am start -W -a android.intent.action.VIEW -d "
Deep link to issue inside group:
adb shell am start -W -a android.intent.action.VIEW -d "