Navigation w deeplink not forming backstack as expected [79734195]

Fixed

Bug

Status Update

No update yet.

Description

[Deleted User]

created issue #1

May 15, 2018 09:23PM

Component used: Navigation
Version used: 1.0.0-alpha01
Devices/Android versions reproduced on: Pixel w Oreo

Two issues for the price of one!

According to the documentation, "When a user uses the Back button from a deep link destination, they navigate back up the navigation stack just as though they entered your app from the app’s entry point." (

https://developer.android.com/topic/libraries/architecture/navigation/navigation-implementing#Deep-link)

I have a navigation graph which looks like [Home] -> [Articles List] -> [Specific Article]

I have a deeplink to [Specific Article]
<deepLink app:uri="

www.example.com/articles/{articleId}"/>

However when the app is opened via deeplink (adb shell am start -W -a android.intent.action.VIEW -d "

http://www.example.com/articles/456"), [Specific Article] is shown and only [Home] is in the backstack.

Following advice here (

https://stackoverflow.com/questions/50339826/android-navigation-library-deep-linking-how-to-synthesise-backstack) I created a group. My graph now looks like this.
[Home] -> Group([Articles List] -> [Specific Article])

However now deeplinking does not link to [Specific Article] at all! The app opens on [Articles List] with [Home] in the backstack.

I would expect either implementation to behave as per documentation, with the app deep linking to [Specific Article] with both [Articles List] and [Home] in the backstack.

--- Sample project ---
Attached is a sample project demonstrating both issues.

The nav graph is as follows:
[Home] -> [Article List] -> [Article (has deep link)]
\---> Group([Issue List] -> [Issue (has deep link)])

To deep link use the following commands.

Deep link to article:
adb shell am start -W -a android.intent.action.VIEW -d "

http://www.example.com/articles/456" com.example.deeplinkbackstackissue

Deep link to issue inside group:
adb shell am start -W -a android.intent.action.VIEW -d "

http://www.example.com/issues/456" com.example.deeplinkbackstackissue

DeeplinkBackstackIssue.zip

955 KB

Download

Comments

il...@google.com <il...@google.com> May 17, 2018 01:35AM

Assigned to il...@google.com.

il...@google.com <il...@google.com> May 21, 2018 08:37PM

Accepted by il...@google.com.

il...@google.com <il...@google.com> #2May 23, 2018 04:50PM

Marked as fixed.

+1, but Deferred does not solve the Observer problem that Rx and LiveData do, so I guess Google should implement Channels instead of LiveData which is actually a Kotlin Coroutine counterpart. Looking forward to this as I've decided not to use RxJava in most of future projects due to Kotlin Coroutines..

[Deleted User] <[Deleted User]> #3May 23, 2018 08:10PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit e78cceffeac28f0028342990c1391c640edf453c
Author: Daniel Santiago Rivera <danysantiago@google.com>
Date: Wed Nov 28 12:40:24 2018

Room Support for Coroutines

This change allows users to define suspend functions in DAOs with
@Query, @Insert, @Update and @Delete. The new artifact room-coroutine
defines a helper classes for supporting the feature.

Bug: 69474692
Test: ./gradlew room:integration-tests:kotlintestapp:cC
Change-Id: Id73a6b845df3f21f99d14cb6980130dcf3885c81

M buildSrc/src/main/kotlin/androidx/build/PublishDocsRules.kt
A room/compiler/src/main/kotlin/androidx/room/ext/KotlinMetadataElement.kt
D room/compiler/src/main/kotlin/androidx/room/ext/KotlinMetadataProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/ext/element_ext.kt
M room/compiler/src/main/kotlin/androidx/room/ext/javapoet_ext.kt
M room/compiler/src/main/kotlin/androidx/room/processor/DeletionMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/processor/InsertionMethodProcessor.kt
A room/compiler/src/main/kotlin/androidx/room/processor/MethodProcessorDelegate.kt
M room/compiler/src/main/kotlin/androidx/room/processor/PojoProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/processor/ProcessorErrors.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/processor/RawQueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/processor/ShortcutMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/processor/UpdateMethodProcessor.kt
A room/compiler/src/main/kotlin/androidx/room/solver/query/result/CoroutineResultBinder.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
A room/compiler/src/main/kotlin/androidx/room/solver/shortcut/binder/CoroutineDeleteOrUpdateMethodBinder.kt
A room/compiler/src/main/kotlin/androidx/room/solver/shortcut/binder/CoroutineInsertMethodBinder.kt
M room/compiler/src/main/kotlin/androidx/room/solver/shortcut/result/DeleteOrUpdateMethodAdapter.kt
M room/compiler/src/main/kotlin/androidx/room/solver/shortcut/result/InsertMethodAdapter.kt
M room/compiler/src/main/kotlin/androidx/room/vo/RelationCollector.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
A room/coroutines/build.gradle
A room/coroutines/src/main/AndroidManifest.xml
A room/coroutines/src/main/java/androidx/room/CoroutinesRoom.kt
M room/integration-tests/kotlintestapp/build.gradle
M room/integration-tests/kotlintestapp/src/androidTest/java/androidx/room/integration/kotlintestapp/dao/BooksDao.kt
M room/integration-tests/kotlintestapp/src/androidTest/java/androidx/room/integration/kotlintestapp/test/BooksDaoTest.kt
A room/integration-tests/kotlintestapp/src/androidTest/java/androidx/room/integration/kotlintestapp/test/SuspendRoomDispatcherTest.kt
M settings.gradle

https://android-review.googlesource.com/833705

https://goto.google.com/android-sha1/e78cceffeac28f0028342990c1391c640edf453c

dj...@gmail.com <dj...@gmail.com> #4Jun 12, 2018 10:27AM

So do you support any Coroutine "observables" like channels? Or these are just one-off suspending calls?

ar...@gmail.com <ar...@gmail.com> #5Sep 18, 2018 06:06PM

For now we'll be just supporting one-off suspend functions in Room 2.1.0-alpha03. Coroutines stream functionality with channels is still a work in progress.

il...@google.com <il...@google.com> #6Sep 18, 2018 08:44PM

Relating to the original request, how about allowing a return type of Deferred<LiveData<T>> which suspends until LiveData<T>'s value has been set the first time?