Fixed
Status Update
Comments
il...@google.com <il...@google.com>
il...@google.com <il...@google.com>
il...@google.com <il...@google.com> #2
Hi. Thanks for reporting this. Fixed in alpha-04
[Deleted User] <[Deleted User]> #3
Project: platform/frameworks/support
Branch: androidx-main
commit e782987543a9f8ccd485e970ddc74564b24378db
Author: Vighnesh Raut <vighnesh.raut13@gmail.com>
Date: Mon Jan 02 15:27:40 2023
fix: tab row crashes when only 1 tab is added
Bug: b/264018028
Test: Added unit test
Change-Id: I6381dbac304fc1d69d3708c6655f8b595668e93f
M tv/tv-material/src/androidTest/java/androidx/tv/material/TabRowTest.kt
M tv/tv-material/src/main/java/androidx/tv/material/TabRow.kt
https://android-review.googlesource.com/2373449
Branch: androidx-main
commit e782987543a9f8ccd485e970ddc74564b24378db
Author: Vighnesh Raut <vighnesh.raut13@gmail.com>
Date: Mon Jan 02 15:27:40 2023
fix: tab row crashes when only 1 tab is added
Bug:
Test: Added unit test
Change-Id: I6381dbac304fc1d69d3708c6655f8b595668e93f
M tv/tv-material/src/androidTest/java/androidx/tv/material/TabRowTest.kt
M tv/tv-material/src/main/java/androidx/tv/material/TabRow.kt
dj...@gmail.com <dj...@gmail.com> #4
deleted
ar...@gmail.com <ar...@gmail.com> #5
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.tv:tv-material:1.0.0-alpha04
il...@google.com <il...@google.com> #6
Re #5 - please file a new issue with a project that reproduces your issue.
Description
Version used: 1.0.0-alpha01
Devices/Android versions reproduced on: Pixel w Oreo
Two issues for the price of one!
According to the documentation, "When a user uses the Back button from a deep link destination, they navigate back up the navigation stack just as though they entered your app from the app’s entry point." (
I have a navigation graph which looks like [Home] -> [Articles List] -> [Specific Article]
I have a deeplink to [Specific Article]
<deepLink app:uri="
However when the app is opened via deeplink (adb shell am start -W -a android.intent.action.VIEW -d "
Following advice here (
[Home] -> Group([Articles List] -> [Specific Article])
However now deeplinking does not link to [Specific Article] at all! The app opens on [Articles List] with [Home] in the backstack.
I would expect either implementation to behave as per documentation, with the app deep linking to [Specific Article] with both [Articles List] and [Home] in the backstack.
--- Sample project ---
Attached is a sample project demonstrating both issues.
The nav graph is as follows:
[Home] -> [Article List] -> [Article (has deep link)]
\---> Group([Issue List] -> [Issue (has deep link)])
To deep link use the following commands.
Deep link to article:
adb shell am start -W -a android.intent.action.VIEW -d "
Deep link to issue inside group:
adb shell am start -W -a android.intent.action.VIEW -d "