Add a new onDestructiveMigrate() in Callback [79962330]

Fixed

Feature Request

Status Update

No update yet.

Description

su...@gmail.com

created issue #1

May 18, 2018 09:34AM

Component used: Room
Version used: 1.1.0
Devices/Android versions reproduced on: All

When we are working with Room database that contains predefined data, we can populate these predefined data when first creation of the database via Callback#onCreate(SupportSQLiteDatabase). If that project decided to fallback to destructive migration, all the predefined data will be delete during the migration and there is no way to notify if that happens so we can insert those predefined data.

My suggestion would be adding a new callback method e.g. onDestructiveMigrate(SupportSQLiteDatabase). Then notify the callback once migrated by destruction.

Comments

yb...@google.com <yb...@google.com> Aug 17, 2018 08:46PM

Assigned to da...@google.com.

fl...@google.com <fl...@google.com> Jul 12, 2019 10:13AM

Reassigned to fl...@google.com.

ap...@google.com <ap...@google.com> #2Jul 18, 2019 03:37PM

Project: platform/frameworks/support
Branch: androidx-main

commit c46d3e79b2ea8b839358f0215b0a432ef8fad7a2
Author: Clara Fok <clarafok@google.com>
Date: Fri Nov 04 15:23:25 2022

Convert androidx.activity.Cancellable to kotlin

Test: ./gradlew activity:activity:cC
Bug: 257291701
Change-Id: I057f3e54811e7399e40083ef5e3915adc4fa425d

M activity/activity/src/main/java/androidx/activity/Cancellable.kt

https://android-review.googlesource.com/2288554

fl...@google.com <fl...@google.com> Jul 19, 2019 08:48AM

Marked as fixed.

mi...@gmail.com <mi...@gmail.com> #3Oct 3, 2020 12:57PM

Project: platform/frameworks/support
Branch: androidx-main

commit 7fd8a3206a49baefee8340f0839fcd4de7716788
Author: Clara Fok <clarafok@google.com>
Date: Fri Nov 04 15:13:23 2022

Rename androidx.activity.Cancellable from .java to .kt

Test: n/a
Bug:257291701
Change-Id: I7f2ff8ce79af41c6437fb9a0f1be90e8990495e8

M activity/activity/src/main/java/androidx/activity/Cancellable.kt

https://android-review.googlesource.com/2288553

fe...@gmail.com <fe...@gmail.com> #4Feb 5, 2021 08:54PM

Project: platform/frameworks/support
Branch: androidx-main

commit 4d21e0a45f19ed238ef30756f576930af07449c2
Author: Clara Fok <clarafok@google.com>
Date: Fri Nov 04 13:25:08 2022

Convert ActivityResultCallback to kotlin

Including clean up in test usages of this interface

Test: ./gradlew activity:activity:cC
Bug: 257291701
Relnote: Converted ActvitiyResultCallback to kotlin. Maintains source and binary comptability.
Change-Id: Ifc5e5e1a9a7ed4e281007830fb8d4c74237c63ce

M activity/activity/api/current.txt
M activity/activity/api/public_plus_experimental_current.txt
M activity/activity/api/restricted_current.txt
M activity/activity/src/androidTest/java/androidx/activity/result/ActivityResultRegistryTest.kt
M activity/activity/src/main/java/androidx/activity/result/ActivityResultCallback.kt

https://android-review.googlesource.com/2288334

fe...@gmail.com <fe...@gmail.com> #5Feb 5, 2021 09:30PM

Project: platform/frameworks/support
Branch: androidx-main

commit ae5bcbc9174b9767f143bfd9629a69fcd3ed325d
Author: Clara Fok <clarafok@google.com>
Date: Fri Nov 04 13:06:36 2022

Rename ActivityResultCallback from .java to .kt

Test: n/a
Bug: 257291701
Change-Id: I43a8c76cb51e3eee4a1ec2cb6f0128753d85965d

M activity/activity/src/main/java/androidx/activity/result/ActivityResultCallback.kt

https://android-review.googlesource.com/2288333