Fixed
Status Update
No update yet.
Comments
il...@google.com
il...@google.com
wk...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit 9febd8ad6b63dc1738f11d52333e9ca116735a2e
Author: Jeremy Woods <jbwoods@google.com>
Date: Thu Jan 20 17:25:17 2022
Fix improper destination nesting with deep links
When deeplinking to a destination that has multiple nested nav_graphs,
the handleDeepLink() function will incorrectly remove the start
destinations of the parent NavGraphs when navigating to child graphs of
the parent.
What we really want is that you only pop and save destinations when
navigating to sibling graphs, not child graphs.
RelNote: "Intermediate start destinations will now be present when
deep linking through multiple nested `NavGraph`s."
Bug: 214383060
Test: tested in sample app in bug
Test: verified no regressions for other handleDeepLink cases
Change-Id: I504c04d2cc4381af22405266192ea0f5094f9c16
M navigation/navigation-runtime/src/main/java/androidx/navigation/NavController.kt
https://android-review.googlesource.com/1956592
Branch: androidx-main
commit 9febd8ad6b63dc1738f11d52333e9ca116735a2e
Author: Jeremy Woods <jbwoods@google.com>
Date: Thu Jan 20 17:25:17 2022
Fix improper destination nesting with deep links
When deeplinking to a destination that has multiple nested nav_graphs,
the handleDeepLink() function will incorrectly remove the start
destinations of the parent NavGraphs when navigating to child graphs of
the parent.
What we really want is that you only pop and save destinations when
navigating to sibling graphs, not child graphs.
RelNote: "Intermediate start destinations will now be present when
deep linking through multiple nested `NavGraph`s."
Bug: 214383060
Test: tested in sample app in bug
Test: verified no regressions for other handleDeepLink cases
Change-Id: I504c04d2cc4381af22405266192ea0f5094f9c16
M navigation/navigation-runtime/src/main/java/androidx/navigation/NavController.kt
wk...@google.com
wk...@google.com
ce...@gmail.com
This has been fixed internally and will be available in the Navigation 2.5.0-alpha02 and 2.4.1 releases.
Description
Version used: 1.0.0-alpha01
Minimal project that demonstrates issue:
Using Android Studio 3.2 Canary 15, I use the new project wizard to create an empty project and then to add an Android Library module.
When adding this line:
apply plugin: "androidx.navigation.safeargs"
to the library module's build.gradle, I get this error:
Caused by: org.gradle.api.GradleException: safeargs plugin must be used with android plugin
at androidx.navigation.safeargs.gradle.SafeArgsPlugin.apply(SafeArgsPlugin.kt:36)
at androidx.navigation.safeargs.gradle.SafeArgsPlugin.apply(SafeArgsPlugin.kt:32)
However, I don't get any errors when adding the same line to the app's build.gradle file.