IssueTracker

Project: platform/frameworks/support
Branch: androidx-master-dev

commit b55fe68edc02b253b908a1c7c2e98350ba67afe4
Author: Ian Lake <ilake@google.com>
Date:   Wed Aug 12 14:21:57 2020

    Ignore Animations/Animator when Transitions run
   
    For a given Fragment, a single owner for its
    transition from visible to non-visible is needed
    to avoid conflicts as different systems try to
    influence the same set of properties.
   
    This has two consequences:
    - Animations (which work at the parent container level)
    will interfere if there are *any* Transitions run.
    - Animators will interfere if there are any Transitions
    run on that specific Fragment.
   
    By tracking which Transitions were started and using
    that information to selectively ignore conflicting
    Animations/Animators, we can avoid visual artifacts.
   
    Test: updated tests pass
    BUG: 149569323
    Change-Id: I9e5169ffd36853c3dfbd7f217837a74674a9508d

M       fragment/fragment/src/androidTest/java/androidx/fragment/app/FragmentTransitionAnimTest.kt
M       fragment/fragment/src/main/java/androidx/fragment/app/DefaultSpecialEffectsController.java

https://android-review.googlesource.com/1398530

Project: platform/frameworks/support
Branch: androidx-master-dev

commit fa55358f7f2870bf05ef5cce12d2b4e2d86732aa
Author: Ian Lake <ilake@google.com>
Date:   Mon Sep 14 11:30:52 2020

    Ignore Animations when Animators run
   
    As a continuation of the work in b/149569323,
    we now prioritize running Animators over running
    Animations. This avoids cases where both are
    running simultaneously.
   
    As Animations and Animators are now properly
    decoupled, we can use animator.cancel() when
    our CancelationSignal is triggered instead of
    using clearAnimation().
   
    Test: all tests pass, updated FragmentAnimatorTest passes
    BUG: 167579557
    Change-Id: I7b3f5c1cc1355e02ff770838cb485d659dfb1619

M       fragment/fragment/src/androidTest/java/androidx/fragment/app/FragmentAnimatorTest.kt
M       fragment/fragment/src/main/java/androidx/fragment/app/DefaultSpecialEffectsController.java

https://android-review.googlesource.com/1427449

any updates on how to do this?

Any updates? Are we going to add this in lib?

I'm not sure if this is going to be added in the library. In the meantime you can find my implementation here.
https://gist.github.com/fbarthelery/ad0062a88875b46e0065137ff03807a0

It would truly be nice if the new tool for fixing navigation (which btw is fantastic) on the platform would support all of the standard top tier UI components. Looking forward to seeing how this goes.

Dialog fragments are now used in all modern applications and this is the last missing piece of puzzle to really switch everything to Navigation component.
Hope to see support for this soon enough.

Please, any update on this?

Sometime, there's need to display the previous fragment along with new fragment which is more of like a dialog. Therefore, it will be nice to have this feature in the next update.

This would be really useful, especially since Modal Bottom Sheets need to be implemented as BottomSheetDialogFragments.  It would be great to get all of our navigation into the navigation graph.

Project: platform/frameworks/support
Branch: androidx-master-dev

commit eec025be7822df951131cc0766b928383f58789e
Author: Ian Lake <ilake@google.com>
Date:   Mon Apr 22 14:51:05 2019

    Add support for <dialog> destinations
   
    Add support for using a DialogFragment as
    a destination in your navigation graph via
    the <dialog> tag.
   
    Test: added tests, tested in testapp
    BUG: 80267254
    Change-Id: I82daaa7bde4efe782095eee7b3932092e9086adb

M       navigation/fragment/api/2.1.0-alpha03.txt
M       navigation/fragment/api/current.txt
M       navigation/fragment/ktx/api/2.1.0-alpha03.txt
M       navigation/fragment/ktx/api/current.txt
A       navigation/fragment/ktx/src/androidTest/java/androidx/navigation/fragment/DialogFragmentNavigatorDestinationBuilderTest.kt
A       navigation/fragment/ktx/src/main/java/androidx/navigation/fragment/DialogFragmentNavigatorDestinationBuilder.kt
A       navigation/fragment/src/main/java/androidx/navigation/fragment/DialogFragmentNavigator.java
M       navigation/fragment/src/main/java/androidx/navigation/fragment/NavHostFragment.java
M       navigation/fragment/src/main/res/values/attrs.xml
A       navigation/integration-tests/testapp/src/main/java/androidx/navigation/testapp/LearnMoreDialogFragment.kt
M       navigation/integration-tests/testapp/src/main/java/androidx/navigation/testapp/MainFragment.kt
M       navigation/integration-tests/testapp/src/main/res/layout/main_fragment.xml
M       navigation/integration-tests/testapp/src/main/res/navigation/nav_main.xml
M       navigation/integration-tests/testapp/src/main/res/values/strings.xml

https://android-review.googlesource.com/949238
https://goto.google.com/android-sha1/eec025be7822df951131cc0766b928383f58789e

We've added support for dialog destinations internally, it'll be available in Navigation 2.1.0-alpha03

Awesome! Cheers guys

Are there any public test/demo applications one could use for reference?
Because the integration tests seem to be non public

https://stackoverflow.com/q/56647476/7972699

i have tried using dialog as destination it work's fine but when i navigate from dialog to fragment/dialog i am getting runtime error as NavController is missing.

i am using 2.1.0-alpha05

Very useful, fixed also.Cheers!