Fixed
Status Update
Comments
il...@google.com <il...@google.com>
ta...@gmail.com <ta...@gmail.com> #2
Hi. Thanks for reporting this. Fixed in alpha-04
jo...@gmail.com <jo...@gmail.com> #3
Project: platform/frameworks/support
Branch: androidx-main
commit e782987543a9f8ccd485e970ddc74564b24378db
Author: Vighnesh Raut <vighnesh.raut13@gmail.com>
Date: Mon Jan 02 15:27:40 2023
fix: tab row crashes when only 1 tab is added
Bug: b/264018028
Test: Added unit test
Change-Id: I6381dbac304fc1d69d3708c6655f8b595668e93f
M tv/tv-material/src/androidTest/java/androidx/tv/material/TabRowTest.kt
M tv/tv-material/src/main/java/androidx/tv/material/TabRow.kt
https://android-review.googlesource.com/2373449
Branch: androidx-main
commit e782987543a9f8ccd485e970ddc74564b24378db
Author: Vighnesh Raut <vighnesh.raut13@gmail.com>
Date: Mon Jan 02 15:27:40 2023
fix: tab row crashes when only 1 tab is added
Bug:
Test: Added unit test
Change-Id: I6381dbac304fc1d69d3708c6655f8b595668e93f
M tv/tv-material/src/androidTest/java/androidx/tv/material/TabRowTest.kt
M tv/tv-material/src/main/java/androidx/tv/material/TabRow.kt
[Deleted User] <[Deleted User]> #4
deleted
pr...@gmail.com <pr...@gmail.com> #5
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.tv:tv-material:1.0.0-alpha04
yp...@its.jnj.com <yp...@its.jnj.com> #6
Any updates? Are we going to add this in lib?
da...@gmail.com <da...@gmail.com> #7
I'm not sure if this is going to be added in the library. In the meantime you can find my implementation here.
https://gist.github.com/fbarthelery/ad0062a88875b46e0065137ff03807a0
hr...@gmail.com <hr...@gmail.com> #8
It would truly be nice if the new tool for fixing navigation (which btw is fantastic) on the platform would support all of the standard top tier UI components. Looking forward to seeing how this goes.
[Deleted User] <[Deleted User]> #9
Dialog fragments are now used in all modern applications and this is the last missing piece of puzzle to really switch everything to Navigation component.
Hope to see support for this soon enough.
Hope to see support for this soon enough.
wi...@gmail.com <wi...@gmail.com> #10
Please, any update on this?
um...@gmail.com <um...@gmail.com> #11
Sometime, there's need to display the previous fragment along with new fragment which is more of like a dialog. Therefore, it will be nice to have this feature in the next update.
ja...@gmail.com <ja...@gmail.com> #12
This would be really useful, especially since Modal Bottom Sheets need to be implemented as BottomSheetDialogFragments. It would be great to get all of our navigation into the navigation graph.
ap...@google.com <ap...@google.com> #13
Project: platform/frameworks/support
Branch: androidx-master-dev
commit eec025be7822df951131cc0766b928383f58789e
Author: Ian Lake <ilake@google.com>
Date: Mon Apr 22 14:51:05 2019
Add support for <dialog> destinations
Add support for using a DialogFragment as
a destination in your navigation graph via
the <dialog> tag.
Test: added tests, tested in testapp
BUG: 80267254
Change-Id: I82daaa7bde4efe782095eee7b3932092e9086adb
M navigation/fragment/api/2.1.0-alpha03.txt
M navigation/fragment/api/current.txt
M navigation/fragment/ktx/api/2.1.0-alpha03.txt
M navigation/fragment/ktx/api/current.txt
A navigation/fragment/ktx/src/androidTest/java/androidx/navigation/fragment/DialogFragmentNavigatorDestinationBuilderTest.kt
A navigation/fragment/ktx/src/main/java/androidx/navigation/fragment/DialogFragmentNavigatorDestinationBuilder.kt
A navigation/fragment/src/main/java/androidx/navigation/fragment/DialogFragmentNavigator.java
M navigation/fragment/src/main/java/androidx/navigation/fragment/NavHostFragment.java
M navigation/fragment/src/main/res/values/attrs.xml
A navigation/integration-tests/testapp/src/main/java/androidx/navigation/testapp/LearnMoreDialogFragment.kt
M navigation/integration-tests/testapp/src/main/java/androidx/navigation/testapp/MainFragment.kt
M navigation/integration-tests/testapp/src/main/res/layout/main_fragment.xml
M navigation/integration-tests/testapp/src/main/res/navigation/nav_main.xml
M navigation/integration-tests/testapp/src/main/res/values/strings.xml
https://android-review.googlesource.com/949238
https://goto.google.com/android-sha1/eec025be7822df951131cc0766b928383f58789e
Branch: androidx-master-dev
commit eec025be7822df951131cc0766b928383f58789e
Author: Ian Lake <ilake@google.com>
Date: Mon Apr 22 14:51:05 2019
Add support for <dialog> destinations
Add support for using a DialogFragment as
a destination in your navigation graph via
the <dialog> tag.
Test: added tests, tested in testapp
BUG: 80267254
Change-Id: I82daaa7bde4efe782095eee7b3932092e9086adb
M navigation/fragment/api/2.1.0-alpha03.txt
M navigation/fragment/api/current.txt
M navigation/fragment/ktx/api/2.1.0-alpha03.txt
M navigation/fragment/ktx/api/current.txt
A navigation/fragment/ktx/src/androidTest/java/androidx/navigation/fragment/DialogFragmentNavigatorDestinationBuilderTest.kt
A navigation/fragment/ktx/src/main/java/androidx/navigation/fragment/DialogFragmentNavigatorDestinationBuilder.kt
A navigation/fragment/src/main/java/androidx/navigation/fragment/DialogFragmentNavigator.java
M navigation/fragment/src/main/java/androidx/navigation/fragment/NavHostFragment.java
M navigation/fragment/src/main/res/values/attrs.xml
A navigation/integration-tests/testapp/src/main/java/androidx/navigation/testapp/LearnMoreDialogFragment.kt
M navigation/integration-tests/testapp/src/main/java/androidx/navigation/testapp/MainFragment.kt
M navigation/integration-tests/testapp/src/main/res/layout/main_fragment.xml
M navigation/integration-tests/testapp/src/main/res/navigation/nav_main.xml
M navigation/integration-tests/testapp/src/main/res/values/strings.xml
il...@google.com <il...@google.com> #14
We've added support for dialog destinations internally, it'll be available in Navigation 2.1.0-alpha03
gl...@gmail.com <gl...@gmail.com> #15
Awesome! Cheers guys
vr...@gmail.com <vr...@gmail.com> #16
Are there any public test/demo applications one could use for reference?
Because the integration tests seem to be non public
Because the integration tests seem to be non public
an...@gmail.com <an...@gmail.com> #17
i have tried using dialog as destination it work's fine but when i navigate from dialog to fragment/dialog i am getting runtime error as NavController is missing.
i am using 2.1.0-alpha05
ps...@gmail.com <ps...@gmail.com> #18
Very useful, fixed also.Cheers!
Description
Version used: 1.0.0-alpha01
Devices/Android versions reproduced on: -
Navigation to dialog fragments is not possible or not documented. It would be great to be able to navigate to dialog fragments using deep links.