IssueTracker

since these are in public API (:/) we need to do this in 1.2

Opening diff shortly

Project: platform/frameworks/support
Branch: androidx-master-dev

commit d576cbdc911cba16638a44fd8223391a90a07ef7
Author: Mike Nakhimovich <digitalbuddha@users.noreply.github.com>
Date:   Tue Aug 11 09:30:34 2020

    [GH] Hide deprecated internal API.
   
    ## Proposed Changes
   
    * `RoomDatabase.java` has protected `mCallbacks` field which is leaking in the API docs, we should @Hide it.
   
    ## Testing
   
    Test: Ran unit tests locally
   
    ## Issues Fixed
   
    Fixes: 76109329
   
    This is an imported pull request from https://github.com/androidx/androidx/pull/61.
   
    Resolves #61
    Github-Pr-Head-Sha: 6440daa3a63752c7f9d5ba2a390248cd85bc634f
    GitOrigin-RevId: fe92d8466a59b44b218b6ca3cbd57dcda17992f7
   
    Change-Id: Id599cdf5b02b32bdae0166266fb7da967598fe92

A       room/runtime/api/current.ignore
M       room/runtime/api/current.txt
M       room/runtime/api/public_plus_experimental_current.txt
M       room/runtime/api/restricted_current.txt
M       room/runtime/src/main/java/androidx/room/RoomDatabase.java

https://android-review.googlesource.com/1396827

Any updates? Are we going to add this in lib?

I'm not sure if this is going to be added in the library. In the meantime you can find my implementation here.
https://gist.github.com/fbarthelery/ad0062a88875b46e0065137ff03807a0

It would truly be nice if the new tool for fixing navigation (which btw is fantastic) on the platform would support all of the standard top tier UI components. Looking forward to seeing how this goes.

Dialog fragments are now used in all modern applications and this is the last missing piece of puzzle to really switch everything to Navigation component.
Hope to see support for this soon enough.

Please, any update on this?

Sometime, there's need to display the previous fragment along with new fragment which is more of like a dialog. Therefore, it will be nice to have this feature in the next update.

This would be really useful, especially since Modal Bottom Sheets need to be implemented as BottomSheetDialogFragments.  It would be great to get all of our navigation into the navigation graph.

Project: platform/frameworks/support
Branch: androidx-master-dev

commit eec025be7822df951131cc0766b928383f58789e
Author: Ian Lake <ilake@google.com>
Date:   Mon Apr 22 14:51:05 2019

    Add support for <dialog> destinations
   
    Add support for using a DialogFragment as
    a destination in your navigation graph via
    the <dialog> tag.
   
    Test: added tests, tested in testapp
    BUG: 80267254
    Change-Id: I82daaa7bde4efe782095eee7b3932092e9086adb

M       navigation/fragment/api/2.1.0-alpha03.txt
M       navigation/fragment/api/current.txt
M       navigation/fragment/ktx/api/2.1.0-alpha03.txt
M       navigation/fragment/ktx/api/current.txt
A       navigation/fragment/ktx/src/androidTest/java/androidx/navigation/fragment/DialogFragmentNavigatorDestinationBuilderTest.kt
A       navigation/fragment/ktx/src/main/java/androidx/navigation/fragment/DialogFragmentNavigatorDestinationBuilder.kt
A       navigation/fragment/src/main/java/androidx/navigation/fragment/DialogFragmentNavigator.java
M       navigation/fragment/src/main/java/androidx/navigation/fragment/NavHostFragment.java
M       navigation/fragment/src/main/res/values/attrs.xml
A       navigation/integration-tests/testapp/src/main/java/androidx/navigation/testapp/LearnMoreDialogFragment.kt
M       navigation/integration-tests/testapp/src/main/java/androidx/navigation/testapp/MainFragment.kt
M       navigation/integration-tests/testapp/src/main/res/layout/main_fragment.xml
M       navigation/integration-tests/testapp/src/main/res/navigation/nav_main.xml
M       navigation/integration-tests/testapp/src/main/res/values/strings.xml

https://android-review.googlesource.com/949238
https://goto.google.com/android-sha1/eec025be7822df951131cc0766b928383f58789e

We've added support for dialog destinations internally, it'll be available in Navigation 2.1.0-alpha03

Awesome! Cheers guys

Are there any public test/demo applications one could use for reference?
Because the integration tests seem to be non public

https://stackoverflow.com/q/56647476/7972699

i have tried using dialog as destination it work's fine but when i navigate from dialog to fragment/dialog i am getting runtime error as NavController is missing.

i am using 2.1.0-alpha05

Very useful, fixed also.Cheers!