IssueTracker

Project: platform/frameworks/support
Branch: androidx-master-dev

commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date:   Wed Sep 18 16:55:49 2019

    Change the way to detect mismatch between POJO and query
   
    This fixes cursor mismatch warnings with expandProjection.
   
    Bug: 140759491
    Test: QueryMethodProcessorTest
    Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8

M       room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M       room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M       room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M       room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M       room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt

https://android-review.googlesource.com/1123258
https://goto.google.com/android-sha1/b90079595f33f58fece04026a97faa0d243acdb1

  The following changes were cherrypicked through Coastguard (https://android-build.googleplex.com/coastguard/)
  Release Track: (https://android-build.googleplex.com/coastguard/dashboard/6093116828680192/#/cherrypickHistory/all)
  Created: 2019-10-14 17:23:42.610596+00:00
  Changes: aosp/1123258
 

Project: platform/frameworks/support
Branch: androidx-master-dev

commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date:   Thu Apr 16 16:47:05 2020

    Re-factor how errors are dismissed when query is re-written
   
    This CL changes how we handle errors/warnings if query is
    re-written.
    There was a bug in expandProjection where we would report warnings
    for things that Room already fixes automatically (b/140759491).
    The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
    solved it by deferring validating of columns until after re-write
    decision is made. Unfortunately, this required changing PojoRowAdapter
    to have a dummy mapping until it is validating, make it hard to use
    as it does have a non-null mapping which is not useful.
   
    This CL partially reverts that change and instead rely on the log
    deferring logic we have in Context. This way, we don't need to break
    the stability of PojoRowAdapter while still having the ability to
    drop warnings that room fixes. This will also play nicer when we
    have different query re-writing options that can use more information
    about the query results.
   
    Bug: 153387066
    Bug: 140759491
    Test: existing tests pass
    Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f

M       room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M       room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M       room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M       room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt

https://android-review.googlesource.com/1288456

any updates on how to do this?

Any updates? Are we going to add this in lib?

I'm not sure if this is going to be added in the library. In the meantime you can find my implementation here.
https://gist.github.com/fbarthelery/ad0062a88875b46e0065137ff03807a0

It would truly be nice if the new tool for fixing navigation (which btw is fantastic) on the platform would support all of the standard top tier UI components. Looking forward to seeing how this goes.

Dialog fragments are now used in all modern applications and this is the last missing piece of puzzle to really switch everything to Navigation component.
Hope to see support for this soon enough.

Please, any update on this?

Sometime, there's need to display the previous fragment along with new fragment which is more of like a dialog. Therefore, it will be nice to have this feature in the next update.

This would be really useful, especially since Modal Bottom Sheets need to be implemented as BottomSheetDialogFragments.  It would be great to get all of our navigation into the navigation graph.

Project: platform/frameworks/support
Branch: androidx-master-dev

commit eec025be7822df951131cc0766b928383f58789e
Author: Ian Lake <ilake@google.com>
Date:   Mon Apr 22 14:51:05 2019

    Add support for <dialog> destinations
   
    Add support for using a DialogFragment as
    a destination in your navigation graph via
    the <dialog> tag.
   
    Test: added tests, tested in testapp
    BUG: 80267254
    Change-Id: I82daaa7bde4efe782095eee7b3932092e9086adb

M       navigation/fragment/api/2.1.0-alpha03.txt
M       navigation/fragment/api/current.txt
M       navigation/fragment/ktx/api/2.1.0-alpha03.txt
M       navigation/fragment/ktx/api/current.txt
A       navigation/fragment/ktx/src/androidTest/java/androidx/navigation/fragment/DialogFragmentNavigatorDestinationBuilderTest.kt
A       navigation/fragment/ktx/src/main/java/androidx/navigation/fragment/DialogFragmentNavigatorDestinationBuilder.kt
A       navigation/fragment/src/main/java/androidx/navigation/fragment/DialogFragmentNavigator.java
M       navigation/fragment/src/main/java/androidx/navigation/fragment/NavHostFragment.java
M       navigation/fragment/src/main/res/values/attrs.xml
A       navigation/integration-tests/testapp/src/main/java/androidx/navigation/testapp/LearnMoreDialogFragment.kt
M       navigation/integration-tests/testapp/src/main/java/androidx/navigation/testapp/MainFragment.kt
M       navigation/integration-tests/testapp/src/main/res/layout/main_fragment.xml
M       navigation/integration-tests/testapp/src/main/res/navigation/nav_main.xml
M       navigation/integration-tests/testapp/src/main/res/values/strings.xml

https://android-review.googlesource.com/949238
https://goto.google.com/android-sha1/eec025be7822df951131cc0766b928383f58789e

We've added support for dialog destinations internally, it'll be available in Navigation 2.1.0-alpha03

Awesome! Cheers guys

Are there any public test/demo applications one could use for reference?
Because the integration tests seem to be non public

https://stackoverflow.com/q/56647476/7972699

i have tried using dialog as destination it work's fine but when i navigate from dialog to fragment/dialog i am getting runtime error as NavController is missing.

i am using 2.1.0-alpha05

Very useful, fixed also.Cheers!