Navigation clear task flag does work with activity destinations [80338878]

Fixed

Bug

Status Update

No update yet.

Description

[Deleted User]

created issue #1

May 27, 2018 03:35PM

When all the launch options are selected for a particular destination and the application is run, then the application crashes by throwing an IllegalArgumentException while navigating immediately between two destinations. But, the issue does not arise when only one or two launch options (in any combination) are selected.

DETAILS:-
The destination home is an activity with a NavHostFragment (FirstFragment.kt) which initially navigates to the second destination (SecondActivity.kt), then immediately comes back to the FirstFragment, and then navigates to third destination (FirstPopupFragment.kt). (Navigation can be observed in the attached screen-record).

LOG:-
2018-05-27 20:39:52.794 3289-3289/? E/AndroidRuntime: FATAL EXCEPTION: main
Process: com.example.cyrilnoah.navigationegapp, PID: 3289
java.lang.IllegalArgumentException: navigation destination com.example.cyrilnoah.navigationegapp:id/action_first_to_first_popup is unknown to this NavController
at androidx.navigation.NavController.navigate(NavController.java:605)
at androidx.navigation.NavController.navigate(NavController.java:565)
at androidx.navigation.NavController.navigate(NavController.java:553)
at com.example.cyrilnoah.navigationegapp.FirstFragment$onViewCreated$1.onClick(FirstFragment.kt:40)
at android.view.View.performClick(View.java:6579)
at android.view.View.performClickInternal(View.java:6556)
at android.view.View.access$3100(View.java:777)
at android.view.View$PerformClick.run(View.java:25660)
at android.os.Handler.handleCallback(Handler.java:819)
at android.os.Handler.dispatchMessage(Handler.java:99)
at android.os.Looper.loop(Looper.java:164)
at android.app.ActivityThread.main(ActivityThread.java:6656)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:438)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:823)

Component used:
"android.arch.navigation:navigation-fragment-ktx:$nav_version"
"android.arch.navigation:navigation-ui-ktx:$nav_version"

Version used:
nav_version = '1.0.0-alpha01'

Devices/Android versions reproduced on:
Tested on Pixel 2 XL (emulator), and Xiaomi Mi Max 2 (real device). Probably crashes on all, not so sure.

- Sample project to trigger the issue.
(Project attached below)

- A screenrecord or screenshots showing the issue (if UI related).
(Screen-record attached below)

Android Navigation Architecture - Bug 02.mov

28 MB

Download

NavigationExampleProject.zip

31 MB

Download

Comments

il...@google.com <il...@google.com> #2May 29, 2018 10:09PM

Assigned to il...@google.com.

Hi. Thanks for reporting this. Fixed in this changelist. This should be available in alpha-04

[Deleted User] <[Deleted User]> #3May 30, 2018 04:37PM

Project: platform/frameworks/support
Branch: androidx-main

commit e782987543a9f8ccd485e970ddc74564b24378db
Author: Vighnesh Raut <vighnesh.raut13@gmail.com>
Date: Mon Jan 02 15:27:40 2023

fix: tab row crashes when only 1 tab is added

Bug:

b/264018028

Test: Added unit test

Change-Id: I6381dbac304fc1d69d3708c6655f8b595668e93f

M tv/tv-material/src/androidTest/java/androidx/tv/material/TabRowTest.kt
M tv/tv-material/src/main/java/androidx/tv/material/TabRow.kt

https://android-review.googlesource.com/2373449

il...@google.com <il...@google.com> #4May 30, 2018 10:25PM

Marked as fixed.

deleted

il...@google.com <il...@google.com> #5May 30, 2018 10:26PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.tv:tv-material:1.0.0-alpha04

[Deleted User] <[Deleted User]> #6May 31, 2018 02:19AM

Hi. Thanks for the clarification. Looking forward to the next release. :)

lo...@gmail.com <lo...@gmail.com> #7Aug 13, 2018 04:04PM

I got a question regarding the removal of clearTask: originally I have been using clearTask to make sure prevent the user from going back to a splashFragment (see

https://stackoverflow.com/questions/50336112/how-to-disable-up-in-navigation-for-some-fragment-with-the-new-navigation-archit/50336319). What should I do instead to clear previous fragments from the stack?

mu...@gmail.com <mu...@gmail.com> #8Aug 13, 2018 06:35PM

The docs suggest "NavOptions.Builder setPopUpTo (int destinationId, boolean inclusive)"

https://developer.android.com/reference/androidx/navigation/NavOptions.Builder.html#setPopUpTo(int,%20boolean)

But I've not been able to make it work while using Kotlin.

[Deleted User] <[Deleted User]> #9Aug 31, 2018 08:07AM

Your destinationId in setPopUpTo need to be either id of the graph itself or better be id of the startDestination. You can also achieve this behavior with navigation graph xml attributes popUpTo and popUpToInclusive.

[Deleted User] <[Deleted User]> #10Sep 27, 2018 09:34AM

I'm trying to use popUpTo with popUpToInclusive exactly as instructed, and it works fine for normal actions. However, I can't get it to work for global actions! Clear Task used to work perfectly for global actions.

il...@google.com <il...@google.com> #11Sep 27, 2018 03:56PM

Re #10 - please file a new bug with a sample project that reproduces your issue.

[Deleted User] <[Deleted User]> #12Sep 28, 2018 10:33AM

Re #11 I created a new issue detailing my problem and containing a sample project here:

https://issuetracker.google.com/issues/116831650

IssueTracker