Fixed
Status Update
No update yet.
Comments
il...@google.com
Converting placeholders into arguments is the documented behavior: https://developer.android.com/reference/androidx/navigation/NavDestination.html#addDeepLink(java.lang.String)
What's missing is that NavDestination doesn't have any API for reading in types or applying that to deep links. We should move that logic from NavInflater to NavDestination so that both XML inflated NavDestinations and programmatically constructed NavDestinations have access to that type information.
What's missing is that NavDestination doesn't have any API for reading in types or applying that to deep links. We should move that logic from NavInflater to NavDestination so that both XML inflated NavDestinations and programmatically constructed NavDestinations have access to that type information.
[Deleted User] <[Deleted User]>
no impact to nav editor, right?
il...@google.com
No impact on the nav editor, but we should try to fix this before beta since this will impact developers parsing the arguments from deep links (ideally, they can use the same Args class).
il...@google.com
This has been fixed in https://android-review.googlesource.com/835484 and will be available in Navigation 1.0.0-alpha09
[Deleted User] <[Deleted User]>
Hi. Thanks for the clarification. Looking forward to the next release. :)
lo...@gmail.com
I got a question regarding the removal of clearTask: originally I have been using clearTask to make sure prevent the user from going back to a splashFragment (see https://stackoverflow.com/questions/50336112/how-to-disable-up-in-navigation-for-some-fragment-with-the-new-navigation-archit/50336319 ). What should I do instead to clear previous fragments from the stack?
mu...@gmail.com
[Deleted User] <[Deleted User]>
Your destinationId in setPopUpTo need to be either id of the graph itself or better be id of the startDestination. You can also achieve this behavior with navigation graph xml attributes popUpTo and popUpToInclusive.
[Deleted User] <[Deleted User]>
I'm trying to use popUpTo with popUpToInclusive exactly as instructed, and it works fine for normal actions. However, I can't get it to work for global actions! Clear Task used to work perfectly for global actions.
il...@google.com
Re #10 - please file a new bug with a sample project that reproduces your issue.
[Deleted User] <[Deleted User]>
Re #11 I created a new issue detailing my problem and containing a sample project here: https://issuetracker.google.com/issues/116831650
h....@gmail.com
ok
Description
DETAILS:-
The destination home is an activity with a NavHostFragment (FirstFragment.kt) which initially navigates to the second destination (SecondActivity.kt), then immediately comes back to the FirstFragment, and then navigates to third destination (FirstPopupFragment.kt). (Navigation can be observed in the attached screen-record).
LOG:-
2018-05-27 20:39:52.794 3289-3289/? E/AndroidRuntime: FATAL EXCEPTION: main
Process: com.example.cyrilnoah.navigationegapp, PID: 3289
java.lang.IllegalArgumentException: navigation destination com.example.cyrilnoah.navigationegapp:id/action_first_to_first_popup is unknown to this NavController
at androidx.navigation.NavController.navigate(NavController.java:605)
at androidx.navigation.NavController.navigate(NavController.java:565)
at androidx.navigation.NavController.navigate(NavController.java:553)
at com.example.cyrilnoah.navigationegapp.FirstFragment$onViewCreated$1.onClick(FirstFragment.kt:40)
at android.view.View.performClick(View.java:6579)
at android.view.View.performClickInternal(View.java:6556)
at android.view.View.access$3100(View.java:777)
at android.view.View$PerformClick.run(View.java:25660)
at android.os.Handler.handleCallback(Handler.java:819)
at android.os.Handler.dispatchMessage(Handler.java:99)
at android.os.Looper.loop(Looper.java:164)
at android.app.ActivityThread.main(ActivityThread.java:6656)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:438)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:823)
Component used:
"android.arch.navigation:navigation-fragment-ktx:$nav_version"
"android.arch.navigation:navigation-ui-ktx:$nav_version"
Version used:
nav_version = '1.0.0-alpha01'
Devices/Android versions reproduced on:
Tested on Pixel 2 XL (emulator), and Xiaomi Mi Max 2 (real device). Probably crashes on all, not so sure.
- Sample project to trigger the issue.
(Project attached below)
- A screenrecord or screenshots showing the issue (if UI related).
(Screen-record attached below)