Status Update
No update yet.
Comments
mo...@google.com
va...@gmail.com
Makes sense, thanks for reporting this, I'll send a fix soon.
va...@gmail.com
Branch: androidx-main
commit ed9cc5573271288500a7f416520dc509d8047f0f
Author: Daniel Santiago Rivera <danysantiago@google.com>
Date: Thu Aug 08 13:41:08 2024
Use same visibility as expect declaration when generating RoomDatabaseConstructor
Bug: 358138953
Test: DatabaseObjectConstructorWriterKotlinCodeGenTest
Change-Id: I0b2bb1a590f48199e398f72ac2b881e1eceb571f
M room/integration-tests/multiplatformtestapp/src/commonTest/kotlin/androidx/room/integration/multiplatformtestapp/test/BaseMigrationTest.kt
M room/room-compiler/src/main/kotlin/androidx/room/writer/DatabaseObjectConstructorWriter.kt
M room/room-compiler/src/test/kotlin/androidx/room/writer/DatabaseObjectConstructorWriterKotlinCodeGenTest.kt
A room/room-compiler/src/test/test-data/kotlinCodeGen/actualDatabaseConstructor_internal.kt
ch...@google.com
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.room:room-compiler:2.7.0-alpha07
ze...@gmail.com
va...@gmail.com
Gotcha, tried lambda version { viewModel.increment() } but that too ends up recomposing MyButton. viewModel instance is the same on recomposition
@Composable
fun Counter() {
val viewModel = viewModel<TestViewModel>()
val counter by viewModel.counterFlow.collectAsStateWithLifecycle()
Log.e("Compose", "Counter Recomposed")
Column(modifier = Modifier.fillMaxSize()) {
Text("$counter")
MyButton("Increment Counter", { viewModel.increment() })
}
}
ch...@google.com
The TestViewModel is not inferred or marked @Stable so it will always generate a new instance of the lambda.
The reason is that the StateFlow is not stable so we don't infer the type as stable so adding @Stable to the type is required.
We are experimenting with changing the stability rules as this is admittedly very confusing. With the new rules the @Stable would not be necessary.
va...@gmail.com
Thanks. Yes, any improvement over here is much appreciated.
ch...@google.com
I am marking this bug "as intended" as this is the behavior we intended and we are tracking the feature to add memoizing method references and "strong skipping mode" separately.
ch...@google.com
Definitely would love to support this but it requires help from the Kotlin compiler team which is currently heads down on shipping K2.
Description
Jetpack Compose component(s) used:
Android Studio Build:
Kotlin version:
Steps to Reproduce or Code Sample to Reproduce:
See
In short: when updating from Compose 1.1.1 to Compose 1.4.1 (or 1.4.0), when using a method reference instead of a lambda, composables are still recomposed instead of skipped.
To reproduce:
- Clone the repository
- Start the application
- Click a couple of times on the 'ViewModel Lambda Test' button which adds a name to the end of the names above the button
- Notice that all names are recomposed. This is expected because the lambda is not stable.
- Now click a couple of times on the Method Reference Test which add names above that button
- Notice that all names are recomposed as well. I would not expect this since the method reference is stable
- The Remembered Lambda Button behaves as expected where only the name that is added is composes. The other names are skipped.