Connect deep link parameters and arguments in a type safe way [110273284]

Fixed

Feature Request

Status Update

No update yet.

Description

wk...@google.com

created issue #1

Jun 15, 2018 10:13PM

Currently it seems like passing parameters through a URL into a destination is a work in progress. It kinda works if you name the URL parameter the same as an argument, but it's not documented and it will only work with a string-type argument, as that's what will be parsed from a URL.

It would be great to have a well-defined, documented and supported way of passing data from a deep link URL to a destination as an argument, with type safety provided by safeargs.

Comments

il...@google.com <il...@google.com> Jun 20, 2018 05:38PM

Assigned to il...@google.com.

il...@google.com <il...@google.com> #2Jul 13, 2018 10:37PM

Project: platform/frameworks/support
Branch: androidx-main
Author: Jeremy Woods <jbwoods@google.com>
Link: https://android-review.googlesource.com/3531312

Convert navigation-testing to KMP

Expand for full commit details

Convert navigation-testing to KMP 
 
Moving the navigation-testing module to KMP. This supports all the same 
platforms as the rest of Navigation and has converted all uses of Bundle 
to the new SaveState. 
 
RelNote: "Navigation Testing is now a KMP module." 
Test: all tests pass 
Bug: 398265336 
Change-Id: I2b7707a56f263be30420cae57e3b38480d7f0625

Files:

M docs-tip-of-tree/build.gradle
A navigation/navigation-testing/bcv/native/current.txt
M navigation/navigation-testing/build.gradle
M navigation/navigation-testing/src/androidInstrumentedTest/AndroidManifest.xml
M navigation/navigation-testing/src/androidInstrumentedTest/kotlin/androidx/navigation/testing/TestNavHostControllerTest.kt
M navigation/navigation-testing/src/androidInstrumentedTest/kotlin/androidx/navigation/testing/TestNavigatorStateTest.kt
M navigation/navigation-testing/src/androidInstrumentedTest/res/navigation/test_graph.xml
M navigation/navigation-testing/src/androidMain/AndroidManifest.xml
M navigation/navigation-testing/src/androidMain/kotlin/androidx/navigation/testing/TestNavHostController.android.kt
M navigation/navigation-testing/src/androidMain/kotlin/androidx/navigation/testing/TestNavigatorState.android.kt
A navigation/navigation-testing/src/androidUnitTest/kotlin/androidx/navigation/testing/RobolectricTest.android.kt
M navigation/navigation-testing/src/androidUnitTest/kotlin/androidx/navigation/testing/TestSavedStateHandleFactory.kt
A navigation/navigation-testing/src/commonMain/kotlin/androidx/navigation/testing/SavedStateHandleFactory.kt
M navigation/navigation-testing/src/commonMain/kotlin/androidx/navigation/testing/TestNavigatorProvider.kt
D navigation/navigation-testing/src/main/AndroidManifest.xml
D navigation/navigation-testing/src/main/java/androidx/navigation/testing/SavedStateHandleFactory.kt

Hash: 31ae4c7ebb13918db0e022b19246b7a47755ac65
Date: Fri Mar 07 09:11:14 2025

wk...@google.com <wk...@google.com> Jul 17, 2018 03:08PM

Reassigned to wk...@google.com.

wk...@google.com <wk...@google.com> Jul 23, 2018 11:41AM

Accepted by wk...@google.com.

be...@google.com <be...@google.com> #3Jul 23, 2018 08:49PM

Project: platform/frameworks/support
Branch: androidx-main
Author: Jeremy Woods <jbwoods@google.com>
Link: https://android-review.googlesource.com/3545603

Implement jvmTest for navigation-testing

Expand for full commit details

Implement jvmTest for navigation-testing 
 
Adding a copy of TestSavedStateHandleFactory to jvmCommonTest to ensure 
that is runs on all nonAndroid platforms. 
 
The `nullLiteralArgument` and `emptyStringArgument` tests are expected 
to fail as they require the encoding and decoding the types which is 
behavior only supported on the jetbrains fork. 
 
Test: added tests 
Bug: 398265336 
Change-Id: I4c1dcfb697d6e9e16995b249b9a8351bd925e0f3

Files:

M navigation/navigation-testing/build.gradle
A navigation/navigation-testing/src/jvmCommonTest/kotlin/androidx/navigation/testing/TestSavedStateHandleFactory.kt

Hash: 139d2423c7625f19ececc94b2df5bfde24e2cf95
Date: Fri Mar 14 23:48:06 2025

il...@google.com <il...@google.com> #4Sep 14, 2018 11:34PM

No impact on the nav editor, but we should try to fix this before beta since this will impact developers parsing the arguments from deep links (ideally, they can use the same Args class).

il...@google.com <il...@google.com> #5Dec 11, 2018 06:14PM

Marked as fixed.

This has been fixed in

https://android-review.googlesource.com/835484 and will be available in Navigation 1.0.0-alpha09