Fixed
Status Update
No update yet.
Comments
su...@google.com
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 80c8907809c42e53332740c692b032c5d3279aa8
Author: husaynhakeem <husaynhakeem@google.com>
Date: Thu Sep 03 11:57:35 2020
Fail fast and notify user if image capture destination is invalid
This CL verifies the image save destination is valid and can be written to before triggering the image capture pipeline. This prevents taking a picture if the capture result cannot be saved.
Bug:
Test: ImageSaveLocationValidatorTest.kt
Change-Id: Ic61cda8781d028162ef98ba74d12f0ff872eb211
M camera/camera-core/src/main/java/androidx/camera/core/ImageCapture.java
A camera/camera-core/src/main/java/androidx/camera/core/ImageSaveLocationValidator.java
A camera/camera-core/src/test/java/androidx/camera/core/ImageSaveLocationValidatorTest.java
https://android-review.googlesource.com/1419729
https://goto.google.com/android-sha1/80c8907809c42e53332740c692b032c5d3279aa8
Branch: androidx-master-dev
commit 80c8907809c42e53332740c692b032c5d3279aa8
Author: husaynhakeem <husaynhakeem@google.com>
Date: Thu Sep 03 11:57:35 2020
Fail fast and notify user if image capture destination is invalid
This CL verifies the image save destination is valid and can be written to before triggering the image capture pipeline. This prevents taking a picture if the capture result cannot be saved.
Bug:
Test: ImageSaveLocationValidatorTest.kt
Change-Id: Ic61cda8781d028162ef98ba74d12f0ff872eb211
M camera/camera-core/src/main/java/androidx/camera/core/ImageCapture.java
A camera/camera-core/src/main/java/androidx/camera/core/ImageSaveLocationValidator.java
A camera/camera-core/src/test/java/androidx/camera/core/ImageSaveLocationValidatorTest.java
Description
Version used: 1.0.0-beta02
Devices/Android versions reproduced on: Nexus 5X API 28 Emulator (28.1.3-5243232) and Samsung J5 phone with 8.1.0
Steps to reproduce:
- Run application, monitoring logcat
- Press Enqueue
- Toast will be displayed and the log should indicate the worker started, failed and requested a retry
- Monitor the logcat for a few minutes and observe that no worker has been retried
This is intermittent but happens 90% of the time. If the Worker does retry, hit Enqueue again and it will likely fail to retry the new worker.
Expected Behaviour:
The worker should be retried after 10 seconds and up to 5 times in total before failing.