Fixed
Status Update
No update yet.
Comments
je...@google.com
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 80c8907809c42e53332740c692b032c5d3279aa8
Author: husaynhakeem <husaynhakeem@google.com>
Date: Thu Sep 03 11:57:35 2020
Fail fast and notify user if image capture destination is invalid
This CL verifies the image save destination is valid and can be written to before triggering the image capture pipeline. This prevents taking a picture if the capture result cannot be saved.
Bug:
Test: ImageSaveLocationValidatorTest.kt
Change-Id: Ic61cda8781d028162ef98ba74d12f0ff872eb211
M camera/camera-core/src/main/java/androidx/camera/core/ImageCapture.java
A camera/camera-core/src/main/java/androidx/camera/core/ImageSaveLocationValidator.java
A camera/camera-core/src/test/java/androidx/camera/core/ImageSaveLocationValidatorTest.java
https://android-review.googlesource.com/1419729
https://goto.google.com/android-sha1/80c8907809c42e53332740c692b032c5d3279aa8
Branch: androidx-master-dev
commit 80c8907809c42e53332740c692b032c5d3279aa8
Author: husaynhakeem <husaynhakeem@google.com>
Date: Thu Sep 03 11:57:35 2020
Fail fast and notify user if image capture destination is invalid
This CL verifies the image save destination is valid and can be written to before triggering the image capture pipeline. This prevents taking a picture if the capture result cannot be saved.
Bug:
Test: ImageSaveLocationValidatorTest.kt
Change-Id: Ic61cda8781d028162ef98ba74d12f0ff872eb211
M camera/camera-core/src/main/java/androidx/camera/core/ImageCapture.java
A camera/camera-core/src/main/java/androidx/camera/core/ImageSaveLocationValidator.java
A camera/camera-core/src/test/java/androidx/camera/core/ImageSaveLocationValidatorTest.java
Description
In the worst case it can make it very hard to scroll in the perpendicular direction of the direction in which pre-scroll is consumed, because as soon as pre scroll starts consuming, nested scrolling (should) lock the scroll in that direction.