BiometricPrompt is not hiding if error code is different than ERROR_CANCELED or BiometricPrompt.ERROR_LOCKOUT [143683687]

Fixed

Bug

Status Update

No update yet.

Description

te...@gmail.com

created issue #1

Oct 31, 2019 04:08PM

BUILD INFO
- Device type:
- OS version:
- Biometric library version: 1.0.0-rc02

STEPS TO REPRODUCE
[Be as specific as possible please]
Write robolectric test
1. Show BiometricPrompt
2. Invoke onAuthenticationError(BiometricPrompt.ERROR_HW_UNAVAILABLE, "some message")

EXPECTED RESULTS
prompt should be dismissed because no further authentication can take place

OBSERVED RESULTS
prompt is not dismissed

Comments

cu...@google.com <cu...@google.com> Oct 31, 2019 07:20PM

Reassigned to cu...@google.com.

cu...@google.com <cu...@google.com> #2Nov 1, 2019 11:35PM

Some more context regarding this issue: https://stackoverflow.com/questions/73417527/android-emulator-initial-network-call-delayed-by-several-seconds/

It's happening on 31.3.10. Reverting to 31.2.10 fixes the problem.

te...@gmail.com <te...@gmail.com> #3Nov 4, 2019 09:43AM

Ignore.

cu...@google.com <cu...@google.com> Nov 5, 2019 11:58PM

Accepted by cu...@google.com.

ap...@google.com <ap...@google.com> #4Nov 6, 2019 05:25PM

Marked as fixed.

It seems like we can repro the issue with embedded emulator. I used a stopwatch to record how long it takes for Google Sign-In page to load for the first time.

1, stand-alone emulator version (31.3.10): 4 seconds

2, embedded emulator (31.3.10): 15 seconds.

I am using Windows 10 with Intel Core i7-11850H@ 2.50GHz with 32GB RAM.

an...@google.com <an...@google.com> #5Nov 26, 2019 06:07PM

Ranjit is also able to repro the issue on Windows with Intel CPU. The problem is essentially in the first network connection. I asked Ranjit to help me with bisection mentioned in #3.

Issue 143683687