Fixed
Status Update
No update yet.
Comments
cu...@google.com
cu...@google.com
Removing from wednesday's list for now since there have been no reports.
te...@gmail.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit d02b8afc951f6a9e0fc8e24e19e56a06f1f60fac
Author: Curtis Belmonte <curtislb@google.com>
Date: Wed Sep 11 14:33:54 2019
Tolerate null result in BiometricPrompt fragments
The AndroidX BiometricPrompt API for onAuthenticationSucceeded requires
a non-null AuthenticationResult, so we construct one from the platform
BiometricPrompt or FingerprintManagerCompat result in BiometricFragment
and FingerprintHelperFragment, respectively, when calling this method.
However, the platform API does not guarantee that the result it provides
will be non-null, in which case the current implementation would crash.
This commit fixes the issue by creating an AuthenticationResult with
null crypto when handling a null result in either of these places. It
also adds unit tests to verify the new behavior.
Test: ./gradlew biometric:connectedAndroidTest
Fixes: 138862251
Change-Id: I540dd3b4ebdf100553b4fac609f3d928ec69ebfb
A biometric/src/androidTest/java/androidx/biometric/BiometricFragmentTest.java
A biometric/src/androidTest/java/androidx/biometric/FingerprintHelperFragmentTest.java
M biometric/src/main/java/androidx/biometric/BiometricFragment.java
M biometric/src/main/java/androidx/biometric/FingerprintHelperFragment.java
https://android-review.googlesource.com/1122743
https://goto.google.com/android-sha1/d02b8afc951f6a9e0fc8e24e19e56a06f1f60fac
Branch: androidx-master-dev
commit d02b8afc951f6a9e0fc8e24e19e56a06f1f60fac
Author: Curtis Belmonte <curtislb@google.com>
Date: Wed Sep 11 14:33:54 2019
Tolerate null result in BiometricPrompt fragments
The AndroidX BiometricPrompt API for onAuthenticationSucceeded requires
a non-null AuthenticationResult, so we construct one from the platform
BiometricPrompt or FingerprintManagerCompat result in BiometricFragment
and FingerprintHelperFragment, respectively, when calling this method.
However, the platform API does not guarantee that the result it provides
will be non-null, in which case the current implementation would crash.
This commit fixes the issue by creating an AuthenticationResult with
null crypto when handling a null result in either of these places. It
also adds unit tests to verify the new behavior.
Test: ./gradlew biometric:connectedAndroidTest
Fixes: 138862251
Change-Id: I540dd3b4ebdf100553b4fac609f3d928ec69ebfb
A biometric/src/androidTest/java/androidx/biometric/BiometricFragmentTest.java
A biometric/src/androidTest/java/androidx/biometric/FingerprintHelperFragmentTest.java
M biometric/src/main/java/androidx/biometric/BiometricFragment.java
M biometric/src/main/java/androidx/biometric/FingerprintHelperFragment.java
cu...@google.com
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit d3452de146b3ecd2173550fcbe2271d98c536f3f
Author: Curtis Belmonte <curtislb@google.com>
Date: Fri Nov 01 16:36:09 2019
Ensure fingerprint dialog always dismissed on error
Currently, if FingerprintHelperFragment receives an error other than
ERROR_CANCELED or ERROR_LOCKOUT/ERROR_LOCKOUT_PERMANENT, it fails to
trigger the error callback to dismiss the dialog before the helper
fragment is cleaned up. This commit fixes this issue by moving the call
to cleanup() into the Runnable that's posted in this case. It also adds
a test case to FingerprintHelperFragmentTest to exercise this behavior.
Test: ./gradlew biometric:connectedAndroidTest
Fixes: 143683687
Change-Id: Ibe1ef02dd64e3fe2dac11496560241a1a3e7b735
M biometric/src/androidTest/java/androidx/biometric/FingerprintHelperFragmentTest.java
M biometric/src/main/java/androidx/biometric/FingerprintHelperFragment.java
https://android-review.googlesource.com/1159086
Branch: androidx-master-dev
commit d3452de146b3ecd2173550fcbe2271d98c536f3f
Author: Curtis Belmonte <curtislb@google.com>
Date: Fri Nov 01 16:36:09 2019
Ensure fingerprint dialog always dismissed on error
Currently, if FingerprintHelperFragment receives an error other than
ERROR_CANCELED or ERROR_LOCKOUT/ERROR_LOCKOUT_PERMANENT, it fails to
trigger the error callback to dismiss the dialog before the helper
fragment is cleaned up. This commit fixes this issue by moving the call
to cleanup() into the Runnable that's posted in this case. It also adds
a test case to FingerprintHelperFragmentTest to exercise this behavior.
Test: ./gradlew biometric:connectedAndroidTest
Fixes: 143683687
Change-Id: Ibe1ef02dd64e3fe2dac11496560241a1a3e7b735
M biometric/src/androidTest/java/androidx/biometric/FingerprintHelperFragmentTest.java
M biometric/src/main/java/androidx/biometric/FingerprintHelperFragment.java
Description
- Device type:
- OS version:
- Biometric library version: 1.0.0-rc02
STEPS TO REPRODUCE
[Be as specific as possible please]
Write robolectric test
1. Show BiometricPrompt
2. Invoke onAuthenticationError(BiometricPrompt.ERROR_HW_UNAVAILABLE, "some message")
EXPECTED RESULTS
prompt should be dismissed because no further authentication can take place
OBSERVED RESULTS
prompt is not dismissed