Fixed
Status Update
No update yet.
Comments
ap...@google.com
Can you explain your use case?
hu...@google.com
ap...@google.com
I can explain my one. I have a navhost fragment, where I load a graph with just one instance of a screen of acceptance of terms of use. After the approval of the user I load the real nav graph into the same navhost. According to the documentation The current data of the graph should be reset, so the new Navigation items can be reached. But unfortunately the new items from the graph cannot be reached.
ap...@google.com
Re #3 - that's not how you should be doing conditional navigation (see the documentation: https://developer.android.com/topic/libraries/architecture/navigation/navigation-conditional ), but we should take a closer look at this anyways.
ap...@google.com
Any updates on this issue?
Thanks
Thanks
ap...@google.com
Navigation now pops all destinations off the back stack (if any exists) when you call setGraph().
This has been fixed internally inhttps://android-review.googlesource.com/867951 and will be available in Navigation 1.0.0-alpha10
This has been fixed internally in
an...@google.com
@6 Can't confirm. Seems it still exists. Here:
ap...@google.com
Project: platform/frameworks/support
Branch: snap-temp-L35100000695851870
commit 05592a19dd8be2804e0c1824ed112153136d26d8
Author: husaynhakeem <husaynhakeem@google.com>
Date: Fri Sep 11 00:24:35 2020
Fix bug in validating file save destination for image capture
To validate the save destination of image capture when the outputOption contains a file, try opening a write stream to the file. If it succeeds, the file is writable and the image capture save location is valid, otherwise it's invalid.
This validation previously used File.canWrite(), this works correctly for files that are actually created (e.g. using File.createTemp()). When creating a file object with `new File(...)`, the method constantly returns false. This was causing the tests in the rotation test app (uiwidgets/rotations) to fail.
Bug: 167697553
Test: ImageSaveLocationValidatorTest.java + ImageCapture rotation tests
Change-Id: I8c5656fcc5da0c477203b3b5c8bb450be148b323
(cherry picked from commit ee9fa116b553b77b17badd7cac58374c99651753)
M camera/camera-core/src/main/java/androidx/camera/core/ImageSaveLocationValidator.java
M camera/camera-core/src/test/java/androidx/camera/core/ImageSaveLocationValidatorTest.java
https://android-review.googlesource.com/1430181
Branch: snap-temp-L35100000695851870
commit 05592a19dd8be2804e0c1824ed112153136d26d8
Author: husaynhakeem <husaynhakeem@google.com>
Date: Fri Sep 11 00:24:35 2020
Fix bug in validating file save destination for image capture
To validate the save destination of image capture when the outputOption contains a file, try opening a write stream to the file. If it succeeds, the file is writable and the image capture save location is valid, otherwise it's invalid.
This validation previously used File.canWrite(), this works correctly for files that are actually created (e.g. using File.createTemp()). When creating a file object with `new File(...)`, the method constantly returns false. This was causing the tests in the rotation test app (uiwidgets/rotations) to fail.
Bug: 167697553
Test: ImageSaveLocationValidatorTest.java + ImageCapture rotation tests
Change-Id: I8c5656fcc5da0c477203b3b5c8bb450be148b323
(cherry picked from commit ee9fa116b553b77b17badd7cac58374c99651753)
M camera/camera-core/src/main/java/androidx/camera/core/ImageSaveLocationValidator.java
M camera/camera-core/src/test/java/androidx/camera/core/ImageSaveLocationValidatorTest.java
Description
When the user specifies a destination to store the result of an image capture (with the use of
outputFileOptions), theImageCaptureuse case should verify whether this destination is valid before triggering the image capture request to the camera. If the destination is not valid, the operation should fail fast and the user should be notified about it.